All of lore.kernel.org
 help / color / mirror / Atom feed
From: Rob Herring <robh@kernel.org>
To: Krzysztof Kozlowski <krzk@kernel.org>
Cc: Marek Szyprowski <m.szyprowski@samsung.com>,
	Jonathan Cameron <jic23@kernel.org>,
	Lars-Peter Clausen <lars@metafoo.de>,
	Peter Meerwald-Stadler <pmeerw@pmeerw.net>,
	Lee Jones <lee.jones@linaro.org>, Mark Brown <broonie@kernel.org>,
	linux-iio@vger.kernel.org, devicetree@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] dt-bindings: iio: samsung,exynos-adc: add common clock properties
Date: Fri, 5 Mar 2021 14:41:52 -0600	[thread overview]
Message-ID: <20210305204152.GA607635@robh.at.kernel.org> (raw)
In-Reply-To: <20210215092915.7khog24shtzjzd6g@kozik-lap>

On Mon, Feb 15, 2021 at 10:29:15AM +0100, Krzysztof Kozlowski wrote:
> On Mon, Feb 15, 2021 at 10:01:48AM +0100, Marek Szyprowski wrote:
> > Hi Krzysztof,
> > 
> > On 12.02.2021 17:38, Krzysztof Kozlowski wrote:
> > > Add common properties appearing in DTSes (assigned-clocks and similar)
> > > to fix dtbs_check warnings like:
> > >
> > >    arch/arm/boot/dts/exynos3250-artik5-eval.dt.yaml:
> > >      adc@126c0000: assigned-clock-rates: [[6000000]] is not of type 'object'
> > >    arch/arm/boot/dts/exynos3250-artik5-eval.dt.yaml:
> > >      adc@126c0000: assigned-clocks: [[7, 238]] is not of type 'object'
> > 
> > Does it mean that assigned-clocks related properties have to be added to 
> > almost all bindings?
> 
> To my understanding: yes, and we already added it to multiple schemas.
> 
> > IMHO this is an over-engineering and this has to be 
> > handled somewhere else...
> 
> Would have to be made a part of the core schema (just like pinctrl nodes
> etc).

That's the case now. It's contingent on having a 'clocks' property in 
the node.

Rob

WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robh@kernel.org>
To: Krzysztof Kozlowski <krzk@kernel.org>
Cc: Marek Szyprowski <m.szyprowski@samsung.com>,
	Jonathan Cameron <jic23@kernel.org>,
	Lars-Peter Clausen <lars@metafoo.de>,
	Peter Meerwald-Stadler <pmeerw@pmeerw.net>,
	Lee Jones <lee.jones@linaro.org>, Mark Brown <broonie@kernel.org>,
	linux-iio@vger.kernel.org, devicetree@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] dt-bindings: iio: samsung,exynos-adc: add common clock properties
Date: Fri, 5 Mar 2021 14:41:52 -0600	[thread overview]
Message-ID: <20210305204152.GA607635@robh.at.kernel.org> (raw)
In-Reply-To: <20210215092915.7khog24shtzjzd6g@kozik-lap>

On Mon, Feb 15, 2021 at 10:29:15AM +0100, Krzysztof Kozlowski wrote:
> On Mon, Feb 15, 2021 at 10:01:48AM +0100, Marek Szyprowski wrote:
> > Hi Krzysztof,
> > 
> > On 12.02.2021 17:38, Krzysztof Kozlowski wrote:
> > > Add common properties appearing in DTSes (assigned-clocks and similar)
> > > to fix dtbs_check warnings like:
> > >
> > >    arch/arm/boot/dts/exynos3250-artik5-eval.dt.yaml:
> > >      adc@126c0000: assigned-clock-rates: [[6000000]] is not of type 'object'
> > >    arch/arm/boot/dts/exynos3250-artik5-eval.dt.yaml:
> > >      adc@126c0000: assigned-clocks: [[7, 238]] is not of type 'object'
> > 
> > Does it mean that assigned-clocks related properties have to be added to 
> > almost all bindings?
> 
> To my understanding: yes, and we already added it to multiple schemas.
> 
> > IMHO this is an over-engineering and this has to be 
> > handled somewhere else...
> 
> Would have to be made a part of the core schema (just like pinctrl nodes
> etc).

That's the case now. It's contingent on having a 'clocks' property in 
the node.

Rob

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2021-03-05 20:42 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CGME20210212164148eucas1p2ab09436a82d50161ff1a9fc1a169f7d7@eucas1p2.samsung.com>
2021-02-12 16:38 ` [PATCH] dt-bindings: iio: samsung,exynos-adc: add common clock properties Krzysztof Kozlowski
2021-02-12 16:38   ` [PATCH] dt-bindings: iio: samsung, exynos-adc: " Krzysztof Kozlowski
2021-02-15  9:01   ` [PATCH] dt-bindings: iio: samsung,exynos-adc: " Marek Szyprowski
2021-02-15  9:01     ` Marek Szyprowski
2021-02-15  9:29     ` Krzysztof Kozlowski
2021-02-15  9:29       ` Krzysztof Kozlowski
2021-03-05 20:41       ` Rob Herring [this message]
2021-03-05 20:41         ` Rob Herring
2021-03-07 11:44         ` Krzysztof Kozlowski
2021-03-07 11:44           ` Krzysztof Kozlowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210305204152.GA607635@robh.at.kernel.org \
    --to=robh@kernel.org \
    --cc=broonie@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=jic23@kernel.org \
    --cc=krzk@kernel.org \
    --cc=lars@metafoo.de \
    --cc=lee.jones@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=m.szyprowski@samsung.com \
    --cc=pmeerw@pmeerw.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.