From: Rob Herring <robh@kernel.org>
To: linux-aspeed@lists.ozlabs.org
Subject: [PATCH 17/19] dt-bindings: ipmi: Add optional SerIRQ property to ASPEED KCS devices
Date: Fri, 5 Mar 2021 17:09:40 -0600 [thread overview]
Message-ID: <20210305230940.GA809870@robh.at.kernel.org> (raw)
In-Reply-To: <20210219142523.3464540-18-andrew@aj.id.au>
On Sat, Feb 20, 2021 at 12:55:21AM +1030, Andrew Jeffery wrote:
> Allocating IO and IRQ resources to LPC devices is in-theory an operation
> for the host, however ASPEED don't appear to expose this capability
> outside the BMC (e.g. SuperIO). Instead, we are left with BMC-internal
> registers for managing these resources, so introduce a devicetree
> property for KCS devices to describe SerIRQ properties.
>
> Signed-off-by: Andrew Jeffery <andrew@aj.id.au>
> ---
> .../bindings/ipmi/aspeed,ast2400-kcs-bmc.yaml | 14 ++++++++++++++
> 1 file changed, 14 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/ipmi/aspeed,ast2400-kcs-bmc.yaml b/Documentation/devicetree/bindings/ipmi/aspeed,ast2400-kcs-bmc.yaml
> index 1c1cc4265948..808475a2c2ca 100644
> --- a/Documentation/devicetree/bindings/ipmi/aspeed,ast2400-kcs-bmc.yaml
> +++ b/Documentation/devicetree/bindings/ipmi/aspeed,ast2400-kcs-bmc.yaml
> @@ -47,6 +47,18 @@ properties:
> channels the status address is derived from the data address, but the
> status address may be optionally provided.
>
> + aspeed,lpc-interrupts:
> + $ref: "/schemas/types.yaml#/definitions/uint32-matrix"
> + minItems: 1
> + maxItems: 1
> + description: |
> + A 2-cell property expressing the LPC SerIRQ number and the interrupt
> + level/sense encoding (specified in the standard fashion).
That would be uint32-array with 'maxItems: 2'.
> +
> + Note that the generated interrupt is issued from the BMC to the host, and
> + thus the target interrupt controller is not captured by the BMC's
> + devicetree.
> +
> kcs_chan:
> deprecated: true
> $ref: '/schemas/types.yaml#/definitions/uint32'
> @@ -84,9 +96,11 @@ allOf:
>
> examples:
> - |
> + #include <dt-bindings/interrupt-controller/irq.h>
> kcs3: kcs at 24 {
> compatible = "aspeed,ast2600-kcs-bmc";
> reg = <0x24 0x1>, <0x30 0x1>, <0x3c 0x1>;
> aspeed,lpc-io-reg = <0xca2>;
> + aspeed,lpc-interrupts = <11 IRQ_TYPE_LEVEL_LOW>;
> interrupts = <8>;
> };
> --
> 2.27.0
>
WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robh@kernel.org>
To: Andrew Jeffery <andrew@aj.id.au>
Cc: openipmi-developer@lists.sourceforge.net,
openbmc@lists.ozlabs.org, minyard@acm.org, joel@jms.id.au,
lee.jones@linaro.org, avifishman70@gmail.com,
tmaimon77@gmail.com, tali.perry1@gmail.com, venture@google.com,
yuenn@google.com, benjaminfair@google.com,
linus.walleij@linaro.org, chiawei_wang@aspeedtech.com,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-aspeed@lists.ozlabs.org, linux-gpio@vger.kernel.org
Subject: Re: [PATCH 17/19] dt-bindings: ipmi: Add optional SerIRQ property to ASPEED KCS devices
Date: Fri, 5 Mar 2021 17:09:40 -0600 [thread overview]
Message-ID: <20210305230940.GA809870@robh.at.kernel.org> (raw)
In-Reply-To: <20210219142523.3464540-18-andrew@aj.id.au>
On Sat, Feb 20, 2021 at 12:55:21AM +1030, Andrew Jeffery wrote:
> Allocating IO and IRQ resources to LPC devices is in-theory an operation
> for the host, however ASPEED don't appear to expose this capability
> outside the BMC (e.g. SuperIO). Instead, we are left with BMC-internal
> registers for managing these resources, so introduce a devicetree
> property for KCS devices to describe SerIRQ properties.
>
> Signed-off-by: Andrew Jeffery <andrew@aj.id.au>
> ---
> .../bindings/ipmi/aspeed,ast2400-kcs-bmc.yaml | 14 ++++++++++++++
> 1 file changed, 14 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/ipmi/aspeed,ast2400-kcs-bmc.yaml b/Documentation/devicetree/bindings/ipmi/aspeed,ast2400-kcs-bmc.yaml
> index 1c1cc4265948..808475a2c2ca 100644
> --- a/Documentation/devicetree/bindings/ipmi/aspeed,ast2400-kcs-bmc.yaml
> +++ b/Documentation/devicetree/bindings/ipmi/aspeed,ast2400-kcs-bmc.yaml
> @@ -47,6 +47,18 @@ properties:
> channels the status address is derived from the data address, but the
> status address may be optionally provided.
>
> + aspeed,lpc-interrupts:
> + $ref: "/schemas/types.yaml#/definitions/uint32-matrix"
> + minItems: 1
> + maxItems: 1
> + description: |
> + A 2-cell property expressing the LPC SerIRQ number and the interrupt
> + level/sense encoding (specified in the standard fashion).
That would be uint32-array with 'maxItems: 2'.
> +
> + Note that the generated interrupt is issued from the BMC to the host, and
> + thus the target interrupt controller is not captured by the BMC's
> + devicetree.
> +
> kcs_chan:
> deprecated: true
> $ref: '/schemas/types.yaml#/definitions/uint32'
> @@ -84,9 +96,11 @@ allOf:
>
> examples:
> - |
> + #include <dt-bindings/interrupt-controller/irq.h>
> kcs3: kcs@24 {
> compatible = "aspeed,ast2600-kcs-bmc";
> reg = <0x24 0x1>, <0x30 0x1>, <0x3c 0x1>;
> aspeed,lpc-io-reg = <0xca2>;
> + aspeed,lpc-interrupts = <11 IRQ_TYPE_LEVEL_LOW>;
> interrupts = <8>;
> };
> --
> 2.27.0
>
WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robh@kernel.org>
To: Andrew Jeffery <andrew@aj.id.au>
Cc: devicetree@vger.kernel.org, chiawei_wang@aspeedtech.com,
tmaimon77@gmail.com, minyard@acm.org, linux-gpio@vger.kernel.org,
avifishman70@gmail.com, venture@google.com,
openbmc@lists.ozlabs.org, linux-kernel@vger.kernel.org,
tali.perry1@gmail.com, linux-aspeed@lists.ozlabs.org,
openipmi-developer@lists.sourceforge.net, lee.jones@linaro.org,
linus.walleij@linaro.org, linux-arm-kernel@lists.infradead.org,
benjaminfair@google.com
Subject: Re: [PATCH 17/19] dt-bindings: ipmi: Add optional SerIRQ property to ASPEED KCS devices
Date: Fri, 5 Mar 2021 17:09:40 -0600 [thread overview]
Message-ID: <20210305230940.GA809870@robh.at.kernel.org> (raw)
In-Reply-To: <20210219142523.3464540-18-andrew@aj.id.au>
On Sat, Feb 20, 2021 at 12:55:21AM +1030, Andrew Jeffery wrote:
> Allocating IO and IRQ resources to LPC devices is in-theory an operation
> for the host, however ASPEED don't appear to expose this capability
> outside the BMC (e.g. SuperIO). Instead, we are left with BMC-internal
> registers for managing these resources, so introduce a devicetree
> property for KCS devices to describe SerIRQ properties.
>
> Signed-off-by: Andrew Jeffery <andrew@aj.id.au>
> ---
> .../bindings/ipmi/aspeed,ast2400-kcs-bmc.yaml | 14 ++++++++++++++
> 1 file changed, 14 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/ipmi/aspeed,ast2400-kcs-bmc.yaml b/Documentation/devicetree/bindings/ipmi/aspeed,ast2400-kcs-bmc.yaml
> index 1c1cc4265948..808475a2c2ca 100644
> --- a/Documentation/devicetree/bindings/ipmi/aspeed,ast2400-kcs-bmc.yaml
> +++ b/Documentation/devicetree/bindings/ipmi/aspeed,ast2400-kcs-bmc.yaml
> @@ -47,6 +47,18 @@ properties:
> channels the status address is derived from the data address, but the
> status address may be optionally provided.
>
> + aspeed,lpc-interrupts:
> + $ref: "/schemas/types.yaml#/definitions/uint32-matrix"
> + minItems: 1
> + maxItems: 1
> + description: |
> + A 2-cell property expressing the LPC SerIRQ number and the interrupt
> + level/sense encoding (specified in the standard fashion).
That would be uint32-array with 'maxItems: 2'.
> +
> + Note that the generated interrupt is issued from the BMC to the host, and
> + thus the target interrupt controller is not captured by the BMC's
> + devicetree.
> +
> kcs_chan:
> deprecated: true
> $ref: '/schemas/types.yaml#/definitions/uint32'
> @@ -84,9 +96,11 @@ allOf:
>
> examples:
> - |
> + #include <dt-bindings/interrupt-controller/irq.h>
> kcs3: kcs@24 {
> compatible = "aspeed,ast2600-kcs-bmc";
> reg = <0x24 0x1>, <0x30 0x1>, <0x3c 0x1>;
> aspeed,lpc-io-reg = <0xca2>;
> + aspeed,lpc-interrupts = <11 IRQ_TYPE_LEVEL_LOW>;
> interrupts = <8>;
> };
> --
> 2.27.0
>
WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robh@kernel.org>
To: Andrew Jeffery <andrew@aj.id.au>
Cc: openipmi-developer@lists.sourceforge.net,
openbmc@lists.ozlabs.org, minyard@acm.org, joel@jms.id.au,
lee.jones@linaro.org, avifishman70@gmail.com,
tmaimon77@gmail.com, tali.perry1@gmail.com, venture@google.com,
yuenn@google.com, benjaminfair@google.com,
linus.walleij@linaro.org, chiawei_wang@aspeedtech.com,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-aspeed@lists.ozlabs.org, linux-gpio@vger.kernel.org
Subject: Re: [PATCH 17/19] dt-bindings: ipmi: Add optional SerIRQ property to ASPEED KCS devices
Date: Fri, 5 Mar 2021 17:09:40 -0600 [thread overview]
Message-ID: <20210305230940.GA809870@robh.at.kernel.org> (raw)
In-Reply-To: <20210219142523.3464540-18-andrew@aj.id.au>
On Sat, Feb 20, 2021 at 12:55:21AM +1030, Andrew Jeffery wrote:
> Allocating IO and IRQ resources to LPC devices is in-theory an operation
> for the host, however ASPEED don't appear to expose this capability
> outside the BMC (e.g. SuperIO). Instead, we are left with BMC-internal
> registers for managing these resources, so introduce a devicetree
> property for KCS devices to describe SerIRQ properties.
>
> Signed-off-by: Andrew Jeffery <andrew@aj.id.au>
> ---
> .../bindings/ipmi/aspeed,ast2400-kcs-bmc.yaml | 14 ++++++++++++++
> 1 file changed, 14 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/ipmi/aspeed,ast2400-kcs-bmc.yaml b/Documentation/devicetree/bindings/ipmi/aspeed,ast2400-kcs-bmc.yaml
> index 1c1cc4265948..808475a2c2ca 100644
> --- a/Documentation/devicetree/bindings/ipmi/aspeed,ast2400-kcs-bmc.yaml
> +++ b/Documentation/devicetree/bindings/ipmi/aspeed,ast2400-kcs-bmc.yaml
> @@ -47,6 +47,18 @@ properties:
> channels the status address is derived from the data address, but the
> status address may be optionally provided.
>
> + aspeed,lpc-interrupts:
> + $ref: "/schemas/types.yaml#/definitions/uint32-matrix"
> + minItems: 1
> + maxItems: 1
> + description: |
> + A 2-cell property expressing the LPC SerIRQ number and the interrupt
> + level/sense encoding (specified in the standard fashion).
That would be uint32-array with 'maxItems: 2'.
> +
> + Note that the generated interrupt is issued from the BMC to the host, and
> + thus the target interrupt controller is not captured by the BMC's
> + devicetree.
> +
> kcs_chan:
> deprecated: true
> $ref: '/schemas/types.yaml#/definitions/uint32'
> @@ -84,9 +96,11 @@ allOf:
>
> examples:
> - |
> + #include <dt-bindings/interrupt-controller/irq.h>
> kcs3: kcs@24 {
> compatible = "aspeed,ast2600-kcs-bmc";
> reg = <0x24 0x1>, <0x30 0x1>, <0x3c 0x1>;
> aspeed,lpc-io-reg = <0xca2>;
> + aspeed,lpc-interrupts = <11 IRQ_TYPE_LEVEL_LOW>;
> interrupts = <8>;
> };
> --
> 2.27.0
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-03-05 23:09 UTC|newest]
Thread overview: 106+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-19 14:25 [PATCH 00/19] ipmi: Allow raw access to KCS devices Andrew Jeffery
2021-02-19 14:25 ` Andrew Jeffery
2021-02-19 14:25 ` Andrew Jeffery
2021-02-19 14:25 ` Andrew Jeffery
2021-02-19 14:25 ` [PATCH 01/19] dt-bindings: aspeed-lpc: Remove LPC partitioning Andrew Jeffery
2021-02-19 14:25 ` Andrew Jeffery
2021-02-19 14:25 ` Andrew Jeffery
2021-02-19 14:25 ` Andrew Jeffery
2021-02-22 9:04 ` Lee Jones
2021-02-22 9:04 ` Lee Jones
2021-02-22 9:04 ` Lee Jones
2021-02-22 9:04 ` Lee Jones
2021-02-19 14:25 ` [PATCH 02/19] ARM: dts: Remove LPC BMC and Host partitions Andrew Jeffery
2021-02-19 14:25 ` Andrew Jeffery
2021-02-19 14:25 ` Andrew Jeffery
2021-02-19 14:25 ` Andrew Jeffery
2021-02-19 14:25 ` [PATCH 03/19] ipmi: kcs: aspeed: Adapt to new LPC DTS layout Andrew Jeffery
2021-02-19 14:25 ` Andrew Jeffery
2021-02-19 14:25 ` Andrew Jeffery
2021-02-19 14:25 ` Andrew Jeffery
2021-02-19 14:25 ` [PATCH 04/19] pinctrl: aspeed-g5: Adapt to new LPC device tree layout Andrew Jeffery
2021-02-19 14:25 ` Andrew Jeffery
2021-02-19 14:25 ` Andrew Jeffery
2021-02-19 14:25 ` Andrew Jeffery
2021-02-19 14:25 ` [PATCH 05/19] soc: aspeed: " Andrew Jeffery
2021-02-19 14:25 ` Andrew Jeffery
2021-02-19 14:25 ` Andrew Jeffery
2021-02-19 14:25 ` Andrew Jeffery
2021-02-19 14:25 ` [PATCH 06/19] ipmi: kcs_bmc_aspeed: Use of match data to extract KCS properties Andrew Jeffery
2021-02-19 14:25 ` Andrew Jeffery
2021-02-19 14:25 ` Andrew Jeffery
2021-02-19 14:25 ` Andrew Jeffery
2021-02-19 14:25 ` [PATCH 07/19] ipmi: kcs_bmc: Make status update atomic Andrew Jeffery
2021-02-19 14:25 ` Andrew Jeffery
2021-02-19 14:25 ` Andrew Jeffery
2021-02-19 14:25 ` Andrew Jeffery
2021-02-19 14:25 ` [PATCH 08/19] ipmi: kcs_bmc: Rename {read, write}_{status, data}() functions Andrew Jeffery
2021-02-19 14:25 ` Andrew Jeffery
2021-02-19 14:25 ` Andrew Jeffery
2021-02-19 14:25 ` [PATCH 08/19] ipmi: kcs_bmc: Rename {read,write}_{status,data}() functions Andrew Jeffery
2021-02-19 14:25 ` [PATCH 09/19] ipmi: kcs_bmc: Split out kcs_bmc_cdev_ipmi Andrew Jeffery
2021-02-19 14:25 ` Andrew Jeffery
2021-02-19 14:25 ` Andrew Jeffery
2021-02-19 14:25 ` Andrew Jeffery
2021-02-19 14:25 ` [PATCH 10/19] ipmi: kcs_bmc: Turn the driver data-structures inside-out Andrew Jeffery
2021-02-19 14:25 ` Andrew Jeffery
2021-02-19 14:25 ` Andrew Jeffery
2021-02-19 14:25 ` Andrew Jeffery
2021-02-19 14:25 ` [PATCH 11/19] ipmi: kcs_bmc: Split headers into device and client Andrew Jeffery
2021-02-19 14:25 ` Andrew Jeffery
2021-02-19 14:25 ` Andrew Jeffery
2021-02-19 14:25 ` Andrew Jeffery
2021-02-19 14:25 ` [PATCH 12/19] ipmi: kcs_bmc: Strip private client data from struct kcs_bmc Andrew Jeffery
2021-02-19 14:25 ` Andrew Jeffery
2021-02-19 14:25 ` Andrew Jeffery
2021-02-19 14:25 ` Andrew Jeffery
2021-02-21 13:55 ` kernel test robot
2021-02-21 13:55 ` kernel test robot
2021-02-19 14:25 ` [PATCH 13/19] ipmi: kcs_bmc: Decouple the IPMI chardev from the core Andrew Jeffery
2021-02-19 14:25 ` Andrew Jeffery
2021-02-19 14:25 ` Andrew Jeffery
2021-02-19 14:25 ` Andrew Jeffery
2021-02-19 14:25 ` [PATCH 14/19] ipmi: kcs_bmc: Allow clients to control KCS IRQ state Andrew Jeffery
2021-02-19 14:25 ` Andrew Jeffery
2021-02-19 14:25 ` Andrew Jeffery
2021-02-19 14:25 ` Andrew Jeffery
2021-02-19 14:25 ` [PATCH 15/19] ipmi: kcs_bmc: Add a "raw" character device interface Andrew Jeffery
2021-02-19 14:25 ` Andrew Jeffery
2021-02-19 14:25 ` Andrew Jeffery
2021-02-19 14:25 ` Andrew Jeffery
2021-02-21 13:54 ` kernel test robot
2021-02-21 13:54 ` kernel test robot
2021-02-21 15:36 ` kernel test robot
2021-02-21 15:36 ` kernel test robot
2021-02-19 14:25 ` [PATCH 16/19] dt-bindings: ipmi: Convert ASPEED KCS binding to schema Andrew Jeffery
2021-02-19 14:25 ` Andrew Jeffery
2021-02-19 14:25 ` Andrew Jeffery
2021-02-19 14:25 ` Andrew Jeffery
2021-03-05 23:07 ` Rob Herring
2021-03-05 23:07 ` Rob Herring
2021-03-05 23:07 ` Rob Herring
2021-03-05 23:07 ` Rob Herring
2021-03-09 2:45 ` Andrew Jeffery
2021-03-09 2:45 ` Andrew Jeffery
2021-03-09 2:45 ` Andrew Jeffery
2021-03-09 2:45 ` Andrew Jeffery
2021-02-19 14:25 ` [PATCH 17/19] dt-bindings: ipmi: Add optional SerIRQ property to ASPEED KCS devices Andrew Jeffery
2021-02-19 14:25 ` Andrew Jeffery
2021-02-19 14:25 ` Andrew Jeffery
2021-02-19 14:25 ` Andrew Jeffery
2021-03-05 23:09 ` Rob Herring [this message]
2021-03-05 23:09 ` Rob Herring
2021-03-05 23:09 ` Rob Herring
2021-03-05 23:09 ` Rob Herring
2021-03-09 2:44 ` Andrew Jeffery
2021-03-09 2:44 ` Andrew Jeffery
2021-03-09 2:44 ` Andrew Jeffery
2021-03-09 2:44 ` Andrew Jeffery
2021-02-19 14:25 ` [PATCH 18/19] ipmi: kcs_bmc_aspeed: Implement KCS SerIRQ configuration Andrew Jeffery
2021-02-19 14:25 ` Andrew Jeffery
2021-02-19 14:25 ` Andrew Jeffery
2021-02-19 14:25 ` Andrew Jeffery
2021-02-19 14:25 ` [PATCH 19/19] ipmi: kcs_bmc_aspeed: Fix IBFIE typo from datasheet Andrew Jeffery
2021-02-19 14:25 ` Andrew Jeffery
2021-02-19 14:25 ` Andrew Jeffery
2021-02-19 14:25 ` Andrew Jeffery
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210305230940.GA809870@robh.at.kernel.org \
--to=robh@kernel.org \
--cc=linux-aspeed@lists.ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.