All of lore.kernel.org
 help / color / mirror / Atom feed
From: Shawn Guo <shawn.guo@linaro.org>
To: Ard Biesheuvel <ardb@kernel.org>
Cc: linux-efi@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	Jeffrey Hugo <jhugo@codeaurora.org>,
	Bjorn Andersson <bjorn.andersson@linaro.org>,
	Rob Clark <robdclark@gmail.com>,
	Leif Lindholm <leif@nuviainc.com>,
	linux-arm-msm@vger.kernel.org
Subject: Re: [PATCH 1/1] efi: stub: omit SetVirtualAddressMap() if marked unsupported in RT_PROP table
Date: Sat, 6 Mar 2021 17:45:18 +0800	[thread overview]
Message-ID: <20210306094517.GN17424@dragon> (raw)
In-Reply-To: <20210305093958.187358-2-ardb@kernel.org>

On Fri, Mar 05, 2021 at 10:39:58AM +0100, Ard Biesheuvel wrote:
> The EFI_RT_PROPERTIES_TABLE contains a mask of runtime services that are
> available after ExitBootServices(). This mostly does not concern the EFI
> stub at all, given that it runs before that. However, there is one call
> that is made at runtime, which is the call to SetVirtualAddressMap()
> (which is not even callable at boot time to begin with)
> 
> So add the missing handling of the RT_PROP table to ensure that we only
> call SetVirtualAddressMap() if it is not being advertised as unsupported
> by the firmware.
> 
> Signed-off-by: Ard Biesheuvel <ardb@kernel.org>

On Lenovo Yoga C630 laptop:

Tested-by: Shawn Guo <shawn.guo@linaro.org>

It's a great help to dropping 'efi=novamap' kernel cmdline, which is a
very nice thing for distros to support Snapdragon laptops.

Thanks much, Ard!

Shawn

WARNING: multiple messages have this Message-ID (diff)
From: Shawn Guo <shawn.guo@linaro.org>
To: Ard Biesheuvel <ardb@kernel.org>
Cc: linux-efi@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	Jeffrey Hugo <jhugo@codeaurora.org>,
	Bjorn Andersson <bjorn.andersson@linaro.org>,
	Rob Clark <robdclark@gmail.com>,
	Leif Lindholm <leif@nuviainc.com>,
	linux-arm-msm@vger.kernel.org
Subject: Re: [PATCH 1/1] efi: stub: omit SetVirtualAddressMap() if marked unsupported in RT_PROP table
Date: Sat, 6 Mar 2021 17:45:18 +0800	[thread overview]
Message-ID: <20210306094517.GN17424@dragon> (raw)
In-Reply-To: <20210305093958.187358-2-ardb@kernel.org>

On Fri, Mar 05, 2021 at 10:39:58AM +0100, Ard Biesheuvel wrote:
> The EFI_RT_PROPERTIES_TABLE contains a mask of runtime services that are
> available after ExitBootServices(). This mostly does not concern the EFI
> stub at all, given that it runs before that. However, there is one call
> that is made at runtime, which is the call to SetVirtualAddressMap()
> (which is not even callable at boot time to begin with)
> 
> So add the missing handling of the RT_PROP table to ensure that we only
> call SetVirtualAddressMap() if it is not being advertised as unsupported
> by the firmware.
> 
> Signed-off-by: Ard Biesheuvel <ardb@kernel.org>

On Lenovo Yoga C630 laptop:

Tested-by: Shawn Guo <shawn.guo@linaro.org>

It's a great help to dropping 'efi=novamap' kernel cmdline, which is a
very nice thing for distros to support Snapdragon laptops.

Thanks much, Ard!

Shawn

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2021-03-06  9:46 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-05  9:39 [PATCH 0/1] use RT_PROPERTIES table to implement efi=novamap Ard Biesheuvel
2021-03-05  9:39 ` Ard Biesheuvel
2021-03-05  9:39 ` [PATCH 1/1] efi: stub: omit SetVirtualAddressMap() if marked unsupported in RT_PROP table Ard Biesheuvel
2021-03-05  9:39   ` Ard Biesheuvel
2021-03-06  9:45   ` Shawn Guo [this message]
2021-03-06  9:45     ` Shawn Guo
2021-03-05 11:44 ` [PATCH 0/1] use RT_PROPERTIES table to implement efi=novamap Ard Biesheuvel
2021-03-05 11:44   ` Ard Biesheuvel
2021-03-06 10:05 ` Shawn Guo
2021-03-06 10:05   ` Shawn Guo
2021-05-26 19:03 ` patchwork-bot+linux-arm-msm

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210306094517.GN17424@dragon \
    --to=shawn.guo@linaro.org \
    --cc=ardb@kernel.org \
    --cc=bjorn.andersson@linaro.org \
    --cc=jhugo@codeaurora.org \
    --cc=leif@nuviainc.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-efi@vger.kernel.org \
    --cc=robdclark@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.