drivers/mmc/host/via-sdmmc.c:1274:5-8: Unneeded variable: "ret". Return "0" on line 1295

drivers/mmc/host/via-sdmmc.c:1274:5-8: Unneeded variable: "ret". Return "0" on line 1295

[kernel test robot]

[-- Attachment #1: Type: text/plain, Size: 1056 bytes --]

CC: kbuild-all(a)01.org
CC: linux-kernel(a)vger.kernel.org
TO: Vaibhav Gupta <vaibhavgupta40@gmail.com>
CC: Ulf Hansson <ulf.hansson@linaro.org>

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head:   a38fd8748464831584a19438cbb3082b5a2dab15
commit: 0d776e5bede6d375c617a03262eee9d2a8a58b75 mmc: via-sdmmc: use generic power management
date:   8 months ago
:::::: branch date: 2 days ago
:::::: commit date: 8 months ago
config: x86_64-randconfig-c002-20210307 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Julia Lawall <julia.lawall@lip6.fr>


"coccinelle warnings: (new ones prefixed by >>)"
>> drivers/mmc/host/via-sdmmc.c:1274:5-8: Unneeded variable: "ret". Return "0" on line 1295

Please review and possibly fold the followup patch.

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 36555 bytes --]

[PATCH] mmc: via-sdmmc: fix returnvar.cocci warnings

[kernel test robot]

[-- Attachment #1: Type: text/plain, Size: 1756 bytes --]

CC: kbuild-all(a)01.org
CC: linux-kernel(a)vger.kernel.org
TO: Vaibhav Gupta <vaibhavgupta40@gmail.com>
CC: Ulf Hansson <ulf.hansson@linaro.org>
CC: Bruce Chang <brucechang@via.com.tw>
CC: Harald Welte <HaraldWelte@viatech.com>
CC: linux-mmc(a)vger.kernel.org
CC: linux-kernel(a)vger.kernel.org

From: kernel test robot <lkp@intel.com>

drivers/mmc/host/via-sdmmc.c:1274:5-8: Unneeded variable: "ret". Return "0" on line 1295


 Remove unneeded variable used to store return value.

Generated by: scripts/coccinelle/misc/returnvar.cocci

Fixes: 0d776e5bede6 ("mmc: via-sdmmc: use generic power management")
CC: Vaibhav Gupta <vaibhavgupta40@gmail.com>
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: kernel test robot <lkp@intel.com>
---

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head:   a38fd8748464831584a19438cbb3082b5a2dab15
commit: 0d776e5bede6d375c617a03262eee9d2a8a58b75 mmc: via-sdmmc: use generic power management
:::::: branch date: 2 days ago
:::::: commit date: 8 months ago

Please take the patch only if it's a positive warning. Thanks!

 via-sdmmc.c |    3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

--- a/drivers/mmc/host/via-sdmmc.c
+++ b/drivers/mmc/host/via-sdmmc.c
@@ -1271,7 +1271,6 @@ static int __maybe_unused via_sd_suspend
 static int __maybe_unused via_sd_resume(struct device *dev)
 {
 	struct via_crdr_mmc_host *sdhost;
-	int ret = 0;
 	u8 gatt;
 
 	sdhost = dev_get_drvdata(dev);
@@ -1292,7 +1291,7 @@ static int __maybe_unused via_sd_resume(
 	via_restore_pcictrlreg(sdhost);
 	via_init_sdc_pm(sdhost);
 
-	return ret;
+	return 0;
 }
 
 static SIMPLE_DEV_PM_OPS(via_sd_pm_ops, via_sd_suspend, via_sd_resume);