All of lore.kernel.org
 help / color / mirror / Atom feed
From: Shawn Guo <shawnguo@kernel.org>
To: Sebastian Reichel <sebastian.reichel@collabora.com>
Cc: Sascha Hauer <s.hauer@pengutronix.de>,
	Pengutronix Kernel Team <kernel@pengutronix.de>,
	Fabio Estevam <festevam@gmail.com>,
	NXP Linux Team <linux-imx@nxp.com>,
	Rob Herring <robh+dt@kernel.org>,
	devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, kernel@collabora.com
Subject: Re: [PATCHv1 1/4] ARM: dts: imx: ba16: add USB OTG VBUS enable GPIO
Date: Mon, 8 Mar 2021 08:35:27 +0800	[thread overview]
Message-ID: <20210308003526.GK543@dragon> (raw)
In-Reply-To: <20210223183346.138575-2-sebastian.reichel@collabora.com>

On Tue, Feb 23, 2021 at 07:33:43PM +0100, Sebastian Reichel wrote:
> Add VBUS regulator GPIO information, so that USB OTG port can
> also be used in host mode.
> 
> Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com>

'ARM: dts: imx6q-ba16: ' this style for prefix maybe?

> ---
>  arch/arm/boot/dts/imx6q-ba16.dtsi | 10 ++++++++++
>  1 file changed, 10 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/imx6q-ba16.dtsi b/arch/arm/boot/dts/imx6q-ba16.dtsi
> index e4578ed3371e..4793ef5171aa 100644
> --- a/arch/arm/boot/dts/imx6q-ba16.dtsi
> +++ b/arch/arm/boot/dts/imx6q-ba16.dtsi
> @@ -124,6 +124,10 @@ reg_usb_otg_vbus: regulator-usbotgvbus {
>  		regulator-name = "usb_otg_vbus";
>  		regulator-min-microvolt = <5000000>;
>  		regulator-max-microvolt = <5000000>;
> +

This is newline is not necessary.

Shawn

> +		pinctrl-0 = <&pinctrl_usbotg_vbus>;
> +		gpio = <&gpio4 15 GPIO_ACTIVE_HIGH>;
> +		enable-active-high;
>  	};
>  };
>  
> @@ -575,6 +579,12 @@ MX6QDL_PAD_ENET_RX_ER__USB_OTG_ID 0x17059
>  		>;
>  	};
>  
> +	pinctrl_usbotg_vbus: usbotgvbusgrp {
> +		fsl,pins = <
> +			MX6QDL_PAD_KEY_ROW4__GPIO4_IO15 0x000b0
> +		>;
> +	};
> +
>  	pinctrl_usdhc2: usdhc2grp {
>  		fsl,pins = <
>  			MX6QDL_PAD_SD2_CMD__SD2_CMD	0x17059
> -- 
> 2.30.0
> 

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

WARNING: multiple messages have this Message-ID (diff)
From: Shawn Guo <shawnguo@kernel.org>
To: Sebastian Reichel <sebastian.reichel@collabora.com>
Cc: Sascha Hauer <s.hauer@pengutronix.de>,
	Pengutronix Kernel Team <kernel@pengutronix.de>,
	Fabio Estevam <festevam@gmail.com>,
	NXP Linux Team <linux-imx@nxp.com>,
	Rob Herring <robh+dt@kernel.org>,
	devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, kernel@collabora.com
Subject: Re: [PATCHv1 1/4] ARM: dts: imx: ba16: add USB OTG VBUS enable GPIO
Date: Mon, 8 Mar 2021 08:35:27 +0800	[thread overview]
Message-ID: <20210308003526.GK543@dragon> (raw)
In-Reply-To: <20210223183346.138575-2-sebastian.reichel@collabora.com>

On Tue, Feb 23, 2021 at 07:33:43PM +0100, Sebastian Reichel wrote:
> Add VBUS regulator GPIO information, so that USB OTG port can
> also be used in host mode.
> 
> Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com>

'ARM: dts: imx6q-ba16: ' this style for prefix maybe?

> ---
>  arch/arm/boot/dts/imx6q-ba16.dtsi | 10 ++++++++++
>  1 file changed, 10 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/imx6q-ba16.dtsi b/arch/arm/boot/dts/imx6q-ba16.dtsi
> index e4578ed3371e..4793ef5171aa 100644
> --- a/arch/arm/boot/dts/imx6q-ba16.dtsi
> +++ b/arch/arm/boot/dts/imx6q-ba16.dtsi
> @@ -124,6 +124,10 @@ reg_usb_otg_vbus: regulator-usbotgvbus {
>  		regulator-name = "usb_otg_vbus";
>  		regulator-min-microvolt = <5000000>;
>  		regulator-max-microvolt = <5000000>;
> +

This is newline is not necessary.

Shawn

> +		pinctrl-0 = <&pinctrl_usbotg_vbus>;
> +		gpio = <&gpio4 15 GPIO_ACTIVE_HIGH>;
> +		enable-active-high;
>  	};
>  };
>  
> @@ -575,6 +579,12 @@ MX6QDL_PAD_ENET_RX_ER__USB_OTG_ID 0x17059
>  		>;
>  	};
>  
> +	pinctrl_usbotg_vbus: usbotgvbusgrp {
> +		fsl,pins = <
> +			MX6QDL_PAD_KEY_ROW4__GPIO4_IO15 0x000b0
> +		>;
> +	};
> +
>  	pinctrl_usdhc2: usdhc2grp {
>  		fsl,pins = <
>  			MX6QDL_PAD_SD2_CMD__SD2_CMD	0x17059
> -- 
> 2.30.0
> 

  reply	other threads:[~2021-03-08  0:37 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-23 18:33 [PATCHv1 0/4] Bx50v3 DT improvements Sebastian Reichel
2021-02-23 18:33 ` Sebastian Reichel
2021-02-23 18:33 ` [PATCHv1 1/4] ARM: dts: imx: ba16: add USB OTG VBUS enable GPIO Sebastian Reichel
2021-02-23 18:33   ` Sebastian Reichel
2021-03-08  0:35   ` Shawn Guo [this message]
2021-03-08  0:35     ` Shawn Guo
2021-02-23 18:33 ` [PATCHv1 2/4] ARM: dts: imx: ba16: improve PHY information Sebastian Reichel
2021-02-23 18:33   ` Sebastian Reichel
2021-03-08  0:38   ` Shawn Guo
2021-03-08  0:38     ` Shawn Guo
2021-02-23 18:33 ` [PATCHv1 3/4] ARM: dts: imx: bx50v3: i2c GPIOs are open drain Sebastian Reichel
2021-02-23 18:33   ` Sebastian Reichel
2021-02-23 18:33 ` [PATCHv1 4/4] ARM: dts: imx: bx50v3: Define GPIO line names Sebastian Reichel
2021-02-23 18:33   ` Sebastian Reichel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210308003526.GK543@dragon \
    --to=shawnguo@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=festevam@gmail.com \
    --cc=kernel@collabora.com \
    --cc=kernel@pengutronix.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-imx@nxp.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=robh+dt@kernel.org \
    --cc=s.hauer@pengutronix.de \
    --cc=sebastian.reichel@collabora.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.