From: "hch@lst.de" <hch@lst.de>
To: "Williams, Dan J" <dan.j.williams@intel.com>
Cc: "hch@lst.de" <hch@lst.de>, lkp <lkp@intel.com>,
"hare@suse.de" <hare@suse.de>,
"olkuroch@cisco.com" <olkuroch@cisco.com>,
"linux-nvdimm@lists.01.org" <linux-nvdimm@lists.01.org>,
"lkp@lists.01.org" <lkp@lists.01.org>,
"ming.lei@redhat.com" <ming.lei@redhat.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"axboe@kernel.dk" <axboe@kernel.dk>,
"Sang, Oliver" <oliver.sang@intel.com>
Subject: Re: [block] 52f019d43c: ndctl.test-libndctl.fail
Date: Mon, 8 Mar 2021 08:09:15 +0100 [thread overview]
Message-ID: <20210308070915.GA32695@lst.de> (raw)
In-Reply-To: <6f40b1f53c029788e20fe175618d8772e36d648c.camel@intel.com>
On Sat, Mar 06, 2021 at 08:33:04PM +0000, Williams, Dan J wrote:
> Yes, it looks like my unit test checks for exactly the behavior you
> changed. It was convenient to test that the device could be switched
> back to rw via BLKROSET, but I don't require that. The new behaviour of
> letting the disk->ro take precedence makes more sense to me, so I'll
> update the test for the new behaviour.
>
> I.e. I don't think regressing a unit test counts as a userspace
> regression.
Ok, thanks for the confirmation.
_______________________________________________
Linux-nvdimm mailing list -- linux-nvdimm@lists.01.org
To unsubscribe send an email to linux-nvdimm-leave@lists.01.org
WARNING: multiple messages have this Message-ID (diff)
From: hch@lst.de
To: lkp@lists.01.org
Subject: Re: [block] 52f019d43c: ndctl.test-libndctl.fail
Date: Mon, 08 Mar 2021 08:09:15 +0100 [thread overview]
Message-ID: <20210308070915.GA32695@lst.de> (raw)
In-Reply-To: <6f40b1f53c029788e20fe175618d8772e36d648c.camel@intel.com>
[-- Attachment #1: Type: text/plain, Size: 518 bytes --]
On Sat, Mar 06, 2021 at 08:33:04PM +0000, Williams, Dan J wrote:
> Yes, it looks like my unit test checks for exactly the behavior you
> changed. It was convenient to test that the device could be switched
> back to rw via BLKROSET, but I don't require that. The new behaviour of
> letting the disk->ro take precedence makes more sense to me, so I'll
> update the test for the new behaviour.
>
> I.e. I don't think regressing a unit test counts as a userspace
> regression.
Ok, thanks for the confirmation.
WARNING: multiple messages have this Message-ID (diff)
From: "hch@lst.de" <hch@lst.de>
To: "Williams, Dan J" <dan.j.williams@intel.com>
Cc: "hch@lst.de" <hch@lst.de>, lkp <lkp@intel.com>,
"hare@suse.de" <hare@suse.de>,
"olkuroch@cisco.com" <olkuroch@cisco.com>,
"linux-nvdimm@lists.01.org" <linux-nvdimm@lists.01.org>,
"lkp@lists.01.org" <lkp@lists.01.org>,
"ming.lei@redhat.com" <ming.lei@redhat.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"axboe@kernel.dk" <axboe@kernel.dk>,
"Sang, Oliver" <oliver.sang@intel.com>,
"martin.petersen@oracle.com" <martin.petersen@oracle.com>
Subject: Re: [block] 52f019d43c: ndctl.test-libndctl.fail
Date: Mon, 8 Mar 2021 08:09:15 +0100 [thread overview]
Message-ID: <20210308070915.GA32695@lst.de> (raw)
In-Reply-To: <6f40b1f53c029788e20fe175618d8772e36d648c.camel@intel.com>
On Sat, Mar 06, 2021 at 08:33:04PM +0000, Williams, Dan J wrote:
> Yes, it looks like my unit test checks for exactly the behavior you
> changed. It was convenient to test that the device could be switched
> back to rw via BLKROSET, but I don't require that. The new behaviour of
> letting the disk->ro take precedence makes more sense to me, so I'll
> update the test for the new behaviour.
>
> I.e. I don't think regressing a unit test counts as a userspace
> regression.
Ok, thanks for the confirmation.
next prev parent reply other threads:[~2021-03-08 7:09 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-05 5:59 [block] 52f019d43c: ndctl.test-libndctl.fail kernel test robot
2021-03-05 5:59 ` kernel test robot
2021-03-05 7:42 ` Christoph Hellwig
2021-03-05 7:42 ` Christoph Hellwig
2021-03-05 7:42 ` Christoph Hellwig
2021-03-05 14:38 ` Jeff Moyer
2021-03-05 14:38 ` Jeff Moyer
2021-03-05 14:38 ` Jeff Moyer
2021-03-06 20:33 ` Williams, Dan J
2021-03-06 20:33 ` Williams, Dan J
2021-03-06 20:33 ` Williams, Dan J
2021-03-08 7:09 ` hch [this message]
2021-03-08 7:09 ` hch
2021-03-08 7:09 ` hch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210308070915.GA32695@lst.de \
--to=hch@lst.de \
--cc=axboe@kernel.dk \
--cc=dan.j.williams@intel.com \
--cc=hare@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvdimm@lists.01.org \
--cc=lkp@intel.com \
--cc=lkp@lists.01.org \
--cc=ming.lei@redhat.com \
--cc=oliver.sang@intel.com \
--cc=olkuroch@cisco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.