From: Rob Herring <robh@kernel.org>
To: Benjamin Gaignard <benjamin.gaignard@collabora.com>
Cc: p.zabel@pengutronix.de, peng.fan@nxp.com,
linux-arm-kernel@lists.infradead.org, linux-imx@nxp.com,
linux-rockchip@lists.infradead.org, shawnguo@kernel.org,
mchehab@kernel.org, linux-kernel@vger.kernel.org,
robh+dt@kernel.org, dan.carpenter@oracle.com,
kernel@collabora.com, gregkh@linuxfoundation.org,
kernel@pengutronix.de, devicetree@vger.kernel.org, wens@csie.org,
festevam@gmail.com, s.hauer@pengutronix.de,
ezequiel@collabora.com, hverkuil-cisco@xs4all.nl,
mripard@kernel.org, paul.kocialkowski@bootlin.com,
linux-media@vger.kernel.org, jernej.skrabec@siol.net
Subject: Re: [PATCH v4 10/11] dt-bindings: media: nxp,imx8mq-vpu: Update bindings
Date: Mon, 8 Mar 2021 13:08:47 -0700 [thread overview]
Message-ID: <20210308200847.GA2879333@robh.at.kernel.org> (raw)
In-Reply-To: <20210303113952.178519-11-benjamin.gaignard@collabora.com>
On Wed, 03 Mar 2021 12:39:51 +0100, Benjamin Gaignard wrote:
> The current bindings seem to make the assumption that the
> two VPUs hardware blocks (G1 and G2) are only one set of
> registers.
> After implementing the VPU reset driver and G2 decoder driver
> it shows that all the VPUs are independent and don't need to
> know about the registers of the other blocks.
> Remove from the bindings the need to set all blocks register
> but keep reg-names property because removing it from the driver
> may affect other variants.
>
> Signed-off-by: Benjamin Gaignard <benjamin.gaignard@collabora.com>
> ---
> version 4:
> - rebase the change on top of VPU reset patches:
> https://www.spinics.net/lists/arm-kernel/msg878440.html
>
> version 2:
> - be more verbose about why I change the bindings
> Keep in mind that series comes after: https://www.spinics.net/lists/arm-kernel/msg875766.html
> without that review and ack it won't work
>
> .../bindings/media/nxp,imx8mq-vpu.yaml | 46 ++++++++++++-------
> 1 file changed, 30 insertions(+), 16 deletions(-)
>
Reviewed-by: Rob Herring <robh@kernel.org>
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robh@kernel.org>
To: Benjamin Gaignard <benjamin.gaignard@collabora.com>
Cc: p.zabel@pengutronix.de, peng.fan@nxp.com,
linux-arm-kernel@lists.infradead.org, linux-imx@nxp.com,
linux-rockchip@lists.infradead.org, shawnguo@kernel.org,
mchehab@kernel.org, linux-kernel@vger.kernel.org,
robh+dt@kernel.org, dan.carpenter@oracle.com,
kernel@collabora.com, gregkh@linuxfoundation.org,
kernel@pengutronix.de, devicetree@vger.kernel.org, wens@csie.org,
festevam@gmail.com, s.hauer@pengutronix.de,
ezequiel@collabora.com, hverkuil-cisco@xs4all.nl,
mripard@kernel.org, paul.kocialkowski@bootlin.com,
linux-media@vger.kernel.org, jernej.skrabec@siol.net
Subject: Re: [PATCH v4 10/11] dt-bindings: media: nxp,imx8mq-vpu: Update bindings
Date: Mon, 8 Mar 2021 13:08:47 -0700 [thread overview]
Message-ID: <20210308200847.GA2879333@robh.at.kernel.org> (raw)
In-Reply-To: <20210303113952.178519-11-benjamin.gaignard@collabora.com>
On Wed, 03 Mar 2021 12:39:51 +0100, Benjamin Gaignard wrote:
> The current bindings seem to make the assumption that the
> two VPUs hardware blocks (G1 and G2) are only one set of
> registers.
> After implementing the VPU reset driver and G2 decoder driver
> it shows that all the VPUs are independent and don't need to
> know about the registers of the other blocks.
> Remove from the bindings the need to set all blocks register
> but keep reg-names property because removing it from the driver
> may affect other variants.
>
> Signed-off-by: Benjamin Gaignard <benjamin.gaignard@collabora.com>
> ---
> version 4:
> - rebase the change on top of VPU reset patches:
> https://www.spinics.net/lists/arm-kernel/msg878440.html
>
> version 2:
> - be more verbose about why I change the bindings
> Keep in mind that series comes after: https://www.spinics.net/lists/arm-kernel/msg875766.html
> without that review and ack it won't work
>
> .../bindings/media/nxp,imx8mq-vpu.yaml | 46 ++++++++++++-------
> 1 file changed, 30 insertions(+), 16 deletions(-)
>
Reviewed-by: Rob Herring <robh@kernel.org>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robh@kernel.org>
To: Benjamin Gaignard <benjamin.gaignard@collabora.com>
Cc: p.zabel@pengutronix.de, peng.fan@nxp.com,
linux-arm-kernel@lists.infradead.org, linux-imx@nxp.com,
linux-rockchip@lists.infradead.org, shawnguo@kernel.org,
mchehab@kernel.org, linux-kernel@vger.kernel.org,
robh+dt@kernel.org, dan.carpenter@oracle.com,
kernel@collabora.com, gregkh@linuxfoundation.org,
kernel@pengutronix.de, devicetree@vger.kernel.org, wens@csie.org,
festevam@gmail.com, s.hauer@pengutronix.de,
ezequiel@collabora.com, hverkuil-cisco@xs4all.nl,
mripard@kernel.org, paul.kocialkowski@bootlin.com,
linux-media@vger.kernel.org, jernej.skrabec@siol.net
Subject: Re: [PATCH v4 10/11] dt-bindings: media: nxp,imx8mq-vpu: Update bindings
Date: Mon, 8 Mar 2021 13:08:47 -0700 [thread overview]
Message-ID: <20210308200847.GA2879333@robh.at.kernel.org> (raw)
In-Reply-To: <20210303113952.178519-11-benjamin.gaignard@collabora.com>
On Wed, 03 Mar 2021 12:39:51 +0100, Benjamin Gaignard wrote:
> The current bindings seem to make the assumption that the
> two VPUs hardware blocks (G1 and G2) are only one set of
> registers.
> After implementing the VPU reset driver and G2 decoder driver
> it shows that all the VPUs are independent and don't need to
> know about the registers of the other blocks.
> Remove from the bindings the need to set all blocks register
> but keep reg-names property because removing it from the driver
> may affect other variants.
>
> Signed-off-by: Benjamin Gaignard <benjamin.gaignard@collabora.com>
> ---
> version 4:
> - rebase the change on top of VPU reset patches:
> https://www.spinics.net/lists/arm-kernel/msg878440.html
>
> version 2:
> - be more verbose about why I change the bindings
> Keep in mind that series comes after: https://www.spinics.net/lists/arm-kernel/msg875766.html
> without that review and ack it won't work
>
> .../bindings/media/nxp,imx8mq-vpu.yaml | 46 ++++++++++++-------
> 1 file changed, 30 insertions(+), 16 deletions(-)
>
Reviewed-by: Rob Herring <robh@kernel.org>
next prev parent reply other threads:[~2021-03-08 20:09 UTC|newest]
Thread overview: 66+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-03 11:39 [PATCH v4 00/11] Add HANTRO G2/HEVC decoder support for IMX8MQ Benjamin Gaignard
2021-03-03 11:39 ` Benjamin Gaignard
2021-03-03 11:39 ` Benjamin Gaignard
2021-03-03 11:39 ` [PATCH v4 01/11] media: hevc: Add fields and flags for hevc PPS Benjamin Gaignard
2021-03-03 11:39 ` Benjamin Gaignard
2021-03-03 11:39 ` Benjamin Gaignard
2021-03-03 11:39 ` [PATCH v4 02/11] media: hevc: Add decode params control Benjamin Gaignard
2021-03-03 11:39 ` Benjamin Gaignard
2021-03-03 11:39 ` Benjamin Gaignard
2021-03-03 11:39 ` [PATCH v4 03/11] media: hantro: change hantro_codec_ops run prototype to return errors Benjamin Gaignard
2021-03-03 11:39 ` Benjamin Gaignard
2021-03-03 11:39 ` Benjamin Gaignard
2021-03-03 21:56 ` Ezequiel Garcia
2021-03-03 21:56 ` Ezequiel Garcia
2021-03-03 21:56 ` Ezequiel Garcia
2021-03-05 9:24 ` Benjamin Gaignard
2021-03-05 9:24 ` Benjamin Gaignard
2021-03-05 9:24 ` Benjamin Gaignard
2021-03-03 11:39 ` [PATCH v4 04/11] media: hantro: Define HEVC codec profiles and supported features Benjamin Gaignard
2021-03-03 11:39 ` Benjamin Gaignard
2021-03-03 11:39 ` Benjamin Gaignard
2021-03-03 11:39 ` [PATCH v4 05/11] media: hantro: Add a field to distinguish the hardware versions Benjamin Gaignard
2021-03-03 11:39 ` Benjamin Gaignard
2021-03-03 11:39 ` Benjamin Gaignard
2021-03-03 22:05 ` Ezequiel Garcia
2021-03-03 22:05 ` Ezequiel Garcia
2021-03-03 22:05 ` Ezequiel Garcia
2021-03-05 9:27 ` Benjamin Gaignard
2021-03-05 9:27 ` Benjamin Gaignard
2021-03-05 9:27 ` Benjamin Gaignard
2021-03-03 11:39 ` [PATCH v4 06/11] media: uapi: Add a control for HANTRO driver Benjamin Gaignard
2021-03-03 11:39 ` Benjamin Gaignard
2021-03-03 11:39 ` Benjamin Gaignard
2021-03-03 11:39 ` [PATCH v4 07/11] media: hantro: Introduce G2/HEVC decoder Benjamin Gaignard
2021-03-03 11:39 ` Benjamin Gaignard
2021-03-03 11:39 ` Benjamin Gaignard
2021-03-16 18:46 ` Ezequiel Garcia
2021-03-16 18:46 ` Ezequiel Garcia
2021-03-16 18:46 ` Ezequiel Garcia
2021-03-16 20:19 ` Benjamin Gaignard
2021-03-16 20:19 ` Benjamin Gaignard
2021-03-16 20:19 ` Benjamin Gaignard
2021-03-16 20:35 ` Ezequiel Garcia
2021-03-16 20:35 ` Ezequiel Garcia
2021-03-16 20:35 ` Ezequiel Garcia
2021-03-03 11:39 ` [PATCH v4 08/11] media: hantro: handle V4L2_PIX_FMT_HEVC_SLICE control Benjamin Gaignard
2021-03-03 11:39 ` Benjamin Gaignard
2021-03-03 11:39 ` Benjamin Gaignard
2021-03-03 11:39 ` [PATCH v4 09/11] media: hantro: IMX8M: add variant for G2/HEVC codec Benjamin Gaignard
2021-03-03 11:39 ` Benjamin Gaignard
2021-03-03 11:39 ` Benjamin Gaignard
2021-03-03 22:08 ` Ezequiel Garcia
2021-03-03 22:08 ` Ezequiel Garcia
2021-03-03 22:08 ` Ezequiel Garcia
2021-03-05 9:32 ` Benjamin Gaignard
2021-03-05 9:32 ` Benjamin Gaignard
2021-03-05 9:32 ` Benjamin Gaignard
2021-03-03 11:39 ` [PATCH v4 10/11] dt-bindings: media: nxp,imx8mq-vpu: Update bindings Benjamin Gaignard
2021-03-03 11:39 ` Benjamin Gaignard
2021-03-03 11:39 ` Benjamin Gaignard
2021-03-08 20:08 ` Rob Herring [this message]
2021-03-08 20:08 ` Rob Herring
2021-03-08 20:08 ` Rob Herring
2021-03-03 11:39 ` [PATCH v4 11/11] arm64: dts: imx8mq: Add node to G2 hardware Benjamin Gaignard
2021-03-03 11:39 ` Benjamin Gaignard
2021-03-03 11:39 ` Benjamin Gaignard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210308200847.GA2879333@robh.at.kernel.org \
--to=robh@kernel.org \
--cc=benjamin.gaignard@collabora.com \
--cc=dan.carpenter@oracle.com \
--cc=devicetree@vger.kernel.org \
--cc=ezequiel@collabora.com \
--cc=festevam@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=hverkuil-cisco@xs4all.nl \
--cc=jernej.skrabec@siol.net \
--cc=kernel@collabora.com \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=mchehab@kernel.org \
--cc=mripard@kernel.org \
--cc=p.zabel@pengutronix.de \
--cc=paul.kocialkowski@bootlin.com \
--cc=peng.fan@nxp.com \
--cc=robh+dt@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.