* [PATCH RESEND][next] hwmon: (corsair-cpro) Fix fall-through warnings for Clang
@ 2021-03-05 9:53 Gustavo A. R. Silva
2021-03-06 10:39 ` Marius Zachmann
0 siblings, 1 reply; 4+ messages in thread
From: Gustavo A. R. Silva @ 2021-03-05 9:53 UTC (permalink / raw)
To: Marius Zachmann, Jean Delvare, Guenter Roeck
Cc: linux-hwmon, linux-kernel, Gustavo A. R. Silva, linux-hardening
In preparation to enable -Wimplicit-fallthrough for Clang, fix a warning
by explicitly adding a break statement instead of letting the code fall
through to the next case.
Link: https://github.com/KSPP/linux/issues/115
Acked-by: Guenter Roeck <linux@roeck-us.net>
Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>
---
drivers/hwmon/corsair-cpro.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/hwmon/corsair-cpro.c b/drivers/hwmon/corsair-cpro.c
index 591929ec217a..fa6aa4fc8b52 100644
--- a/drivers/hwmon/corsair-cpro.c
+++ b/drivers/hwmon/corsair-cpro.c
@@ -310,6 +310,7 @@ static int ccp_write(struct device *dev, enum hwmon_sensor_types type,
default:
break;
}
+ break;
default:
break;
}
--
2.27.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH RESEND][next] hwmon: (corsair-cpro) Fix fall-through warnings for Clang
2021-03-05 9:53 [PATCH RESEND][next] hwmon: (corsair-cpro) Fix fall-through warnings for Clang Gustavo A. R. Silva
@ 2021-03-06 10:39 ` Marius Zachmann
2021-03-08 21:15 ` Gustavo A. R. Silva
2021-05-18 0:44 ` Gustavo A. R. Silva
0 siblings, 2 replies; 4+ messages in thread
From: Marius Zachmann @ 2021-03-06 10:39 UTC (permalink / raw)
To: Gustavo A. R. Silva
Cc: Jean Delvare, Guenter Roeck, linux-hwmon, linux-kernel,
Gustavo A. R. Silva, linux-hardening
On 06.03.21 at 10:53:59 CET, Gustavo A. R. Silva wrote
> In preparation to enable -Wimplicit-fallthrough for Clang, fix a warning
> by explicitly adding a break statement instead of letting the code fall
> through to the next case.
>
> Link: https://github.com/KSPP/linux/issues/115
> Acked-by: Guenter Roeck <linux@roeck-us.net>
> Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>
Acked-by: Marius Zachmann <mail@mariuszachmann.de>
> ---
> drivers/hwmon/corsair-cpro.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/hwmon/corsair-cpro.c b/drivers/hwmon/corsair-cpro.c
> index 591929ec217a..fa6aa4fc8b52 100644
> --- a/drivers/hwmon/corsair-cpro.c
> +++ b/drivers/hwmon/corsair-cpro.c
> @@ -310,6 +310,7 @@ static int ccp_write(struct device *dev, enum hwmon_sensor_types type,
> default:
> break;
> }
> + break;
> default:
> break;
> }
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH RESEND][next] hwmon: (corsair-cpro) Fix fall-through warnings for Clang
2021-03-06 10:39 ` Marius Zachmann
@ 2021-03-08 21:15 ` Gustavo A. R. Silva
2021-05-18 0:44 ` Gustavo A. R. Silva
1 sibling, 0 replies; 4+ messages in thread
From: Gustavo A. R. Silva @ 2021-03-08 21:15 UTC (permalink / raw)
To: Marius Zachmann
Cc: Jean Delvare, Guenter Roeck, linux-hwmon, linux-kernel,
linux-hardening
On Sat, Mar 06, 2021 at 11:39:35AM +0100, Marius Zachmann wrote:
> On 06.03.21 at 10:53:59 CET, Gustavo A. R. Silva wrote
> > In preparation to enable -Wimplicit-fallthrough for Clang, fix a warning
> > by explicitly adding a break statement instead of letting the code fall
> > through to the next case.
> >
> > Link: https://github.com/KSPP/linux/issues/115
> > Acked-by: Guenter Roeck <linux@roeck-us.net>
> > Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>
>
> Acked-by: Marius Zachmann <mail@mariuszachmann.de>
Thanks, Marius.
--
Gustavo
>
> > ---
> > drivers/hwmon/corsair-cpro.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/hwmon/corsair-cpro.c b/drivers/hwmon/corsair-cpro.c
> > index 591929ec217a..fa6aa4fc8b52 100644
> > --- a/drivers/hwmon/corsair-cpro.c
> > +++ b/drivers/hwmon/corsair-cpro.c
> > @@ -310,6 +310,7 @@ static int ccp_write(struct device *dev, enum hwmon_sensor_types type,
> > default:
> > break;
> > }
> > + break;
> > default:
> > break;
> > }
> >
>
>
>
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH RESEND][next] hwmon: (corsair-cpro) Fix fall-through warnings for Clang
2021-03-06 10:39 ` Marius Zachmann
2021-03-08 21:15 ` Gustavo A. R. Silva
@ 2021-05-18 0:44 ` Gustavo A. R. Silva
1 sibling, 0 replies; 4+ messages in thread
From: Gustavo A. R. Silva @ 2021-05-18 0:44 UTC (permalink / raw)
To: Marius Zachmann, Gustavo A. R. Silva
Cc: Jean Delvare, Guenter Roeck, linux-hwmon, linux-kernel,
linux-hardening
Hi all,
If you don't mind, I'm taking this in my -next[1] branch for v5.14.
Thanks
--
Gustavo
[1] https://git.kernel.org/pub/scm/linux/kernel/git/gustavoars/linux.git/log/?h=for-next/kspp
On 3/6/21 04:39, Marius Zachmann wrote:
> On 06.03.21 at 10:53:59 CET, Gustavo A. R. Silva wrote
>> In preparation to enable -Wimplicit-fallthrough for Clang, fix a warning
>> by explicitly adding a break statement instead of letting the code fall
>> through to the next case.
>>
>> Link: https://github.com/KSPP/linux/issues/115
>> Acked-by: Guenter Roeck <linux@roeck-us.net>
>> Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>
>
> Acked-by: Marius Zachmann <mail@mariuszachmann.de>
>
>> ---
>> drivers/hwmon/corsair-cpro.c | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/hwmon/corsair-cpro.c b/drivers/hwmon/corsair-cpro.c
>> index 591929ec217a..fa6aa4fc8b52 100644
>> --- a/drivers/hwmon/corsair-cpro.c
>> +++ b/drivers/hwmon/corsair-cpro.c
>> @@ -310,6 +310,7 @@ static int ccp_write(struct device *dev, enum hwmon_sensor_types type,
>> default:
>> break;
>> }
>> + break;
>> default:
>> break;
>> }
>>
>
>
>
>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-05-18 0:44 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-03-05 9:53 [PATCH RESEND][next] hwmon: (corsair-cpro) Fix fall-through warnings for Clang Gustavo A. R. Silva
2021-03-06 10:39 ` Marius Zachmann
2021-03-08 21:15 ` Gustavo A. R. Silva
2021-05-18 0:44 ` Gustavo A. R. Silva
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.