From: kernel test robot <lkp@intel.com>
To: Al Cooper <alcooperx@gmail.com>, linux-kernel@vger.kernel.org
Cc: kbuild-all@01.org, Al Cooper <alcooperx@gmail.com>,
bcm-kernel-feedback-list@broadcom.com,
devicetree@vger.kernel.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jiri Slaby <jirislaby@kernel.org>,
linux-serial@vger.kernel.org,
Masahiro Yamada <masahiroy@kernel.org>,
Rob Herring <robh+dt@kernel.org>
Subject: Re: [PATCH v4 2/2] serial: 8250: Add new 8250-core based Broadcom STB driver
Date: Tue, 9 Mar 2021 02:48:06 +0800 [thread overview]
Message-ID: <202103090235.LISLehVi-lkp@intel.com> (raw)
In-Reply-To: <20210308170522.4272-3-alcooperx@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 3056 bytes --]
Hi Al,
I love your patch! Perhaps something to improve:
[auto build test WARNING on tty/tty-testing]
[also build test WARNING on linux/master robh/for-next usb/usb-testing linus/master v5.12-rc2 next-20210305]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Al-Cooper/8250-Add-driver-for-Broadcom-UART/20210309-010755
base: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/tty.git tty-testing
config: nios2-allyesconfig (attached as .config)
compiler: nios2-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/0day-ci/linux/commit/38e38c0d5bd1fd6e256cbb0da5cd0cd1010b9cb6
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Al-Cooper/8250-Add-driver-for-Broadcom-UART/20210309-010755
git checkout 38e38c0d5bd1fd6e256cbb0da5cd0cd1010b9cb6
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=nios2
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All warnings (new ones prefixed by >>):
drivers/tty/serial/8250/8250_bcm7271.c: In function 'brcmuart_tx_isr':
>> drivers/tty/serial/8250/8250_bcm7271.c:547:6: warning: variable 'length' set but not used [-Wunused-but-set-variable]
547 | int length;
| ^~~~~~
drivers/tty/serial/8250/8250_bcm7271.c: At top level:
>> drivers/tty/serial/8250/8250_bcm7271.c:1190:12: warning: no previous prototype for 'brcmuart_init' [-Wmissing-prototypes]
1190 | int __init brcmuart_init(void)
| ^~~~~~~~~~~~~
>> drivers/tty/serial/8250/8250_bcm7271.c:1198:13: warning: no previous prototype for 'brcmuart_deinit' [-Wmissing-prototypes]
1198 | void __exit brcmuart_deinit(void)
| ^~~~~~~~~~~~~~~
vim +/length +547 drivers/tty/serial/8250/8250_bcm7271.c
540
541 static void brcmuart_tx_isr(struct uart_port *up, u32 isr)
542 {
543 struct brcmuart_priv *priv = up->private_data;
544 struct device *dev = up->dev;
545 struct uart_8250_port *port_8250 = up_to_u8250p(up);
546 struct circ_buf *xmit = &port_8250->port.state->xmit;
> 547 int length;
548
549 length = udma_readl(priv, REGS_DMA_TX, UDMA_TX_TRANSFER_TOTAL);
550 if (isr & UDMA_INTR_TX_ABORT) {
551 if (priv->tx_running)
552 dev_err(dev, "Unexpected TX_ABORT interrupt\n");
553 return;
554 }
555 priv->tx_running = false;
556 if (!uart_circ_empty(xmit) && !uart_tx_stopped(up))
557 brcmuart_tx_dma(port_8250);
558 }
559
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 58921 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: kernel test robot <lkp@intel.com>
To: kbuild-all@lists.01.org
Subject: Re: [PATCH v4 2/2] serial: 8250: Add new 8250-core based Broadcom STB driver
Date: Tue, 09 Mar 2021 02:48:06 +0800 [thread overview]
Message-ID: <202103090235.LISLehVi-lkp@intel.com> (raw)
In-Reply-To: <20210308170522.4272-3-alcooperx@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 3126 bytes --]
Hi Al,
I love your patch! Perhaps something to improve:
[auto build test WARNING on tty/tty-testing]
[also build test WARNING on linux/master robh/for-next usb/usb-testing linus/master v5.12-rc2 next-20210305]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Al-Cooper/8250-Add-driver-for-Broadcom-UART/20210309-010755
base: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/tty.git tty-testing
config: nios2-allyesconfig (attached as .config)
compiler: nios2-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/0day-ci/linux/commit/38e38c0d5bd1fd6e256cbb0da5cd0cd1010b9cb6
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Al-Cooper/8250-Add-driver-for-Broadcom-UART/20210309-010755
git checkout 38e38c0d5bd1fd6e256cbb0da5cd0cd1010b9cb6
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=nios2
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All warnings (new ones prefixed by >>):
drivers/tty/serial/8250/8250_bcm7271.c: In function 'brcmuart_tx_isr':
>> drivers/tty/serial/8250/8250_bcm7271.c:547:6: warning: variable 'length' set but not used [-Wunused-but-set-variable]
547 | int length;
| ^~~~~~
drivers/tty/serial/8250/8250_bcm7271.c: At top level:
>> drivers/tty/serial/8250/8250_bcm7271.c:1190:12: warning: no previous prototype for 'brcmuart_init' [-Wmissing-prototypes]
1190 | int __init brcmuart_init(void)
| ^~~~~~~~~~~~~
>> drivers/tty/serial/8250/8250_bcm7271.c:1198:13: warning: no previous prototype for 'brcmuart_deinit' [-Wmissing-prototypes]
1198 | void __exit brcmuart_deinit(void)
| ^~~~~~~~~~~~~~~
vim +/length +547 drivers/tty/serial/8250/8250_bcm7271.c
540
541 static void brcmuart_tx_isr(struct uart_port *up, u32 isr)
542 {
543 struct brcmuart_priv *priv = up->private_data;
544 struct device *dev = up->dev;
545 struct uart_8250_port *port_8250 = up_to_u8250p(up);
546 struct circ_buf *xmit = &port_8250->port.state->xmit;
> 547 int length;
548
549 length = udma_readl(priv, REGS_DMA_TX, UDMA_TX_TRANSFER_TOTAL);
550 if (isr & UDMA_INTR_TX_ABORT) {
551 if (priv->tx_running)
552 dev_err(dev, "Unexpected TX_ABORT interrupt\n");
553 return;
554 }
555 priv->tx_running = false;
556 if (!uart_circ_empty(xmit) && !uart_tx_stopped(up))
557 brcmuart_tx_dma(port_8250);
558 }
559
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 58921 bytes --]
next prev parent reply other threads:[~2021-03-08 18:49 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-08 17:05 [PATCH v4 0/2] 8250: Add driver for Broadcom UART Al Cooper
2021-03-08 17:05 ` [PATCH v4 1/2] dt-bindings: Add support for the Broadcom UART driver Al Cooper
2021-03-10 2:50 ` Rob Herring
2021-03-08 17:05 ` [PATCH v4 2/2] serial: 8250: Add new 8250-core based Broadcom STB driver Al Cooper
2021-03-08 17:23 ` Greg Kroah-Hartman
2021-03-08 18:48 ` kernel test robot [this message]
2021-03-08 18:48 ` kernel test robot
-- strict thread matches above, loose matches on Subject: below --
2021-02-19 20:37 [PATCH v4 0/2] serial: 8250: Add driver for Broadcom UART Al Cooper
2021-02-19 20:37 ` [PATCH v4 2/2] serial: 8250: Add new 8250-core based Broadcom STB driver Al Cooper
2021-03-03 19:29 ` Greg Kroah-Hartman
2021-03-04 21:27 ` Al Cooper
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202103090235.LISLehVi-lkp@intel.com \
--to=lkp@intel.com \
--cc=alcooperx@gmail.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=jirislaby@kernel.org \
--cc=kbuild-all@01.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=masahiroy@kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.