From: Florian Westphal <fw@strlen.de>
To: Jia-Ju Bai <baijiaju1990@gmail.com>
Cc: netdev@vger.kernel.org, bridge@lists.linux-foundation.org,
fw@strlen.de, linux-kernel@vger.kernel.org, kadlec@netfilter.org,
coreteam@netfilter.org, netfilter-devel@vger.kernel.org,
nikolay@nvidia.com, roopa@nvidia.com, kuba@kernel.org,
davem@davemloft.net, pablo@netfilter.org
Subject: Re: [Bridge] [PATCH] net: bridge: fix error return code of do_update_counters()
Date: Tue, 9 Mar 2021 12:01:21 +0100 [thread overview]
Message-ID: <20210309110121.GD10808@breakpoint.cc> (raw)
In-Reply-To: <20210309022854.17904-1-baijiaju1990@gmail.com>
Jia-Ju Bai <baijiaju1990@gmail.com> wrote:
> When find_table_lock() returns NULL to t, no error return code of
> do_update_counters() is assigned.
Its -ENOENT.
> t = find_table_lock(net, name, &ret, &ebt_mutex);
^^^^^
ret is passed to find_table_lock, which passes it to
find_inlist_lock_noload() which will set *ret = -ENOENT
for NULL case.
WARNING: multiple messages have this Message-ID (diff)
From: Florian Westphal <fw@strlen.de>
To: Jia-Ju Bai <baijiaju1990@gmail.com>
Cc: pablo@netfilter.org, kadlec@netfilter.org, fw@strlen.de,
roopa@nvidia.com, nikolay@nvidia.com, davem@davemloft.net,
kuba@kernel.org, netfilter-devel@vger.kernel.org,
coreteam@netfilter.org, bridge@lists.linux-foundation.org,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] net: bridge: fix error return code of do_update_counters()
Date: Tue, 9 Mar 2021 12:01:21 +0100 [thread overview]
Message-ID: <20210309110121.GD10808@breakpoint.cc> (raw)
In-Reply-To: <20210309022854.17904-1-baijiaju1990@gmail.com>
Jia-Ju Bai <baijiaju1990@gmail.com> wrote:
> When find_table_lock() returns NULL to t, no error return code of
> do_update_counters() is assigned.
Its -ENOENT.
> t = find_table_lock(net, name, &ret, &ebt_mutex);
^^^^^
ret is passed to find_table_lock, which passes it to
find_inlist_lock_noload() which will set *ret = -ENOENT
for NULL case.
next prev parent reply other threads:[~2021-03-09 11:01 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-09 2:28 [Bridge] [PATCH] net: bridge: fix error return code of do_update_counters() Jia-Ju Bai
2021-03-09 2:28 ` Jia-Ju Bai
2021-03-09 11:01 ` Florian Westphal [this message]
2021-03-09 11:01 ` Florian Westphal
2021-03-09 13:31 ` [Bridge] " Jia-Ju Bai
2021-03-09 13:31 ` Jia-Ju Bai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210309110121.GD10808@breakpoint.cc \
--to=fw@strlen.de \
--cc=baijiaju1990@gmail.com \
--cc=bridge@lists.linux-foundation.org \
--cc=coreteam@netfilter.org \
--cc=davem@davemloft.net \
--cc=kadlec@netfilter.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=nikolay@nvidia.com \
--cc=pablo@netfilter.org \
--cc=roopa@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.