All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sascha Hauer <s.hauer@pengutronix.de>
To: dillon.minfei@gmail.com
Cc: robh+dt@kernel.org, shawnguo@kernel.org, parthiban@linumiz.com,
	kernel@pengutronix.de, festevam@gmail.com, linux-imx@nxp.com,
	devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ARM: dts: imx6ull: fix ubi mount failed on MYS-6ULX-IOT board
Date: Tue, 9 Mar 2021 13:18:36 +0100	[thread overview]
Message-ID: <20210309121836.GU4207@pengutronix.de> (raw)
In-Reply-To: <1615270520-16951-1-git-send-email-dillon.minfei@gmail.com>

On Tue, Mar 09, 2021 at 02:15:19PM +0800, dillon.minfei@gmail.com wrote:
> From: dillon min <dillon.minfei@gmail.com>
> 
> This patch intend to fix ubi filesystem mount failed on MYS-6ULX-IOT board,
> from Micron MT29F2G08ABAEAWP's datasheets, we need to choose 4-bit ECC.
> 
> Table 18: Error Management Details
> 
> Description					Requirement
> 
> Minimum number of valid blocks (NVB) per LUN	2008
> Total available blocks per LUN			2048
> First spare area location			x8: byte 2048 x16: word 1024
> Bad-block mark					x8: 00h x16: 0000h
> Minimum required ECC				4-bit ECC per 528 bytes
> Minimum ECC with internal ECC enabled		4-bit ECC per 516 bytes (user data) + 8
> 						bytes (parity data)
> Minimum required ECC for block 0 if PROGRAM/
> ERASE cycles are less than 1000			1-bit ECC per 528 bytes

4-bit ECC is the minimum this chip requires. There's nothing wrong with
choosing a better ECC like the GPMI driver does by default.

It looks like you are papering over some other problem.

Sascha

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

WARNING: multiple messages have this Message-ID (diff)
From: Sascha Hauer <s.hauer@pengutronix.de>
To: dillon.minfei@gmail.com
Cc: robh+dt@kernel.org, shawnguo@kernel.org, parthiban@linumiz.com,
	kernel@pengutronix.de, festevam@gmail.com, linux-imx@nxp.com,
	devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ARM: dts: imx6ull: fix ubi mount failed on MYS-6ULX-IOT board
Date: Tue, 9 Mar 2021 13:18:36 +0100	[thread overview]
Message-ID: <20210309121836.GU4207@pengutronix.de> (raw)
In-Reply-To: <1615270520-16951-1-git-send-email-dillon.minfei@gmail.com>

On Tue, Mar 09, 2021 at 02:15:19PM +0800, dillon.minfei@gmail.com wrote:
> From: dillon min <dillon.minfei@gmail.com>
> 
> This patch intend to fix ubi filesystem mount failed on MYS-6ULX-IOT board,
> from Micron MT29F2G08ABAEAWP's datasheets, we need to choose 4-bit ECC.
> 
> Table 18: Error Management Details
> 
> Description					Requirement
> 
> Minimum number of valid blocks (NVB) per LUN	2008
> Total available blocks per LUN			2048
> First spare area location			x8: byte 2048 x16: word 1024
> Bad-block mark					x8: 00h x16: 0000h
> Minimum required ECC				4-bit ECC per 528 bytes
> Minimum ECC with internal ECC enabled		4-bit ECC per 516 bytes (user data) + 8
> 						bytes (parity data)
> Minimum required ECC for block 0 if PROGRAM/
> ERASE cycles are less than 1000			1-bit ECC per 528 bytes

4-bit ECC is the minimum this chip requires. There's nothing wrong with
choosing a better ECC like the GPMI driver does by default.

It looks like you are papering over some other problem.

Sascha

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

  parent reply	other threads:[~2021-03-09 12:20 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-09  6:15 [PATCH] ARM: dts: imx6ull: fix ubi mount failed on MYS-6ULX-IOT board dillon.minfei
2021-03-09  6:15 ` dillon.minfei
2021-03-09  6:15 ` [PATCH] ARM: dts: imx6ull: fix ubi filesystem mount failed dillon.minfei
2021-03-09  6:15   ` dillon.minfei
2021-03-09 12:01   ` Fabio Estevam
2021-03-09 12:01     ` Fabio Estevam
2021-03-17 13:00   ` Shawn Guo
2021-03-17 13:00     ` Shawn Guo
2021-03-09 12:18 ` Sascha Hauer [this message]
2021-03-09 12:18   ` [PATCH] ARM: dts: imx6ull: fix ubi mount failed on MYS-6ULX-IOT board Sascha Hauer
2021-03-10  2:54   ` dillon min
2021-03-10  2:54     ` dillon min
2021-03-17 14:10     ` Sascha Hauer
2021-03-17 14:10       ` Sascha Hauer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210309121836.GU4207@pengutronix.de \
    --to=s.hauer@pengutronix.de \
    --cc=devicetree@vger.kernel.org \
    --cc=dillon.minfei@gmail.com \
    --cc=festevam@gmail.com \
    --cc=kernel@pengutronix.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-imx@nxp.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=parthiban@linumiz.com \
    --cc=robh+dt@kernel.org \
    --cc=shawnguo@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.