[intel-linux-intel-lts:5.4/yocto 11/11] drivers/uio/uio_pci_generic.c:247:2-7: WARNING: NULL check before some freeing functions is not needed.

[intel-linux-intel-lts:5.4/yocto 11/11] drivers/uio/uio_pci_generic.c:247:2-7: WARNING: NULL check before some freeing functions is not needed.

[kernel test robot]

[-- Attachment #1: Type: text/plain, Size: 1147 bytes --]

CC: kbuild-all(a)lists.01.org
TO: Yuan Liu <yuan1.liu@intel.com>
CC: "Qin, Chao" <chao.qin@intel.com>
CC: Yonghua Huang <yonghua.huahng@intel.com>

tree:   https://github.com/intel/linux-intel-lts.git 5.4/yocto
head:   709a04896cb6ab56a8ce54575f2cc4d346d71dea
commit: 709a04896cb6ab56a8ce54575f2cc4d346d71dea [11/11] kernel[v2]: extend uio driver to supports msix
:::::: branch date: 6 days ago
:::::: commit date: 6 days ago
config: riscv-randconfig-c003-20201202 (attached as .config)
compiler: riscv64-linux-gcc (GCC) 9.3.0

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Julia Lawall <julia.lawall@lip6.fr>


"coccinelle warnings: (new ones prefixed by >>)"
>> drivers/uio/uio_pci_generic.c:247:2-7: WARNING: NULL check before some freeing functions is not needed.
   drivers/uio/uio_pci_generic.c:264:2-7: WARNING: NULL check before some freeing functions is not needed.

Please review and possibly fold the followup patch.

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 18959 bytes --]

[intel-linux-intel-lts:5.4/yocto 11/11] drivers/uio/uio_pci_generic.c:247:2-7: WARNING: NULL check before some freeing functions is not needed.

[kernel test robot]

[-- Attachment #1: Type: text/plain, Size: 1145 bytes --]

CC: kbuild-all(a)01.org
TO: Yuan Liu <yuan1.liu@intel.com>
CC: "Qin, Chao" <chao.qin@intel.com>
CC: Yonghua Huang <yonghua.huahng@intel.com>

tree:   https://github.com/intel/linux-intel-lts.git 5.4/yocto
head:   709a04896cb6ab56a8ce54575f2cc4d346d71dea
commit: 709a04896cb6ab56a8ce54575f2cc4d346d71dea [11/11] kernel[v2]: extend uio driver to supports msix
:::::: branch date: 3 months ago
:::::: commit date: 3 months ago
config: xtensa-randconfig-c004-20210309 (attached as .config)
compiler: xtensa-linux-gcc (GCC) 9.3.0

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Julia Lawall <julia.lawall@lip6.fr>


"coccinelle warnings: (new ones prefixed by >>)"
>> drivers/uio/uio_pci_generic.c:247:2-7: WARNING: NULL check before some freeing functions is not needed.
   drivers/uio/uio_pci_generic.c:264:2-7: WARNING: NULL check before some freeing functions is not needed.

Please review and possibly fold the followup patch.

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 38105 bytes --]

[PATCH] kernel[v2]: fix ifnullfree.cocci warnings

[kernel test robot]

[-- Attachment #1: Type: text/plain, Size: 1923 bytes --]

CC: kbuild-all(a)01.org
TO: Yuan Liu <yuan1.liu@intel.com>
CC: "Qin, Chao" <chao.qin@intel.com>
CC: Yonghua Huang <yonghua.huahng@intel.com>

From: kernel test robot <lkp@intel.com>

drivers/uio/uio_pci_generic.c:247:2-7: WARNING: NULL check before some freeing functions is not needed.
drivers/uio/uio_pci_generic.c:264:2-7: WARNING: NULL check before some freeing functions is not needed.

 NULL check before some freeing functions is not needed.

 Based on checkpatch warning
 "kfree(NULL) is safe this check is probably not required"
 and kfreeaddr.cocci by Julia Lawall.

Generated by: scripts/coccinelle/free/ifnullfree.cocci

Fixes: 709a04896cb6 ("kernel[v2]: extend uio driver to supports msix")
CC: Yuan Liu <yuan1.liu@intel.com>
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: kernel test robot <lkp@intel.com>
---

tree:   https://github.com/intel/linux-intel-lts.git 5.4/yocto
head:   709a04896cb6ab56a8ce54575f2cc4d346d71dea
commit: 709a04896cb6ab56a8ce54575f2cc4d346d71dea [11/11] kernel[v2]: extend uio driver to supports msix
:::::: branch date: 3 months ago
:::::: commit date: 3 months ago

Please take the patch only if it's a positive warning. Thanks!

 uio_pci_generic.c |    6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

--- a/drivers/uio/uio_pci_generic.c
+++ b/drivers/uio/uio_pci_generic.c
@@ -243,8 +243,7 @@ static int probe(struct pci_dev *pdev,
 
 err_register:
 #ifdef CONFIG_PCI_MSI
-	if (gdev->msix_info.entries != NULL)
-		kfree(gdev->msix_info.entries);
+	kfree(gdev->msix_info.entries);
 #endif
 	kfree(gdev);
 err_alloc:
@@ -260,8 +259,7 @@ static void remove(struct pci_dev *pdev)
 	uio_unregister_device(&gdev->info);
 	pci_disable_device(pdev);
 #ifdef CONFIG_PCI_MSI
-	if (gdev->msix_info.entries != NULL)
-		kfree(gdev->msix_info.entries);
+	kfree(gdev->msix_info.entries);
 #endif
 	kfree(gdev);
 }

[intel-linux-intel-lts:5.4/yocto 11/11] drivers/uio/uio_pci_generic.c:247:2-7: WARNING: NULL check before some freeing functions is not needed.

[kernel test robot]

[-- Attachment #1: Type: text/plain, Size: 861 bytes --]

tree:   https://github.com/intel/linux-intel-lts.git 5.4/yocto
head:   709a04896cb6ab56a8ce54575f2cc4d346d71dea
commit: 709a04896cb6ab56a8ce54575f2cc4d346d71dea [11/11] kernel[v2]: extend uio driver to supports msix
config: riscv-allmodconfig (attached as .config)
compiler: riscv64-linux-gcc (GCC) 9.3.0

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>


cocci warnings: (new ones prefixed by >>)
>> drivers/uio/uio_pci_generic.c:247:2-7: WARNING: NULL check before some freeing functions is not needed.
   drivers/uio/uio_pci_generic.c:264:2-7: WARNING: NULL check before some freeing functions is not needed.

Please review and possibly fold the followup patch.

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 61253 bytes --]