* [PATCH] ti33x: allow different virtual/bootloader
@ 2021-03-09 17:23 Vivien Didelot
2021-03-09 20:34 ` Denys Dmytriyenko
0 siblings, 1 reply; 5+ messages in thread
From: Vivien Didelot @ 2021-03-09 17:23 UTC (permalink / raw)
To: meta-ti; +Cc: Denys Dmytriyenko
Boards like the beaglebone currently hardcode "u-boot" as a dependency
for the image and the wic format, and this prevents one from choosing
a different bootloader via:
PREFERRED_PROVIDER_virtual/bootloader = "non-u-boot-bootloader"
Depending on "virtual/bootloader" instead of "u-boot" fixes this.
Signed-off-by: Vivien Didelot <vdidelot@pbsc.com>
---
conf/machine/include/ti33x.inc | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/conf/machine/include/ti33x.inc b/conf/machine/include/ti33x.inc
index abfd7ec7..b3c3b6d7 100644
--- a/conf/machine/include/ti33x.inc
+++ b/conf/machine/include/ti33x.inc
@@ -51,7 +51,7 @@ UBOOT_SUFFIX = "img"
# and u-boot.
UBI_VOLNAME = "rootfs"
-EXTRA_IMAGEDEPENDS += "u-boot"
+EXTRA_IMAGEDEPENDS += "virtual/bootloader"
# List common SoC features, may need to add touchscreen for specific machines
MACHINE_FEATURES = "kernel26 apm usbgadget usbhost vfat ext2 screen alsa ethernet gpu"
@@ -63,4 +63,4 @@ TI_PDK_LIMIT_BOARDS = "evmAM335x icev2AM335x iceAMIC110 bbbAM335x skAM335x"
IMAGE_FSTYPES += "tar.xz wic.xz"
WKS_FILE ?= "sdimage-2part.wks"
IMAGE_BOOT_FILES ?= "${SPL_BINARY} u-boot.${UBOOT_SUFFIX}"
-do_image_wic[depends] += "u-boot:do_deploy"
+do_image_wic[depends] += "virtual/bootloader:do_deploy"
--
2.30.1
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH] ti33x: allow different virtual/bootloader
2021-03-09 17:23 [PATCH] ti33x: allow different virtual/bootloader Vivien Didelot
@ 2021-03-09 20:34 ` Denys Dmytriyenko
2021-03-09 20:42 ` Vivien Didelot
0 siblings, 1 reply; 5+ messages in thread
From: Denys Dmytriyenko @ 2021-03-09 20:34 UTC (permalink / raw)
To: Vivien Didelot; +Cc: meta-ti
On Tue, Mar 09, 2021 at 12:23:31PM -0500, Vivien Didelot wrote:
> Boards like the beaglebone currently hardcode "u-boot" as a dependency
> for the image and the wic format, and this prevents one from choosing
> a different bootloader via:
>
> PREFERRED_PROVIDER_virtual/bootloader = "non-u-boot-bootloader"
>
> Depending on "virtual/bootloader" instead of "u-boot" fixes this.
>
> Signed-off-by: Vivien Didelot <vdidelot@pbsc.com>
Could have added Suggested-by: here. Oh, well...
Reviewed-by: Denys Dmytriyenko <denis@denix.org>
> ---
> conf/machine/include/ti33x.inc | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/conf/machine/include/ti33x.inc b/conf/machine/include/ti33x.inc
> index abfd7ec7..b3c3b6d7 100644
> --- a/conf/machine/include/ti33x.inc
> +++ b/conf/machine/include/ti33x.inc
> @@ -51,7 +51,7 @@ UBOOT_SUFFIX = "img"
> # and u-boot.
> UBI_VOLNAME = "rootfs"
>
> -EXTRA_IMAGEDEPENDS += "u-boot"
> +EXTRA_IMAGEDEPENDS += "virtual/bootloader"
>
> # List common SoC features, may need to add touchscreen for specific machines
> MACHINE_FEATURES = "kernel26 apm usbgadget usbhost vfat ext2 screen alsa ethernet gpu"
> @@ -63,4 +63,4 @@ TI_PDK_LIMIT_BOARDS = "evmAM335x icev2AM335x iceAMIC110 bbbAM335x skAM335x"
> IMAGE_FSTYPES += "tar.xz wic.xz"
> WKS_FILE ?= "sdimage-2part.wks"
> IMAGE_BOOT_FILES ?= "${SPL_BINARY} u-boot.${UBOOT_SUFFIX}"
> -do_image_wic[depends] += "u-boot:do_deploy"
> +do_image_wic[depends] += "virtual/bootloader:do_deploy"
> --
> 2.30.1
>
--
Regards,
Denys Dmytriyenko <denis@denix.org>
PGP: 0x420902729A92C964 - https://denix.org/0x420902729A92C964
Fingerprint: 25FC E4A5 8A72 2F69 1186 6D76 4209 0272 9A92 C964
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] ti33x: allow different virtual/bootloader
2021-03-09 20:34 ` Denys Dmytriyenko
@ 2021-03-09 20:42 ` Vivien Didelot
2021-03-09 22:20 ` Denys Dmytriyenko
0 siblings, 1 reply; 5+ messages in thread
From: Vivien Didelot @ 2021-03-09 20:42 UTC (permalink / raw)
To: Denys Dmytriyenko; +Cc: meta-ti
Hi Denys,
On Tue, 09 Mar 2021 15:34:13 -0500 Denys Dmytriyenko <denis@denix.org> wrote:
> On Tue, Mar 09, 2021 at 12:23:31PM -0500, Vivien Didelot wrote:
> > Boards like the beaglebone currently hardcode "u-boot" as a dependency
> > for the image and the wic format, and this prevents one from choosing
> > a different bootloader via:
> >
> > PREFERRED_PROVIDER_virtual/bootloader = "non-u-boot-bootloader"
> >
> > Depending on "virtual/bootloader" instead of "u-boot" fixes this.
> >
> > Signed-off-by: Vivien Didelot <vdidelot@pbsc.com>
>
> Could have added Suggested-by: here. Oh, well...
>
> Reviewed-by: Denys Dmytriyenko <denis@denix.org>
Oops I messed up, can you please add your address as Suggested-by:,
and set the author address to my Signed-off-by: address? Otherwise
I can resend if that is simpler.
Thank you,
Vivien
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] ti33x: allow different virtual/bootloader
2021-03-09 20:42 ` Vivien Didelot
@ 2021-03-09 22:20 ` Denys Dmytriyenko
2021-03-10 4:25 ` [meta-ti] " praneeth
0 siblings, 1 reply; 5+ messages in thread
From: Denys Dmytriyenko @ 2021-03-09 22:20 UTC (permalink / raw)
To: Vivien Didelot; +Cc: meta-ti
On Tue, Mar 09, 2021 at 03:42:34PM -0500, Vivien Didelot wrote:
> Hi Denys,
>
> On Tue, 09 Mar 2021 15:34:13 -0500 Denys Dmytriyenko <denis@denix.org> wrote:
> > On Tue, Mar 09, 2021 at 12:23:31PM -0500, Vivien Didelot wrote:
> > > Boards like the beaglebone currently hardcode "u-boot" as a dependency
> > > for the image and the wic format, and this prevents one from choosing
> > > a different bootloader via:
> > >
> > > PREFERRED_PROVIDER_virtual/bootloader = "non-u-boot-bootloader"
> > >
> > > Depending on "virtual/bootloader" instead of "u-boot" fixes this.
> > >
> > > Signed-off-by: Vivien Didelot <vdidelot@pbsc.com>
> >
> > Could have added Suggested-by: here. Oh, well...
> >
> > Reviewed-by: Denys Dmytriyenko <denis@denix.org>
>
> Oops I messed up, can you please add your address as Suggested-by:,
> and set the author address to my Signed-off-by: address? Otherwise
> I can resend if that is simpler.
Sorry, I won't be able to change anything in the patch. So you better off
re-sending a v2, if you want.
--
Denys
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [meta-ti] [PATCH] ti33x: allow different virtual/bootloader
2021-03-09 22:20 ` Denys Dmytriyenko
@ 2021-03-10 4:25 ` praneeth
0 siblings, 0 replies; 5+ messages in thread
From: praneeth @ 2021-03-10 4:25 UTC (permalink / raw)
To: Denys Dmytriyenko, Vivien Didelot; +Cc: meta-ti
On 3/9/2021 4:20 PM, Denys Dmytriyenko wrote:
> On Tue, Mar 09, 2021 at 03:42:34PM -0500, Vivien Didelot wrote:
>> Hi Denys,
>>
>> On Tue, 09 Mar 2021 15:34:13 -0500 Denys Dmytriyenko <denis@denix.org> wrote:
>>> On Tue, Mar 09, 2021 at 12:23:31PM -0500, Vivien Didelot wrote:
>>>> Boards like the beaglebone currently hardcode "u-boot" as a dependency
>>>> for the image and the wic format, and this prevents one from choosing
>>>> a different bootloader via:
>>>>
>>>> PREFERRED_PROVIDER_virtual/bootloader = "non-u-boot-bootloader"
>>>>
>>>> Depending on "virtual/bootloader" instead of "u-boot" fixes this.
>>>>
>>>> Signed-off-by: Vivien Didelot <vdidelot@pbsc.com>
>>>
>>> Could have added Suggested-by: here. Oh, well...
>>>
>>> Reviewed-by: Denys Dmytriyenko <denis@denix.org>
>>
>> Oops I messed up, can you please add your address as Suggested-by:,
>> and set the author address to my Signed-off-by: address? Otherwise
>> I can resend if that is simpler.
>
> Sorry, I won't be able to change anything in the patch. So you better off
> re-sending a v2, if you want.
Denys,Vivien,
Updated Suggested-by and pushed to dunfell-next.
https://git.yoctoproject.org/cgit/cgit.cgi/meta-ti/commit/?h=dunfell-next&id=9ca1472eef933748b94855d45dc0ab0c14884486
>
>
>
>
>
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2021-03-10 4:25 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-03-09 17:23 [PATCH] ti33x: allow different virtual/bootloader Vivien Didelot
2021-03-09 20:34 ` Denys Dmytriyenko
2021-03-09 20:42 ` Vivien Didelot
2021-03-09 22:20 ` Denys Dmytriyenko
2021-03-10 4:25 ` [meta-ti] " praneeth
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.