From: Russell King - ARM Linux admin <linux@armlinux.org.uk>
To: Jan Kardell <jan.kardell@telliq.com>
Cc: Linux ARM <linux-arm-kernel@lists.infradead.org>,
linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org,
Tony Lindgren <tony@atomide.com>,
Andrew Morton <akpm@linux-foundation.org>,
linux-mm@kvack.org
Subject: Re: arm: lockdep complaining about locks allocations in static memory
Date: Wed, 10 Mar 2021 14:59:04 +0000 [thread overview]
Message-ID: <20210310145904.GA1470@shell.armlinux.org.uk> (raw)
In-Reply-To: <6df24716-8b41-8e9a-f2f4-a0f5d49643bd@telliq.com>
On Wed, Mar 10, 2021 at 02:54:30PM +0100, Jan Kardell wrote:
> Hi,
>
> During work lift the software and kernel versions on our custom TI am3352
> board I started to see lockdep warnings after enabling CONFIG_PREEMT.
> Lockdep seems to think the memory that previously was initmem is static
> memory. I'm using linux 5.4, as that is what is used in the next OpenWrt
> version.
>
> [ 92.198989] WARNING: CPU: 0 PID: 2015 at kernel/locking/lockdep.c:1119
> alloc_netdev_mqs+0xb4/0x3b0
>
> I guess CONFIG_PREEMT just changes the timing of allocations, and is
> otherwise irrelevant.
>
> This was fixed for s390 in linux 5.2 commit
> 7a5da02de8d6eafba99556f8c98e5313edebb449 by adding the function
> arch_is_kernel_initmem_freed(). Later a very similar change was made for
> powerpc, and a different solution for x86. I now believe that is needed for
> arm as well. Though I don't know the inner workings of arm memory management
> so I don't know if an identical solution to s390 will do for arm, but my
> experiments suggests it works for am335x. The commit message for s390 says
> "virt == phys", but that seems not to be the case for my arm system.
I don't see any reason this couldn't be added to arm, but it needs
someone to create and test a patch - which implies that they need to
have a problem that needs to be solved. As you seem to be experiencing
the problem, it seems you are well suited to this. Thanks.
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!
WARNING: multiple messages have this Message-ID (diff)
From: Russell King - ARM Linux admin <linux@armlinux.org.uk>
To: Jan Kardell <jan.kardell@telliq.com>
Cc: Linux ARM <linux-arm-kernel@lists.infradead.org>,
linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org,
Tony Lindgren <tony@atomide.com>,
Andrew Morton <akpm@linux-foundation.org>,
linux-mm@kvack.org
Subject: Re: arm: lockdep complaining about locks allocations in static memory
Date: Wed, 10 Mar 2021 14:59:04 +0000 [thread overview]
Message-ID: <20210310145904.GA1470@shell.armlinux.org.uk> (raw)
In-Reply-To: <6df24716-8b41-8e9a-f2f4-a0f5d49643bd@telliq.com>
On Wed, Mar 10, 2021 at 02:54:30PM +0100, Jan Kardell wrote:
> Hi,
>
> During work lift the software and kernel versions on our custom TI am3352
> board I started to see lockdep warnings after enabling CONFIG_PREEMT.
> Lockdep seems to think the memory that previously was initmem is static
> memory. I'm using linux 5.4, as that is what is used in the next OpenWrt
> version.
>
> [ 92.198989] WARNING: CPU: 0 PID: 2015 at kernel/locking/lockdep.c:1119
> alloc_netdev_mqs+0xb4/0x3b0
>
> I guess CONFIG_PREEMT just changes the timing of allocations, and is
> otherwise irrelevant.
>
> This was fixed for s390 in linux 5.2 commit
> 7a5da02de8d6eafba99556f8c98e5313edebb449 by adding the function
> arch_is_kernel_initmem_freed(). Later a very similar change was made for
> powerpc, and a different solution for x86. I now believe that is needed for
> arm as well. Though I don't know the inner workings of arm memory management
> so I don't know if an identical solution to s390 will do for arm, but my
> experiments suggests it works for am335x. The commit message for s390 says
> "virt == phys", but that seems not to be the case for my arm system.
I don't see any reason this couldn't be added to arm, but it needs
someone to create and test a patch - which implies that they need to
have a problem that needs to be solved. As you seem to be experiencing
the problem, it seems you are well suited to this. Thanks.
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-03-10 14:59 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-10 13:54 arm: lockdep complaining about locks allocations in static memory Jan Kardell
2021-03-10 13:54 ` Jan Kardell
2021-03-10 14:59 ` Russell King - ARM Linux admin [this message]
2021-03-10 14:59 ` Russell King - ARM Linux admin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210310145904.GA1470@shell.armlinux.org.uk \
--to=linux@armlinux.org.uk \
--cc=akpm@linux-foundation.org \
--cc=jan.kardell@telliq.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-omap@vger.kernel.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.