From: Fabio Aiuto <fabioaiuto83@gmail.com>
To: Greg KH <gregkh@linuxfoundation.org>
Subject: Re: [PATCH] staging: rtl8723bs: align comments
Date: Wed, 10 Mar 2021 22:58:32 +0100 [thread overview]
Message-ID: <20210310160946.GA6421@agape.jhs> (raw)
In-Reply-To: <YEjrEErDZTH47gto@kroah.com>
On Wed, Mar 10, 2021 at 04:51:44PM +0100, Greg KH wrote:
> On Wed, Mar 10, 2021 at 04:37:21PM +0100, Fabio Aiuto wrote:
> > fix the following checkpatch warnings:
> >
> > WARNING: Block comments use * on subsequent lines
> > + /*
> > + AMPDU_para [1:0]:Max AMPDU Len => 0:8k , 1:16k, 2:32k, 3:64k
> > --
> > WARNING: Block comments use * on subsequent lines
> > +/*
> > +op_mode
> >
> > Signed-off-by: Fabio Aiuto <fabioaiuto83@gmail.com>
> > ---
> > drivers/staging/rtl8723bs/core/rtw_ap.c | 28 ++++++++++++-------------
> > 1 file changed, 14 insertions(+), 14 deletions(-)
> >
> > diff --git a/drivers/staging/rtl8723bs/core/rtw_ap.c b/drivers/staging/rtl8723bs/core/rtw_ap.c
> > index b6f944b37b08..3a0e4f64466a 100644
> > --- a/drivers/staging/rtl8723bs/core/rtw_ap.c
> > +++ b/drivers/staging/rtl8723bs/core/rtw_ap.c
> > @@ -721,9 +721,9 @@ static void update_hw_ht_param(struct adapter *padapter)
> >
> > /* handle A-MPDU parameter field */
> > /*
> > - AMPDU_para [1:0]:Max AMPDU Len => 0:8k , 1:16k, 2:32k, 3:64k
> > - AMPDU_para [4:2]:Min MPDU Start Spacing
> > - */
> > + * AMPDU_para [1:0]:Max AMPDU Len => 0:8k , 1:16k, 2:32k, 3:64k
> > + * AMPDU_para [4:2]:Min MPDU Start Spacing
> > + */
> > max_AMPDU_len = pmlmeinfo->HT_caps.u.HT_cap_element.AMPDU_para & 0x03;
> >
> > min_MPDU_spacing = (
> > @@ -1815,17 +1815,17 @@ void update_beacon(struct adapter *padapter, u8 ie_id, u8 *oui, u8 tx)
> > }
> >
> > /*
> > -op_mode
> > -Set to 0 (HT pure) under the following conditions
> > - - all STAs in the BSS are 20/40 MHz HT in 20/40 MHz BSS or
> > - - all STAs in the BSS are 20 MHz HT in 20 MHz BSS
> > -Set to 1 (HT non-member protection) if there may be non-HT STAs
> > - in both the primary and the secondary channel
> > -Set to 2 if only HT STAs are associated in BSS,
> > - however and at least one 20 MHz HT STA is associated
> > -Set to 3 (HT mixed mode) when one or more non-HT STAs are associated
> > - (currently non-GF HT station is considered as non-HT STA also)
> > -*/
> > + *op_mode
> > + *Set to 0 (HT pure) under the following conditions
> > + * - all STAs in the BSS are 20/40 MHz HT in 20/40 MHz BSS or
> > + * - all STAs in the BSS are 20 MHz HT in 20 MHz BSS
> > + *Set to 1 (HT non-member protection) if there may be non-HT STAs
> > + * in both the primary and the secondary channel
> > + *Set to 2 if only HT STAs are associated in BSS,
> > + * however and at least one 20 MHz HT STA is associated
> > + *Set to 3 (HT mixed mode) when one or more non-HT STAs are associated
> > + * (currently non-GF HT station is considered as non-HT STA also)
> > + */
>
> Add a space after the ' ' to make it look correct please.
>
> thanks,
>
> greg k-h
I am sorry, I fear I don't understand, checkpatch.sh script says the patch is ok.
Where have I to add a ' ' (a blank?)?
thank you,
fabio
WARNING: multiple messages have this Message-ID (diff)
From: Fabio Aiuto <fabioaiuto83@gmail.com>
To: Greg KH <gregkh@linuxfoundation.org>
Subject: Re: [PATCH] staging: rtl8723bs: align comments
Date: Wed, 10 Mar 2021 23:13:35 +0100 [thread overview]
Message-ID: <20210310160946.GA6421@agape.jhs> (raw)
Message-ID: <20210310221335.DZOp69vkbmeVNY1k5dzKUehkQmx6NxasIAHjl53nIEw@z> (raw)
In-Reply-To: <YEjrEErDZTH47gto@kroah.com>
On Wed, Mar 10, 2021 at 04:51:44PM +0100, Greg KH wrote:
> On Wed, Mar 10, 2021 at 04:37:21PM +0100, Fabio Aiuto wrote:
> > fix the following checkpatch warnings:
> >
> > WARNING: Block comments use * on subsequent lines
> > + /*
> > + AMPDU_para [1:0]:Max AMPDU Len => 0:8k , 1:16k, 2:32k, 3:64k
> > --
> > WARNING: Block comments use * on subsequent lines
> > +/*
> > +op_mode
> >
> > Signed-off-by: Fabio Aiuto <fabioaiuto83@gmail.com>
> > ---
> > drivers/staging/rtl8723bs/core/rtw_ap.c | 28 ++++++++++++-------------
> > 1 file changed, 14 insertions(+), 14 deletions(-)
> >
> > diff --git a/drivers/staging/rtl8723bs/core/rtw_ap.c b/drivers/staging/rtl8723bs/core/rtw_ap.c
> > index b6f944b37b08..3a0e4f64466a 100644
> > --- a/drivers/staging/rtl8723bs/core/rtw_ap.c
> > +++ b/drivers/staging/rtl8723bs/core/rtw_ap.c
> > @@ -721,9 +721,9 @@ static void update_hw_ht_param(struct adapter *padapter)
> >
> > /* handle A-MPDU parameter field */
> > /*
> > - AMPDU_para [1:0]:Max AMPDU Len => 0:8k , 1:16k, 2:32k, 3:64k
> > - AMPDU_para [4:2]:Min MPDU Start Spacing
> > - */
> > + * AMPDU_para [1:0]:Max AMPDU Len => 0:8k , 1:16k, 2:32k, 3:64k
> > + * AMPDU_para [4:2]:Min MPDU Start Spacing
> > + */
> > max_AMPDU_len = pmlmeinfo->HT_caps.u.HT_cap_element.AMPDU_para & 0x03;
> >
> > min_MPDU_spacing = (
> > @@ -1815,17 +1815,17 @@ void update_beacon(struct adapter *padapter, u8 ie_id, u8 *oui, u8 tx)
> > }
> >
> > /*
> > -op_mode
> > -Set to 0 (HT pure) under the following conditions
> > - - all STAs in the BSS are 20/40 MHz HT in 20/40 MHz BSS or
> > - - all STAs in the BSS are 20 MHz HT in 20 MHz BSS
> > -Set to 1 (HT non-member protection) if there may be non-HT STAs
> > - in both the primary and the secondary channel
> > -Set to 2 if only HT STAs are associated in BSS,
> > - however and at least one 20 MHz HT STA is associated
> > -Set to 3 (HT mixed mode) when one or more non-HT STAs are associated
> > - (currently non-GF HT station is considered as non-HT STA also)
> > -*/
> > + *op_mode
> > + *Set to 0 (HT pure) under the following conditions
> > + * - all STAs in the BSS are 20/40 MHz HT in 20/40 MHz BSS or
> > + * - all STAs in the BSS are 20 MHz HT in 20 MHz BSS
> > + *Set to 1 (HT non-member protection) if there may be non-HT STAs
> > + * in both the primary and the secondary channel
> > + *Set to 2 if only HT STAs are associated in BSS,
> > + * however and at least one 20 MHz HT STA is associated
> > + *Set to 3 (HT mixed mode) when one or more non-HT STAs are associated
> > + * (currently non-GF HT station is considered as non-HT STA also)
> > + */
>
> Add a space after the ' ' to make it look correct please.
>
> thanks,
>
> greg k-h
I am sorry, I fear I don't understand, checkpatch.sh script says the patch is ok.
Where have I to add a ' ' (a blank?)?
thank you,
fabio
next prev parent reply other threads:[~2021-03-10 21:59 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-10 15:37 [PATCH] staging: rtl8723bs: align comments Fabio Aiuto
2021-03-10 15:51 ` Greg KH
2021-03-10 21:58 ` Fabio Aiuto [this message]
2021-03-10 22:13 ` Fabio Aiuto
2021-03-10 22:27 ` Eric Curtin
2021-03-10 22:45 ` Fabio Aiuto
2021-03-12 9:15 ` Fabio Aiuto
[not found] ` <CANiq72mEdHhJoCEmD0DD7QGP57soF3DGGoFNb89WF-4Oh_sscg@mail.gmail.com>
2021-03-11 13:31 ` Fabio Aiuto
2021-03-10 17:48 ` Dan Carpenter
2021-03-11 9:15 ` Joe Perches
2021-03-11 16:38 ` Fabio Aiuto
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210310160946.GA6421@agape.jhs \
--to=fabioaiuto83@gmail.com \
--cc=gregkh@linuxfoundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.