[ast:fexit_fix 2/2] kernel/bpf/trampoline.c:199:29: sparse: sparse: symbol 'bpf_trampoline_image_alloc' was not declared. Should it be

[ast:fexit_fix 2/2] kernel/bpf/trampoline.c:199:29: sparse: sparse: symbol 'bpf_trampoline_image_alloc' was not declared. Should it be

[kernel test robot]

[-- Attachment #1: Type: text/plain, Size: 1334 bytes --]

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/ast/bpf.git fexit_fix
head:   d0953e3c28d70fa9d39e6db07d2cffbe7ce1f0e2
commit: d0953e3c28d70fa9d39e6db07d2cffbe7ce1f0e2 [2/2] bpf: Fix fexit trampoline.
config: x86_64-randconfig-s032-20210312 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
reproduce:
        # apt-get install sparse
        # sparse version: v0.6.3-262-g5e674421-dirty
        # https://git.kernel.org/pub/scm/linux/kernel/git/ast/bpf.git/commit/?id=d0953e3c28d70fa9d39e6db07d2cffbe7ce1f0e2
        git remote add ast https://git.kernel.org/pub/scm/linux/kernel/git/ast/bpf.git
        git fetch --no-tags ast fexit_fix
        git checkout d0953e3c28d70fa9d39e6db07d2cffbe7ce1f0e2
        # save the attached .config to linux build tree
        make W=1 C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' ARCH=x86_64 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>


"sparse warnings: (new ones prefixed by >>)"
>> kernel/bpf/trampoline.c:199:29: sparse: sparse: symbol 'bpf_trampoline_image_alloc' was not declared. Should it be static?

Please review and possibly fold the followup patch.

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 42557 bytes --]

[RFC PATCH ast] bpf: bpf_trampoline_image_alloc() can be static

[kernel test robot]

[-- Attachment #1: Type: text/plain, Size: 789 bytes --]


Fixes: d0953e3c28d7 ("bpf: Fix fexit trampoline.")
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: kernel test robot <lkp@intel.com>
---
 trampoline.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/kernel/bpf/trampoline.c b/kernel/bpf/trampoline.c
index 112b33f3f51cd..ad68ea6db642c 100644
--- a/kernel/bpf/trampoline.c
+++ b/kernel/bpf/trampoline.c
@@ -196,7 +196,7 @@ static void bpf_trampoline_image_put(struct bpf_trampoline_image *im)
 	call_rcu_tasks_trace(&im->rcu, __bpf_trampoline_image_put_rcu);
 }
 
-struct bpf_trampoline_image *bpf_trampoline_image_alloc(u64 key, u32 idx)
+static struct bpf_trampoline_image *bpf_trampoline_image_alloc(u64 key, u32 idx)
 {
 	struct bpf_trampoline_image *im;
 	struct bpf_ksym *ksym;