All of lore.kernel.org
 help / color / mirror / Atom feed
From: Shawn Guo <shawnguo@kernel.org>
To: Russell King <rmk+kernel@armlinux.org.uk>
Cc: Li Yang <leoyang.li@nxp.com>, Rob Herring <robh+dt@kernel.org>,
	linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
	Jon Nettleton <jon@solid-run.com>
Subject: Re: [PATCH] arm64: dts: lx2160a-clearfog-itx: add SFP support [*experimental*]
Date: Mon, 15 Mar 2021 15:03:15 +0800	[thread overview]
Message-ID: <20210315070314.GN11246@dragon> (raw)
In-Reply-To: <E1lJfLu-0000Q2-Nl@rmk-PC.armlinux.org.uk>

On Tue, Mar 09, 2021 at 04:36:58PM +0000, Russell King wrote:
> Add 2x2 SFP+ cage support for clearfog-itx boards.
> 
> Signed-off-by: Russell King <rmk+kernel@armlinux.org.uk>

What is the implication of [*experimental*] in subject?

Shawn

> ---
>  .../boot/dts/freescale/fsl-lx2160a-cex7.dtsi  | 24 +++++++
>  .../freescale/fsl-lx2160a-clearfog-itx.dtsi   | 64 +++++++++++++++++++
>  2 files changed, 88 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/freescale/fsl-lx2160a-cex7.dtsi b/arch/arm64/boot/dts/freescale/fsl-lx2160a-cex7.dtsi
> index 459dccad8326..afb455210bd0 100644
> --- a/arch/arm64/boot/dts/freescale/fsl-lx2160a-cex7.dtsi
> +++ b/arch/arm64/boot/dts/freescale/fsl-lx2160a-cex7.dtsi
> @@ -122,6 +122,30 @@
>  				vcc-supply = <&sb_3v3>;
>  			};
>  		};
> +
> +		sfp0_i2c: i2c@4 {
> +			#address-cells = <1>;
> +			#size-cells = <0>;
> +			reg = <4>;
> +		};
> +
> +		sfp1_i2c: i2c@5 {
> +			#address-cells = <1>;
> +			#size-cells = <0>;
> +			reg = <5>;
> +		};
> +
> +		sfp2_i2c: i2c@6 {
> +			#address-cells = <1>;
> +			#size-cells = <0>;
> +			reg = <6>;
> +		};
> +
> +		sfp3_i2c: i2c@7 {
> +			#address-cells = <1>;
> +			#size-cells = <0>;
> +			reg = <7>;
> +		};
>  	};
>  };
>  
> diff --git a/arch/arm64/boot/dts/freescale/fsl-lx2160a-clearfog-itx.dtsi b/arch/arm64/boot/dts/freescale/fsl-lx2160a-clearfog-itx.dtsi
> index 2b63235ca627..17f8e733972a 100644
> --- a/arch/arm64/boot/dts/freescale/fsl-lx2160a-clearfog-itx.dtsi
> +++ b/arch/arm64/boot/dts/freescale/fsl-lx2160a-clearfog-itx.dtsi
> @@ -30,6 +30,54 @@
>  			gpios = <&gpio2 6 GPIO_ACTIVE_LOW>;
>  		};
>  	};
> +
> +	sfp0: sfp-0 {
> +		compatible = "sff,sfp";
> +		i2c-bus = <&sfp0_i2c>;
> +		mod-def0-gpio = <&gpio2 0 GPIO_ACTIVE_LOW>;
> +		maximum-power-milliwatt = <2000>;
> +	};
> +
> +	sfp1: sfp-1 {
> +		compatible = "sff,sfp";
> +		i2c-bus = <&sfp1_i2c>;
> +		mod-def0-gpio = <&gpio2 9 GPIO_ACTIVE_LOW>;
> +		maximum-power-milliwatt = <2000>;
> +	};
> +
> +	sfp2: sfp-2 {
> +		compatible = "sff,sfp";
> +		i2c-bus = <&sfp2_i2c>;
> +		mod-def0-gpio = <&gpio2 10 GPIO_ACTIVE_LOW>;
> +		maximum-power-milliwatt = <2000>;
> +	};
> +
> +	sfp3: sfp-3 {
> +		compatible = "sff,sfp";
> +		i2c-bus = <&sfp3_i2c>;
> +		mod-def0-gpio = <&gpio2 11 GPIO_ACTIVE_LOW>;
> +		maximum-power-milliwatt = <2000>;
> +	};
> +};
> +
> +&dpmac7 {
> +	sfp = <&sfp0>;
> +	managed = "in-band-status";
> +};
> +
> +&dpmac8 {
> +	sfp = <&sfp1>;
> +	managed = "in-band-status";
> +};
> +
> +&dpmac9 {
> +	sfp = <&sfp2>;
> +	managed = "in-band-status";
> +};
> +
> +&dpmac10 {
> +	sfp = <&sfp3>;
> +	managed = "in-band-status";
>  };
>  
>  &emdio2 {
> @@ -44,6 +92,22 @@
>  	status = "okay";
>  };
>  
> +&pcs_mdio7 {
> +	status = "okay";
> +};
> +
> +&pcs_mdio8 {
> +	status = "okay";
> +};
> +
> +&pcs_mdio9 {
> +	status = "okay";
> +};
> +
> +&pcs_mdio10 {
> +	status = "okay";
> +};
> +
>  &sata0 {
>  	status = "okay";
>  };
> -- 
> 2.20.1
> 

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

WARNING: multiple messages have this Message-ID (diff)
From: Shawn Guo <shawnguo@kernel.org>
To: Russell King <rmk+kernel@armlinux.org.uk>
Cc: Li Yang <leoyang.li@nxp.com>, Rob Herring <robh+dt@kernel.org>,
	linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
	Jon Nettleton <jon@solid-run.com>
Subject: Re: [PATCH] arm64: dts: lx2160a-clearfog-itx: add SFP support [*experimental*]
Date: Mon, 15 Mar 2021 15:03:15 +0800	[thread overview]
Message-ID: <20210315070314.GN11246@dragon> (raw)
In-Reply-To: <E1lJfLu-0000Q2-Nl@rmk-PC.armlinux.org.uk>

On Tue, Mar 09, 2021 at 04:36:58PM +0000, Russell King wrote:
> Add 2x2 SFP+ cage support for clearfog-itx boards.
> 
> Signed-off-by: Russell King <rmk+kernel@armlinux.org.uk>

What is the implication of [*experimental*] in subject?

Shawn

> ---
>  .../boot/dts/freescale/fsl-lx2160a-cex7.dtsi  | 24 +++++++
>  .../freescale/fsl-lx2160a-clearfog-itx.dtsi   | 64 +++++++++++++++++++
>  2 files changed, 88 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/freescale/fsl-lx2160a-cex7.dtsi b/arch/arm64/boot/dts/freescale/fsl-lx2160a-cex7.dtsi
> index 459dccad8326..afb455210bd0 100644
> --- a/arch/arm64/boot/dts/freescale/fsl-lx2160a-cex7.dtsi
> +++ b/arch/arm64/boot/dts/freescale/fsl-lx2160a-cex7.dtsi
> @@ -122,6 +122,30 @@
>  				vcc-supply = <&sb_3v3>;
>  			};
>  		};
> +
> +		sfp0_i2c: i2c@4 {
> +			#address-cells = <1>;
> +			#size-cells = <0>;
> +			reg = <4>;
> +		};
> +
> +		sfp1_i2c: i2c@5 {
> +			#address-cells = <1>;
> +			#size-cells = <0>;
> +			reg = <5>;
> +		};
> +
> +		sfp2_i2c: i2c@6 {
> +			#address-cells = <1>;
> +			#size-cells = <0>;
> +			reg = <6>;
> +		};
> +
> +		sfp3_i2c: i2c@7 {
> +			#address-cells = <1>;
> +			#size-cells = <0>;
> +			reg = <7>;
> +		};
>  	};
>  };
>  
> diff --git a/arch/arm64/boot/dts/freescale/fsl-lx2160a-clearfog-itx.dtsi b/arch/arm64/boot/dts/freescale/fsl-lx2160a-clearfog-itx.dtsi
> index 2b63235ca627..17f8e733972a 100644
> --- a/arch/arm64/boot/dts/freescale/fsl-lx2160a-clearfog-itx.dtsi
> +++ b/arch/arm64/boot/dts/freescale/fsl-lx2160a-clearfog-itx.dtsi
> @@ -30,6 +30,54 @@
>  			gpios = <&gpio2 6 GPIO_ACTIVE_LOW>;
>  		};
>  	};
> +
> +	sfp0: sfp-0 {
> +		compatible = "sff,sfp";
> +		i2c-bus = <&sfp0_i2c>;
> +		mod-def0-gpio = <&gpio2 0 GPIO_ACTIVE_LOW>;
> +		maximum-power-milliwatt = <2000>;
> +	};
> +
> +	sfp1: sfp-1 {
> +		compatible = "sff,sfp";
> +		i2c-bus = <&sfp1_i2c>;
> +		mod-def0-gpio = <&gpio2 9 GPIO_ACTIVE_LOW>;
> +		maximum-power-milliwatt = <2000>;
> +	};
> +
> +	sfp2: sfp-2 {
> +		compatible = "sff,sfp";
> +		i2c-bus = <&sfp2_i2c>;
> +		mod-def0-gpio = <&gpio2 10 GPIO_ACTIVE_LOW>;
> +		maximum-power-milliwatt = <2000>;
> +	};
> +
> +	sfp3: sfp-3 {
> +		compatible = "sff,sfp";
> +		i2c-bus = <&sfp3_i2c>;
> +		mod-def0-gpio = <&gpio2 11 GPIO_ACTIVE_LOW>;
> +		maximum-power-milliwatt = <2000>;
> +	};
> +};
> +
> +&dpmac7 {
> +	sfp = <&sfp0>;
> +	managed = "in-band-status";
> +};
> +
> +&dpmac8 {
> +	sfp = <&sfp1>;
> +	managed = "in-band-status";
> +};
> +
> +&dpmac9 {
> +	sfp = <&sfp2>;
> +	managed = "in-band-status";
> +};
> +
> +&dpmac10 {
> +	sfp = <&sfp3>;
> +	managed = "in-band-status";
>  };
>  
>  &emdio2 {
> @@ -44,6 +92,22 @@
>  	status = "okay";
>  };
>  
> +&pcs_mdio7 {
> +	status = "okay";
> +};
> +
> +&pcs_mdio8 {
> +	status = "okay";
> +};
> +
> +&pcs_mdio9 {
> +	status = "okay";
> +};
> +
> +&pcs_mdio10 {
> +	status = "okay";
> +};
> +
>  &sata0 {
>  	status = "okay";
>  };
> -- 
> 2.20.1
> 

  reply	other threads:[~2021-03-15  7:05 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-09 16:36 [PATCH] arm64: dts: lx2160a-clearfog-itx: add SFP support [*experimental*] Russell King
2021-03-09 16:36 ` Russell King
2021-03-15  7:03 ` Shawn Guo [this message]
2021-03-15  7:03   ` Shawn Guo
2021-03-15 10:02   ` Russell King - ARM Linux admin
2021-03-15 10:02     ` Russell King - ARM Linux admin
2021-03-17  7:55     ` Shawn Guo
2021-03-17  7:55       ` Shawn Guo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210315070314.GN11246@dragon \
    --to=shawnguo@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=jon@solid-run.com \
    --cc=leoyang.li@nxp.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=rmk+kernel@armlinux.org.uk \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.