[PATCH v2] staging: vt665x: fix alignment constraints

[PATCH v2] staging: vt665x: fix alignment constraints

[Edmundo Carmona Antoranz]

Removing 2 instances of alignment warnings

drivers/staging/vt6655/rxtx.h:153:1: warning: alignment 1 of ‘struct vnt_cts’ is less than 2 [-Wpacked-not-aligned]
drivers/staging/vt6655/rxtx.h:163:1: warning: alignment 1 of ‘struct vnt_cts_fb’ is less than 2 [-Wpacked-not-aligned]

The root cause seems to be that _because_ struct ieee80211_cts is marked as __aligned(2),
this requires any encapsulating struct to also have an alignment of 2.

Fixes: 2faf12c57efe ("staging: vt665x: fix alignment constraints")
Signed-off-by: Edmundo Carmona Antoranz <eantoranz@gmail.com>
---
 drivers/staging/vt6655/rxtx.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/vt6655/rxtx.h b/drivers/staging/vt6655/rxtx.h
index e7061d383306..c3c2c1566882 100644
--- a/drivers/staging/vt6655/rxtx.h
+++ b/drivers/staging/vt6655/rxtx.h
@@ -150,7 +150,7 @@ struct vnt_cts {
 	u16 reserved;
 	struct ieee80211_cts data;
 	u16 reserved2;
-} __packed;
+} __packed __aligned(2);
 
 struct vnt_cts_fb {
 	struct vnt_phy_field b;
@@ -160,7 +160,7 @@ struct vnt_cts_fb {
 	__le16 cts_duration_ba_f1;
 	struct ieee80211_cts data;
 	u16 reserved2;
-} __packed;
+} __packed __aligned(2);
 
 struct vnt_tx_fifo_head {
 	u8 tx_key[WLAN_KEY_LEN_CCMP];
-- 
2.30.1

Re: [PATCH v2] staging: vt665x: fix alignment constraints

[Edmundo Carmona Antoranz]

On Fri, Mar 12, 2021 at 9:00 AM Edmundo Carmona Antoranz
<eantoranz@gmail.com> wrote:
>

I wonder if this patch will be picked up if I don't include Greg in
the conversation. Should I send the patch again looping him in?

> --
> 2.30.1
>

Re: [PATCH v2] staging: vt665x: fix alignment constraints

[Julia Lawall]

On Tue, 16 Mar 2021, Edmundo Carmona Antoranz wrote:

> On Fri, Mar 12, 2021 at 9:00 AM Edmundo Carmona Antoranz
> <eantoranz@gmail.com> wrote:
> >
>
> I wonder if this patch will be picked up if I don't include Greg in
> the conversation. Should I send the patch again looping him in?

Whoever is the maintainer for the driver should be included.

julia

Re: [PATCH v2] staging: vt665x: fix alignment constraints

[Edmundo Carmona Antoranz]

On Tue, Mar 16, 2021 at 8:57 AM Julia Lawall <julia.lawall@inria.fr> wrote:
>
> Whoever is the maintainer for the driver should be included.

Right. Will send a v3 patch with him included. Thanks!

>
> julia

Re: [PATCH v2] staging: vt665x: fix alignment constraints

[Dan Carpenter]

On Tue, Mar 16, 2021 at 08:30:26AM -0600, Edmundo Carmona Antoranz wrote:
> On Fri, Mar 12, 2021 at 9:00 AM Edmundo Carmona Antoranz
> <eantoranz@gmail.com> wrote:
> >
> 
> I wonder if this patch will be picked up if I don't include Greg in
> the conversation. Should I send the patch again looping him in?
> 

Yes.  And you need to include the driver-devel mailing list from
get_maintainer.pl.  You can leave lkml out if you want.

regards,
dan carpenter