From: Jason Gunthorpe <jgg@nvidia.com>
To: "Tian, Kevin" <kevin.tian@intel.com>
Cc: Alex Williamson <alex.williamson@redhat.com>,
Cornelia Huck <cohuck@redhat.com>,
"kvm@vger.kernel.org" <kvm@vger.kernel.org>,
Kirti Wankhede <kwankhede@nvidia.com>,
"Raj, Ashok" <ashok.raj@intel.com>,
"Williams, Dan J" <dan.j.williams@intel.com>,
Daniel Vetter <daniel@ffwll.ch>, Christoph Hellwig <hch@lst.de>,
Leon Romanovsky <leonro@nvidia.com>,
Max Gurtovoy <mgurtovoy@nvidia.com>,
Tarun Gupta <targupta@nvidia.com>,
"Liu, Yi L" <yi.l.liu@intel.com>
Subject: Re: [PATCH v2 10/14] vfio/mdev: Use vfio_init/register/unregister_group_dev
Date: Tue, 16 Mar 2021 20:19:35 -0300 [thread overview]
Message-ID: <20210316231935.GE3799225@nvidia.com> (raw)
In-Reply-To: <MWHPR11MB18869E91B6DCC8A74A30E3B68C6B9@MWHPR11MB1886.namprd11.prod.outlook.com>
On Tue, Mar 16, 2021 at 08:09:19AM +0000, Tian, Kevin wrote:
> > From: Jason Gunthorpe <jgg@nvidia.com>
> > Sent: Saturday, March 13, 2021 8:56 AM
> >
> > mdev gets little benefit because it doesn't actually do anything, however
> > it is the last user, so move the code here for now.
>
> and indicate that vfio_add/del_group_dev is removed in this patch.
The "move the code here" (referring to the deleted functions) was
intended to cover that. I added some words:
mdev gets little benefit because it doesn't actually do anything, however
it is the last user, so move the vfio_init/register/unregister_group_dev()
code here for now.
> > diff --git a/drivers/vfio/mdev/vfio_mdev.c b/drivers/vfio/mdev/vfio_mdev.c
> > index b52eea128549ee..4469aaf31b56cb 100644
> > +++ b/drivers/vfio/mdev/vfio_mdev.c
> > @@ -21,6 +21,10 @@
> > #define DRIVER_AUTHOR "NVIDIA Corporation"
> > #define DRIVER_DESC "VFIO based driver for Mediated device"
> >
> > +struct mdev_vfio_device {
> > + struct vfio_device vdev;
> > +};
>
> following other vfio_XXX_device convention, what about calling it
> vfio_mdev_device? otherwise,
Right, but let's delete it as Alex suggests.
Jason
next prev parent reply other threads:[~2021-03-16 23:20 UTC|newest]
Thread overview: 82+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-13 0:55 [PATCH v2 00/14] Embed struct vfio_device in all sub-structures Jason Gunthorpe
2021-03-13 0:55 ` [PATCH v2 01/14] vfio: Remove extra put/gets around vfio_device->group Jason Gunthorpe
2021-03-16 7:33 ` Tian, Kevin
2021-03-16 23:07 ` Jason Gunthorpe
2021-03-17 0:47 ` Tian, Kevin
2021-03-19 13:58 ` Jason Gunthorpe
2021-03-16 11:15 ` Max Gurtovoy
2021-03-16 11:59 ` Cornelia Huck
2021-03-18 9:32 ` Auger Eric
2021-03-13 0:55 ` [PATCH v2 02/14] vfio: Simplify the lifetime logic for vfio_device Jason Gunthorpe
2021-03-16 7:38 ` Tian, Kevin
2021-03-16 12:10 ` Cornelia Huck
2021-03-16 20:24 ` Alex Williamson
2021-03-16 23:08 ` Jason Gunthorpe
2021-03-17 8:12 ` Cornelia Huck
2021-03-23 13:06 ` Jason Gunthorpe
2021-03-18 13:10 ` Auger Eric
2021-03-13 0:55 ` [PATCH v2 03/14] vfio: Split creation of a vfio_device into init and register ops Jason Gunthorpe
2021-03-16 7:55 ` Tian, Kevin
2021-03-16 13:34 ` Jason Gunthorpe
2021-03-17 0:55 ` Tian, Kevin
2021-03-16 12:25 ` Cornelia Huck
2021-03-16 21:13 ` Alex Williamson
2021-03-16 23:12 ` Jason Gunthorpe
2021-03-16 12:54 ` Max Gurtovoy
2021-03-18 13:18 ` Auger Eric
2021-03-13 0:55 ` [PATCH v2 04/14] vfio/platform: Use vfio_init/register/unregister_group_dev Jason Gunthorpe
2021-03-16 16:22 ` Cornelia Huck
2021-03-16 21:33 ` Alex Williamson
2021-03-16 21:45 ` Jason Gunthorpe
2021-03-18 13:40 ` Auger Eric
2021-03-13 0:55 ` [PATCH v2 05/14] vfio/fsl-mc: Re-order vfio_fsl_mc_probe() Jason Gunthorpe
2021-03-15 8:44 ` Christoph Hellwig
2021-03-16 9:16 ` Diana Craciun OSS
2021-03-16 16:28 ` Cornelia Huck
2021-03-17 16:36 ` Diana Craciun OSS
2021-03-17 22:59 ` Jason Gunthorpe
2021-03-13 0:55 ` [PATCH v2 06/14] vfio/fsl-mc: Use vfio_init/register/unregister_group_dev Jason Gunthorpe
2021-03-15 8:44 ` Christoph Hellwig
2021-03-16 16:43 ` Cornelia Huck
2021-03-13 0:55 ` [PATCH v2 07/14] vfio/pci: Move VGA and VF initialization to functions Jason Gunthorpe
2021-03-15 8:45 ` Christoph Hellwig
2021-03-15 23:07 ` Jason Gunthorpe
2021-03-16 6:27 ` Christoph Hellwig
2021-03-16 7:57 ` Tian, Kevin
2021-03-16 13:02 ` Max Gurtovoy
2021-03-16 23:04 ` Jason Gunthorpe
2021-03-16 16:51 ` Cornelia Huck
2021-03-18 16:34 ` Auger Eric
2021-03-13 0:56 ` [PATCH v2 08/14] vfio/pci: Re-order vfio_pci_probe() Jason Gunthorpe
2021-03-15 8:46 ` Christoph Hellwig
2021-03-16 8:04 ` Tian, Kevin
2021-03-16 13:20 ` Jason Gunthorpe
2021-03-16 22:27 ` Alex Williamson
2021-03-17 0:56 ` Tian, Kevin
2021-03-16 11:28 ` Max Gurtovoy
2021-03-17 10:32 ` Cornelia Huck
2021-03-18 16:50 ` Auger Eric
2021-03-13 0:56 ` [PATCH v2 09/14] vfio/pci: Use vfio_init/register/unregister_group_dev Jason Gunthorpe
2021-03-16 8:06 ` Tian, Kevin
2021-03-17 10:33 ` Cornelia Huck
2021-03-18 13:43 ` Auger Eric
2021-03-13 0:56 ` [PATCH v2 10/14] vfio/mdev: " Jason Gunthorpe
2021-03-16 8:09 ` Tian, Kevin
2021-03-16 22:51 ` Alex Williamson
2021-03-16 23:19 ` Jason Gunthorpe [this message]
2021-03-17 10:36 ` Cornelia Huck
2021-03-13 0:56 ` [PATCH v2 11/14] vfio/mdev: Make to_mdev_device() into a static inline Jason Gunthorpe
2021-03-16 8:10 ` Tian, Kevin
2021-03-16 22:55 ` Alex Williamson
2021-03-16 23:20 ` Jason Gunthorpe
2021-03-17 10:36 ` Cornelia Huck
2021-03-13 0:56 ` [PATCH v2 12/14] vfio: Make vfio_device_ops pass a 'struct vfio_device *' instead of 'void *' Jason Gunthorpe
2021-03-15 8:58 ` Christoph Hellwig
2021-03-17 11:33 ` Cornelia Huck
2021-03-13 0:56 ` [PATCH v2 13/14] vfio/pci: Replace uses of vfio_device_data() with container_of Jason Gunthorpe
2021-03-16 8:20 ` Tian, Kevin
2021-03-17 12:06 ` Cornelia Huck
2021-03-13 0:56 ` [PATCH v2 14/14] vfio: Remove device_data from the vfio bus driver API Jason Gunthorpe
2021-03-16 8:22 ` Tian, Kevin
2021-03-17 12:08 ` Cornelia Huck
2021-03-17 23:24 ` Max Gurtovoy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210316231935.GE3799225@nvidia.com \
--to=jgg@nvidia.com \
--cc=alex.williamson@redhat.com \
--cc=ashok.raj@intel.com \
--cc=cohuck@redhat.com \
--cc=dan.j.williams@intel.com \
--cc=daniel@ffwll.ch \
--cc=hch@lst.de \
--cc=kevin.tian@intel.com \
--cc=kvm@vger.kernel.org \
--cc=kwankhede@nvidia.com \
--cc=leonro@nvidia.com \
--cc=mgurtovoy@nvidia.com \
--cc=targupta@nvidia.com \
--cc=yi.l.liu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.