* [PATCH] block: remove RQF_ALLOCED
@ 2021-03-17 7:21 Christoph Hellwig
2021-03-17 13:42 ` Christoph Hellwig
0 siblings, 1 reply; 4+ messages in thread
From: Christoph Hellwig @ 2021-03-17 7:21 UTC (permalink / raw)
To: axboe; +Cc: linux-block
This flag is not used anywhere.
Signed-off-by: Christoph Hellwig <hch@lst.de>
---
include/linux/blkdev.h | 2 --
1 file changed, 2 deletions(-)
diff --git a/include/linux/blkdev.h b/include/linux/blkdev.h
index bc6bc8383b434e..158aefae1030db 100644
--- a/include/linux/blkdev.h
+++ b/include/linux/blkdev.h
@@ -85,8 +85,6 @@ typedef __u32 __bitwise req_flags_t;
#define RQF_ELVPRIV ((__force req_flags_t)(1 << 12))
/* account into disk and partition IO statistics */
#define RQF_IO_STAT ((__force req_flags_t)(1 << 13))
-/* request came from our alloc pool */
-#define RQF_ALLOCED ((__force req_flags_t)(1 << 14))
/* runtime pm request */
#define RQF_PM ((__force req_flags_t)(1 << 15))
/* on IO scheduler merge hash */
--
2.30.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] block: remove RQF_ALLOCED
2021-03-17 7:21 [PATCH] block: remove RQF_ALLOCED Christoph Hellwig
@ 2021-03-17 13:42 ` Christoph Hellwig
2021-03-18 1:18 ` Chaitanya Kulkarni
0 siblings, 1 reply; 4+ messages in thread
From: Christoph Hellwig @ 2021-03-17 13:42 UTC (permalink / raw)
To: axboe; +Cc: linux-block
On Wed, Mar 17, 2021 at 08:21:22AM +0100, Christoph Hellwig wrote:
> This flag is not used anywhere.
Except that blk-mq-debugfs prints it in a completely obsfucated way.
Sight, I'll need to fix that mess while I'm at it.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] block: remove RQF_ALLOCED
2021-03-17 13:42 ` Christoph Hellwig
@ 2021-03-18 1:18 ` Chaitanya Kulkarni
2021-03-18 1:49 ` Chaitanya Kulkarni
0 siblings, 1 reply; 4+ messages in thread
From: Chaitanya Kulkarni @ 2021-03-18 1:18 UTC (permalink / raw)
To: Christoph Hellwig, axboe@kernel.dk; +Cc: linux-block@vger.kernel.org
On 3/17/21 06:43, Christoph Hellwig wrote:
> On Wed, Mar 17, 2021 at 08:21:22AM +0100, Christoph Hellwig wrote:
>> This flag is not used anywhere.
> Except that blk-mq-debugfs prints it in a completely obsfucated way.
> Sight, I'll need to fix that mess while I'm at it.
>
If you are going to fix this, does it makes sense to fix the rest of
the obfuscation ? such as QUEUE_FLAGE_NAME/HCTX_FLAG_NAME/CMD_FLAG_NAME ?
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] block: remove RQF_ALLOCED
2021-03-18 1:18 ` Chaitanya Kulkarni
@ 2021-03-18 1:49 ` Chaitanya Kulkarni
0 siblings, 0 replies; 4+ messages in thread
From: Chaitanya Kulkarni @ 2021-03-18 1:49 UTC (permalink / raw)
To: Christoph Hellwig, axboe@kernel.dk; +Cc: linux-block@vger.kernel.org
On 3/17/21 18:18, Chaitanya Kulkarni wrote:
> On 3/17/21 06:43, Christoph Hellwig wrote:
>> On Wed, Mar 17, 2021 at 08:21:22AM +0100, Christoph Hellwig wrote:
>>> This flag is not used anywhere.
>> Except that blk-mq-debugfs prints it in a completely obsfucated way.
>> Sight, I'll need to fix that mess while I'm at it.
>>
> If you are going to fix this, does it makes sense to fix the rest of
> the obfuscation ? such as QUEUE_FLAGE_NAME/HCTX_FLAG_NAME/CMD_FLAG_NAME ?
>
>
>
If so, I'd like to send a patch to remove obfuscation for blk_op_name[].
Please let me know.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-03-18 1:50 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-03-17 7:21 [PATCH] block: remove RQF_ALLOCED Christoph Hellwig
2021-03-17 13:42 ` Christoph Hellwig
2021-03-18 1:18 ` Chaitanya Kulkarni
2021-03-18 1:49 ` Chaitanya Kulkarni
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.