All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] drm/amdgpu/ttm: Fix memory leak userptr pages
@ 2021-03-17 16:08 ` Daniel Gomez
  0 siblings, 0 replies; 12+ messages in thread
From: Daniel Gomez @ 2021-03-17 16:08 UTC (permalink / raw)
  Cc: dri-devel, David Airlie, Felix Kuehling, linux-kernel, amd-gfx,
	Likun Gao, dagmcr, Daniel Vetter, Alex Deucher, Dave Airlie,
	Daniel Gomez, Christian König

If userptr pages have been pinned but not bounded,
they remain uncleared.

Signed-off-by: Daniel Gomez <daniel@qtec.com>
---
 drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c
index 9fd2157b133a..50c2b4827c13 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c
@@ -1162,13 +1162,13 @@ static void amdgpu_ttm_backend_unbind(struct ttm_bo_device *bdev,
 	struct amdgpu_ttm_tt *gtt = (void *)ttm;
 	int r;
 
-	if (!gtt->bound)
-		return;
-
 	/* if the pages have userptr pinning then clear that first */
 	if (gtt->userptr)
 		amdgpu_ttm_tt_unpin_userptr(bdev, ttm);
 
+	if (!gtt->bound)
+		return;
+
 	if (gtt->offset == AMDGPU_BO_INVALID_OFFSET)
 		return;
 
-- 
2.30.2

_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

^ permalink raw reply related	[flat|nested] 12+ messages in thread

end of thread, other threads:[~2021-03-19  2:57 UTC | newest]

Thread overview: 12+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-03-17 16:08 [PATCH] drm/amdgpu/ttm: Fix memory leak userptr pages Daniel Gomez
2021-03-17 16:08 ` Daniel Gomez
2021-03-17 16:08 ` Daniel Gomez
2021-03-18  7:49 ` Christian König
2021-03-18  7:49   ` Christian König
2021-03-18  7:49   ` Christian König
2021-03-18  8:18   ` Daniel Gomez
2021-03-18  8:18     ` Daniel Gomez
2021-03-18  8:18     ` Daniel Gomez
2021-03-19  2:56 ` Alex Deucher
2021-03-19  2:56   ` Alex Deucher
2021-03-19  2:56   ` Alex Deucher

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.