Re: [PATCH 3/5] megaraid_sas: Early detection of VD deletion through RaidMap update

[kernel test robot <lkp@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 3071 bytes --]

Hi Chandrakanth,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on v5.12-rc3]
[cannot apply to mkp-scsi/for-next scsi/for-next next-20210317]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Chandrakanth-Patil/megaraid_sas-Update-driver-version-to-07-717-01-00-rc1/20210318-031205
base:    1e28eed17697bcf343c6743f0028cc3b5dd88bf0
config: arm64-defconfig (attached as .config)
compiler: aarch64-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/dadb835ed01309bcd9a8d51a01ad4467dc71aea6
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Chandrakanth-Patil/megaraid_sas-Update-driver-version-to-07-717-01-00-rc1/20210318-031205
        git checkout dadb835ed01309bcd9a8d51a01ad4467dc71aea6
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=arm64 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

>> drivers/scsi/megaraid/megaraid_sas_base.c:3502:1: warning: no previous prototype for 'megasas_set_sdev_removed_by_fw' [-Wmissing-prototypes]
    3502 | megasas_set_sdev_removed_by_fw(struct megasas_instance *instance)
         | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~


vim +/megasas_set_sdev_removed_by_fw +3502 drivers/scsi/megaraid/megaraid_sas_base.c

  3500	
  3501	void
> 3502	megasas_set_sdev_removed_by_fw(struct megasas_instance *instance)
  3503	{
  3504		struct scsi_device *sdev;
  3505		struct MR_PRIV_DEVICE *mr_device_priv_data;
  3506		uint channel, id, i;
  3507	
  3508		for (i = 0; (i < MEGASAS_MAX_LD_IDS); i++) {
  3509			if (instance->ld_ids_prev[i] != 0xff &&
  3510			    instance->ld_ids_from_raidmap[i] == 0xff) {
  3511				channel = MEGASAS_MAX_PD_CHANNELS +
  3512						(instance->ld_ids_prev[i] /
  3513						MEGASAS_MAX_DEV_PER_CHANNEL);
  3514				id = (instance->ld_ids_prev[i] %
  3515					MEGASAS_MAX_DEV_PER_CHANNEL);
  3516	
  3517				if (megasas_dbg_lvl & LD_PD_DEBUG)
  3518					dev_info(&instance->pdev->dev,
  3519						 "index %d old 0x%x new 0x%x from %s\n",
  3520						 i, instance->ld_ids_prev[i],
  3521						 instance->ld_ids_from_raidmap[i],
  3522						 __func__);
  3523	
  3524				sdev = scsi_device_lookup(instance->host, channel, id, 0);
  3525				if (sdev) {
  3526					mr_device_priv_data = sdev->hostdata;
  3527					mr_device_priv_data->device_removed_by_fw = true;
  3528					scsi_device_put(sdev);
  3529				}
  3530			}
  3531		}
  3532	}
  3533	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 53746 bytes --]