From: Marc Zyngier <maz@kernel.org>
To: kvmarm@lists.cs.columbia.edu,
linux-arm-kernel@lists.infradead.org, kvm@vger.kernel.org
Cc: kernel-team@android.com,
Catalin Marinas <catalin.marinas@arm.com>,
broonie@kernel.org, Will Deacon <will@kernel.org>,
dave.martin@arm.com, daniel.kiss@arm.com
Subject: [PATCH v2 00/11] KVM: arm64: Enable SVE support on nVHE systems
Date: Thu, 18 Mar 2021 12:25:21 +0000 [thread overview]
Message-ID: <20210318122532.505263-1-maz@kernel.org> (raw)
This series enables SVE support for KVM on nVHE hardware (or more
likely, software models), and is an alternative to Daniel's patch[1]
which has gone through 3 versions, but still has a number of issues.
Instead of waiting for things to happen, I decided to try and see what
I could come up with.
The SVE save/restore is modelled after the SVE VHE flow, itself
closely following the FPSIMD flow:
- the guest traps to EL2 on first SVE access, and will not trap
anymore until vcpu_put()
- ZCR_EL2 stays constant as long as the guest has SVE enabled
- once back on the host side, ZCR_EL2 is restored to its default value
on first SVE access
Most of this series only repaints things so that VHE and nVHE look as
similar as possible, the ZCR_EL2 management being the most visible
exception. This results in a bunch of preparatory patches that aim at
making the code slightly more readable.
This has been tested on a FVP model with both VHE/nVHE configurations
using the string tests included with the "optimized-routines"
library[2].
Patches against 5.12-rc2.
* From v1 [3]:
- Fixed __sve_save_state SYM_FUNC_END label
- Turned the ZCR_EL2 reset hypercall into a host trap
- Fixed SVE state mapping size
- Correctly mask RES0 bits from ZCR_ELx
- Introduced sve_cond_update_zcr_vq() as a ZCR_ELx update helper
- Renamed vcpu_sve_vq() to vcpu_sve_max_vq()
- Collected Acks from Will
[1] https://lore.kernel.org/r/20210302164850.3553701-1-daniel.kiss@arm.com
[2] https://github.com/ARM-software/optimized-routines
[3] https://lore.kernel.org/r/20210316101312.102925-1-maz@kernel.org
Daniel Kiss (1):
KVM: arm64: Enable SVE support for nVHE
Marc Zyngier (10):
KVM: arm64: Provide KVM's own save/restore SVE primitives
KVM: arm64: Use {read,write}_sysreg_el1 to access ZCR_EL1
KVM: arm64: Let vcpu_sve_pffr() handle HYP VAs
KVM: arm64: Introduce vcpu_sve_vq() helper
arm64: sve: Provide a conditional update accessor for ZCR_ELx
KVM: arm64: Rework SVE host-save/guest-restore
KVM: arm64: Map SVE context at EL2 when available
KVM: arm64: Save guest's ZCR_EL1 before saving the FPSIMD state
KVM: arm64: Trap host SVE accesses when the FPSIMD state is dirty
KVM: arm64: Save/restore SVE state for nVHE
arch/arm64/Kconfig | 7 ---
arch/arm64/include/asm/fpsimd.h | 9 +++
arch/arm64/include/asm/fpsimdmacros.h | 10 +++-
arch/arm64/include/asm/kvm_host.h | 21 ++-----
arch/arm64/include/asm/kvm_hyp.h | 2 +
arch/arm64/kvm/arm.c | 5 --
arch/arm64/kvm/fpsimd.c | 26 +++++++--
arch/arm64/kvm/guest.c | 6 +-
arch/arm64/kvm/hyp/fpsimd.S | 10 ++++
arch/arm64/kvm/hyp/include/hyp/switch.h | 77 ++++++++++++-------------
arch/arm64/kvm/hyp/nvhe/hyp-main.c | 4 ++
arch/arm64/kvm/hyp/nvhe/switch.c | 13 +++--
arch/arm64/kvm/reset.c | 4 --
13 files changed, 109 insertions(+), 85 deletions(-)
--
2.29.2
_______________________________________________
kvmarm mailing list
kvmarm@lists.cs.columbia.edu
https://lists.cs.columbia.edu/mailman/listinfo/kvmarm
WARNING: multiple messages have this Message-ID (diff)
From: Marc Zyngier <maz@kernel.org>
To: kvmarm@lists.cs.columbia.edu,
linux-arm-kernel@lists.infradead.org, kvm@vger.kernel.org
Cc: dave.martin@arm.com, daniel.kiss@arm.com,
Will Deacon <will@kernel.org>,
Catalin Marinas <catalin.marinas@arm.com>,
James Morse <james.morse@arm.com>,
Julien Thierry <julien.thierry.kdev@gmail.com>,
Suzuki K Poulose <suzuki.poulose@arm.com>,
broonie@kernel.org, ascull@google.com, qperret@google.com,
kernel-team@android.com
Subject: [PATCH v2 00/11] KVM: arm64: Enable SVE support on nVHE systems
Date: Thu, 18 Mar 2021 12:25:21 +0000 [thread overview]
Message-ID: <20210318122532.505263-1-maz@kernel.org> (raw)
This series enables SVE support for KVM on nVHE hardware (or more
likely, software models), and is an alternative to Daniel's patch[1]
which has gone through 3 versions, but still has a number of issues.
Instead of waiting for things to happen, I decided to try and see what
I could come up with.
The SVE save/restore is modelled after the SVE VHE flow, itself
closely following the FPSIMD flow:
- the guest traps to EL2 on first SVE access, and will not trap
anymore until vcpu_put()
- ZCR_EL2 stays constant as long as the guest has SVE enabled
- once back on the host side, ZCR_EL2 is restored to its default value
on first SVE access
Most of this series only repaints things so that VHE and nVHE look as
similar as possible, the ZCR_EL2 management being the most visible
exception. This results in a bunch of preparatory patches that aim at
making the code slightly more readable.
This has been tested on a FVP model with both VHE/nVHE configurations
using the string tests included with the "optimized-routines"
library[2].
Patches against 5.12-rc2.
* From v1 [3]:
- Fixed __sve_save_state SYM_FUNC_END label
- Turned the ZCR_EL2 reset hypercall into a host trap
- Fixed SVE state mapping size
- Correctly mask RES0 bits from ZCR_ELx
- Introduced sve_cond_update_zcr_vq() as a ZCR_ELx update helper
- Renamed vcpu_sve_vq() to vcpu_sve_max_vq()
- Collected Acks from Will
[1] https://lore.kernel.org/r/20210302164850.3553701-1-daniel.kiss@arm.com
[2] https://github.com/ARM-software/optimized-routines
[3] https://lore.kernel.org/r/20210316101312.102925-1-maz@kernel.org
Daniel Kiss (1):
KVM: arm64: Enable SVE support for nVHE
Marc Zyngier (10):
KVM: arm64: Provide KVM's own save/restore SVE primitives
KVM: arm64: Use {read,write}_sysreg_el1 to access ZCR_EL1
KVM: arm64: Let vcpu_sve_pffr() handle HYP VAs
KVM: arm64: Introduce vcpu_sve_vq() helper
arm64: sve: Provide a conditional update accessor for ZCR_ELx
KVM: arm64: Rework SVE host-save/guest-restore
KVM: arm64: Map SVE context at EL2 when available
KVM: arm64: Save guest's ZCR_EL1 before saving the FPSIMD state
KVM: arm64: Trap host SVE accesses when the FPSIMD state is dirty
KVM: arm64: Save/restore SVE state for nVHE
arch/arm64/Kconfig | 7 ---
arch/arm64/include/asm/fpsimd.h | 9 +++
arch/arm64/include/asm/fpsimdmacros.h | 10 +++-
arch/arm64/include/asm/kvm_host.h | 21 ++-----
arch/arm64/include/asm/kvm_hyp.h | 2 +
arch/arm64/kvm/arm.c | 5 --
arch/arm64/kvm/fpsimd.c | 26 +++++++--
arch/arm64/kvm/guest.c | 6 +-
arch/arm64/kvm/hyp/fpsimd.S | 10 ++++
arch/arm64/kvm/hyp/include/hyp/switch.h | 77 ++++++++++++-------------
arch/arm64/kvm/hyp/nvhe/hyp-main.c | 4 ++
arch/arm64/kvm/hyp/nvhe/switch.c | 13 +++--
arch/arm64/kvm/reset.c | 4 --
13 files changed, 109 insertions(+), 85 deletions(-)
--
2.29.2
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Marc Zyngier <maz@kernel.org>
To: kvmarm@lists.cs.columbia.edu,
linux-arm-kernel@lists.infradead.org, kvm@vger.kernel.org
Cc: dave.martin@arm.com, daniel.kiss@arm.com,
Will Deacon <will@kernel.org>,
Catalin Marinas <catalin.marinas@arm.com>,
James Morse <james.morse@arm.com>,
Julien Thierry <julien.thierry.kdev@gmail.com>,
Suzuki K Poulose <suzuki.poulose@arm.com>,
broonie@kernel.org, ascull@google.com, qperret@google.com,
kernel-team@android.com
Subject: [PATCH v2 00/11] KVM: arm64: Enable SVE support on nVHE systems
Date: Thu, 18 Mar 2021 12:25:21 +0000 [thread overview]
Message-ID: <20210318122532.505263-1-maz@kernel.org> (raw)
This series enables SVE support for KVM on nVHE hardware (or more
likely, software models), and is an alternative to Daniel's patch[1]
which has gone through 3 versions, but still has a number of issues.
Instead of waiting for things to happen, I decided to try and see what
I could come up with.
The SVE save/restore is modelled after the SVE VHE flow, itself
closely following the FPSIMD flow:
- the guest traps to EL2 on first SVE access, and will not trap
anymore until vcpu_put()
- ZCR_EL2 stays constant as long as the guest has SVE enabled
- once back on the host side, ZCR_EL2 is restored to its default value
on first SVE access
Most of this series only repaints things so that VHE and nVHE look as
similar as possible, the ZCR_EL2 management being the most visible
exception. This results in a bunch of preparatory patches that aim at
making the code slightly more readable.
This has been tested on a FVP model with both VHE/nVHE configurations
using the string tests included with the "optimized-routines"
library[2].
Patches against 5.12-rc2.
* From v1 [3]:
- Fixed __sve_save_state SYM_FUNC_END label
- Turned the ZCR_EL2 reset hypercall into a host trap
- Fixed SVE state mapping size
- Correctly mask RES0 bits from ZCR_ELx
- Introduced sve_cond_update_zcr_vq() as a ZCR_ELx update helper
- Renamed vcpu_sve_vq() to vcpu_sve_max_vq()
- Collected Acks from Will
[1] https://lore.kernel.org/r/20210302164850.3553701-1-daniel.kiss@arm.com
[2] https://github.com/ARM-software/optimized-routines
[3] https://lore.kernel.org/r/20210316101312.102925-1-maz@kernel.org
Daniel Kiss (1):
KVM: arm64: Enable SVE support for nVHE
Marc Zyngier (10):
KVM: arm64: Provide KVM's own save/restore SVE primitives
KVM: arm64: Use {read,write}_sysreg_el1 to access ZCR_EL1
KVM: arm64: Let vcpu_sve_pffr() handle HYP VAs
KVM: arm64: Introduce vcpu_sve_vq() helper
arm64: sve: Provide a conditional update accessor for ZCR_ELx
KVM: arm64: Rework SVE host-save/guest-restore
KVM: arm64: Map SVE context at EL2 when available
KVM: arm64: Save guest's ZCR_EL1 before saving the FPSIMD state
KVM: arm64: Trap host SVE accesses when the FPSIMD state is dirty
KVM: arm64: Save/restore SVE state for nVHE
arch/arm64/Kconfig | 7 ---
arch/arm64/include/asm/fpsimd.h | 9 +++
arch/arm64/include/asm/fpsimdmacros.h | 10 +++-
arch/arm64/include/asm/kvm_host.h | 21 ++-----
arch/arm64/include/asm/kvm_hyp.h | 2 +
arch/arm64/kvm/arm.c | 5 --
arch/arm64/kvm/fpsimd.c | 26 +++++++--
arch/arm64/kvm/guest.c | 6 +-
arch/arm64/kvm/hyp/fpsimd.S | 10 ++++
arch/arm64/kvm/hyp/include/hyp/switch.h | 77 ++++++++++++-------------
arch/arm64/kvm/hyp/nvhe/hyp-main.c | 4 ++
arch/arm64/kvm/hyp/nvhe/switch.c | 13 +++--
arch/arm64/kvm/reset.c | 4 --
13 files changed, 109 insertions(+), 85 deletions(-)
--
2.29.2
next reply other threads:[~2021-03-18 12:25 UTC|newest]
Thread overview: 72+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-18 12:25 Marc Zyngier [this message]
2021-03-18 12:25 ` [PATCH v2 00/11] KVM: arm64: Enable SVE support on nVHE systems Marc Zyngier
2021-03-18 12:25 ` Marc Zyngier
2021-03-18 12:25 ` [PATCH v2 01/11] KVM: arm64: Provide KVM's own save/restore SVE primitives Marc Zyngier
2021-03-18 12:25 ` Marc Zyngier
2021-03-18 12:25 ` Marc Zyngier
2021-03-18 12:25 ` [PATCH v2 02/11] KVM: arm64: Use {read, write}_sysreg_el1 to access ZCR_EL1 Marc Zyngier
2021-03-18 12:25 ` [PATCH v2 02/11] KVM: arm64: Use {read,write}_sysreg_el1 " Marc Zyngier
2021-03-18 12:25 ` [PATCH v2 02/11] KVM: arm64: Use {read, write}_sysreg_el1 " Marc Zyngier
2021-03-18 12:25 ` [PATCH v2 03/11] KVM: arm64: Let vcpu_sve_pffr() handle HYP VAs Marc Zyngier
2021-03-18 12:25 ` Marc Zyngier
2021-03-18 12:25 ` Marc Zyngier
2021-03-18 12:25 ` [PATCH v2 04/11] KVM: arm64: Introduce vcpu_sve_vq() helper Marc Zyngier
2021-03-18 12:25 ` Marc Zyngier
2021-03-18 12:25 ` Marc Zyngier
2021-03-18 12:25 ` [PATCH v2 05/11] arm64: sve: Provide a conditional update accessor for ZCR_ELx Marc Zyngier
2021-03-18 12:25 ` Marc Zyngier
2021-03-18 12:25 ` Marc Zyngier
2021-03-18 13:32 ` Will Deacon
2021-03-18 13:32 ` Will Deacon
2021-03-18 13:32 ` Will Deacon
2021-03-19 16:42 ` Mark Brown
2021-03-19 16:42 ` Mark Brown
2021-03-19 16:42 ` Mark Brown
2021-03-19 16:51 ` Marc Zyngier
2021-03-19 16:51 ` Marc Zyngier
2021-03-19 16:51 ` Marc Zyngier
2021-03-19 16:58 ` Mark Brown
2021-03-19 16:58 ` Mark Brown
2021-03-19 16:58 ` Mark Brown
2021-03-18 12:25 ` [PATCH v2 06/11] KVM: arm64: Rework SVE host-save/guest-restore Marc Zyngier
2021-03-18 12:25 ` Marc Zyngier
2021-03-18 12:25 ` Marc Zyngier
2021-03-18 13:34 ` Will Deacon
2021-03-18 13:34 ` Will Deacon
2021-03-18 13:34 ` Will Deacon
2021-03-18 12:25 ` [PATCH v2 07/11] KVM: arm64: Map SVE context at EL2 when available Marc Zyngier
2021-03-18 12:25 ` Marc Zyngier
2021-03-18 12:25 ` Marc Zyngier
2021-03-18 13:35 ` Will Deacon
2021-03-18 13:35 ` Will Deacon
2021-03-18 13:35 ` Will Deacon
2021-03-18 12:25 ` [PATCH v2 08/11] KVM: arm64: Save guest's ZCR_EL1 before saving the FPSIMD state Marc Zyngier
2021-03-18 12:25 ` Marc Zyngier
2021-03-18 12:25 ` Marc Zyngier
2021-03-18 12:25 ` [PATCH v2 09/11] KVM: arm64: Trap host SVE accesses when the FPSIMD state is dirty Marc Zyngier
2021-03-18 12:25 ` Marc Zyngier
2021-03-18 12:25 ` Marc Zyngier
2021-03-18 14:11 ` Will Deacon
2021-03-18 14:11 ` Will Deacon
2021-03-18 14:11 ` Will Deacon
2021-03-18 14:29 ` Marc Zyngier
2021-03-18 14:29 ` Marc Zyngier
2021-03-18 14:29 ` Marc Zyngier
2021-03-18 18:40 ` Marc Zyngier
2021-03-18 18:40 ` Marc Zyngier
2021-03-18 18:40 ` Marc Zyngier
2021-03-18 12:25 ` [PATCH v2 10/11] KVM: arm64: Save/restore SVE state for nVHE Marc Zyngier
2021-03-18 12:25 ` Marc Zyngier
2021-03-18 12:25 ` Marc Zyngier
2021-03-18 14:13 ` Will Deacon
2021-03-18 14:13 ` Will Deacon
2021-03-18 14:13 ` Will Deacon
2021-03-18 14:32 ` Marc Zyngier
2021-03-18 14:32 ` Marc Zyngier
2021-03-18 14:32 ` Marc Zyngier
2021-03-18 12:25 ` [PATCH v2 11/11] KVM: arm64: Enable SVE support " Marc Zyngier
2021-03-18 12:25 ` Marc Zyngier
2021-03-18 12:25 ` Marc Zyngier
2021-03-19 17:53 ` [PATCH v2 00/11] KVM: arm64: Enable SVE support on nVHE systems Mark Brown
2021-03-19 17:53 ` Mark Brown
2021-03-19 17:53 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210318122532.505263-1-maz@kernel.org \
--to=maz@kernel.org \
--cc=broonie@kernel.org \
--cc=catalin.marinas@arm.com \
--cc=daniel.kiss@arm.com \
--cc=dave.martin@arm.com \
--cc=kernel-team@android.com \
--cc=kvm@vger.kernel.org \
--cc=kvmarm@lists.cs.columbia.edu \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.