From: Phil Sutter <phil@nwl.cc>
To: Richard Guy Briggs <rgb@redhat.com>
Cc: Jones Desougi <jones.desougi+netfilter@gmail.com>,
Florian Westphal <fw@strlen.de>,
LKML <linux-kernel@vger.kernel.org>,
Linux-Audit Mailing List <linux-audit@redhat.com>,
netfilter-devel@vger.kernel.org, twoerner@redhat.com,
Eric Paris <eparis@parisplace.org>,
tgraf@infradead.org, dan.carpenter@oracle.com
Subject: Re: [PATCH] audit: log nftables configuration change events once per table
Date: Fri, 19 Mar 2021 13:52:43 +0100 [thread overview]
Message-ID: <20210319125243.GU5298@orbyte.nwl.cc> (raw)
In-Reply-To: <20210318183703.GL3141668@madcap2.tricolour.ca>
On Thu, Mar 18, 2021 at 02:37:03PM -0400, Richard Guy Briggs wrote:
> On 2021-03-18 17:30, Phil Sutter wrote:
[...]
> > Why did you leave the object-related logs in place? They should reappear
> > at commit time just like chains and sets for instance, no?
>
> There are other paths that can trigger these messages that don't go
> through nf_tables_commit() that affect the configuration data. The
> counters are considered config data for auditing purposes and the act of
> resetting them is audittable. And the only time we want to emit a
> record is when they are being reset.
Oh, I see. I wasn't aware 'nft reset' bypasses the transaction logic,
thanks for clarifying!
Cheers, Phil
--
Linux-audit mailing list
Linux-audit@redhat.com
https://listman.redhat.com/mailman/listinfo/linux-audit
WARNING: multiple messages have this Message-ID (diff)
From: Phil Sutter <phil@nwl.cc>
To: Richard Guy Briggs <rgb@redhat.com>
Cc: Linux-Audit Mailing List <linux-audit@redhat.com>,
LKML <linux-kernel@vger.kernel.org>,
netfilter-devel@vger.kernel.org, Paul Moore <paul@paul-moore.com>,
Eric Paris <eparis@parisplace.org>,
Steve Grubb <sgrubb@redhat.com>, Florian Westphal <fw@strlen.de>,
twoerner@redhat.com, tgraf@infradead.org,
dan.carpenter@oracle.com,
Jones Desougi <jones.desougi+netfilter@gmail.com>
Subject: Re: [PATCH] audit: log nftables configuration change events once per table
Date: Fri, 19 Mar 2021 13:52:43 +0100 [thread overview]
Message-ID: <20210319125243.GU5298@orbyte.nwl.cc> (raw)
In-Reply-To: <20210318183703.GL3141668@madcap2.tricolour.ca>
On Thu, Mar 18, 2021 at 02:37:03PM -0400, Richard Guy Briggs wrote:
> On 2021-03-18 17:30, Phil Sutter wrote:
[...]
> > Why did you leave the object-related logs in place? They should reappear
> > at commit time just like chains and sets for instance, no?
>
> There are other paths that can trigger these messages that don't go
> through nf_tables_commit() that affect the configuration data. The
> counters are considered config data for auditing purposes and the act of
> resetting them is audittable. And the only time we want to emit a
> record is when they are being reset.
Oh, I see. I wasn't aware 'nft reset' bypasses the transaction logic,
thanks for clarifying!
Cheers, Phil
next prev parent reply other threads:[~2021-03-19 12:58 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-18 15:39 [PATCH] audit: log nftables configuration change events once per table Richard Guy Briggs
2021-03-18 15:39 ` Richard Guy Briggs
2021-03-18 16:29 ` Pablo Neira Ayuso
2021-03-18 16:29 ` Pablo Neira Ayuso
2021-03-18 16:30 ` Phil Sutter
2021-03-18 16:30 ` Phil Sutter
2021-03-18 18:37 ` Richard Guy Briggs
2021-03-18 18:37 ` Richard Guy Briggs
2021-03-19 12:52 ` Phil Sutter [this message]
2021-03-19 12:52 ` Phil Sutter
2021-03-19 12:57 ` Richard Guy Briggs
2021-03-19 12:57 ` Richard Guy Briggs
2021-03-18 19:39 ` kernel test robot
2021-03-18 19:39 ` kernel test robot
2021-03-18 19:39 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210319125243.GU5298@orbyte.nwl.cc \
--to=phil@nwl.cc \
--cc=dan.carpenter@oracle.com \
--cc=eparis@parisplace.org \
--cc=fw@strlen.de \
--cc=jones.desougi+netfilter@gmail.com \
--cc=linux-audit@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=rgb@redhat.com \
--cc=tgraf@infradead.org \
--cc=twoerner@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.