All of lore.kernel.org
 help / color / mirror / Atom feed
From: Catalin Marinas <catalin.marinas@arm.com>
To: Lecopzer Chen <lecopzer.chen@mediatek.com>
Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org,
	kasan-dev@googlegroups.com, linux-arm-kernel@lists.infradead.org,
	will@kernel.org, dan.j.williams@intel.com,
	aryabinin@virtuozzo.com, glider@google.com, dvyukov@google.com,
	akpm@linux-foundation.org, linux-mediatek@lists.infradead.org,
	yj.chiang@mediatek.com, ardb@kernel.org, andreyknvl@google.com,
	broonie@kernel.org, linux@roeck-us.net, rppt@kernel.org,
	tyhicks@linux.microsoft.com, robin.murphy@arm.com,
	vincenzo.frascino@arm.com, gustavoars@kernel.org,
	lecopzer@gmail.com
Subject: Re: [PATCH v3 0/5] arm64: kasan: support CONFIG_KASAN_VMALLOC
Date: Fri, 19 Mar 2021 17:41:08 +0000	[thread overview]
Message-ID: <20210319174108.GD6832@arm.com> (raw)
In-Reply-To: <20210206083552.24394-1-lecopzer.chen@mediatek.com>

Hi Lecopzer,

On Sat, Feb 06, 2021 at 04:35:47PM +0800, Lecopzer Chen wrote:
> Linux supports KAsan for VMALLOC since commit 3c5c3cfb9ef4da9
> ("kasan: support backing vmalloc space with real shadow memory")
> 
> Acroding to how x86 ported it [1], they early allocated p4d and pgd,
> but in arm64 I just simulate how KAsan supports MODULES_VADDR in arm64
> by not to populate the vmalloc area except for kimg address.

Do you plan an update to a newer kernel like 5.12-rc3?

> Signed-off-by: Lecopzer Chen <lecopzer.chen@mediatek.com>
> Acked-by: Andrey Konovalov <andreyknvl@google.com>
> Tested-by: Andrey Konovalov <andreyknvl@google.com>
> Tested-by: Ard Biesheuvel <ardb@kernel.org>

You could move these to individual patches rather than the cover letter,
assuming that they still stand after the changes you've made. Also note
that Andrey K no longer has the @google.com email address if you cc him
on future patches (replace it with @gmail.com).

Thanks.

-- 
Catalin

_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek

WARNING: multiple messages have this Message-ID (diff)
From: Catalin Marinas <catalin.marinas@arm.com>
To: Lecopzer Chen <lecopzer.chen@mediatek.com>
Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org,
	kasan-dev@googlegroups.com, linux-arm-kernel@lists.infradead.org,
	will@kernel.org, dan.j.williams@intel.com,
	aryabinin@virtuozzo.com, glider@google.com, dvyukov@google.com,
	akpm@linux-foundation.org, linux-mediatek@lists.infradead.org,
	yj.chiang@mediatek.com, ardb@kernel.org, andreyknvl@google.com,
	broonie@kernel.org, linux@roeck-us.net, rppt@kernel.org,
	tyhicks@linux.microsoft.com, robin.murphy@arm.com,
	vincenzo.frascino@arm.com, gustavoars@kernel.org,
	lecopzer@gmail.com
Subject: Re: [PATCH v3 0/5] arm64: kasan: support CONFIG_KASAN_VMALLOC
Date: Fri, 19 Mar 2021 17:41:08 +0000	[thread overview]
Message-ID: <20210319174108.GD6832@arm.com> (raw)
In-Reply-To: <20210206083552.24394-1-lecopzer.chen@mediatek.com>

Hi Lecopzer,

On Sat, Feb 06, 2021 at 04:35:47PM +0800, Lecopzer Chen wrote:
> Linux supports KAsan for VMALLOC since commit 3c5c3cfb9ef4da9
> ("kasan: support backing vmalloc space with real shadow memory")
> 
> Acroding to how x86 ported it [1], they early allocated p4d and pgd,
> but in arm64 I just simulate how KAsan supports MODULES_VADDR in arm64
> by not to populate the vmalloc area except for kimg address.

Do you plan an update to a newer kernel like 5.12-rc3?

> Signed-off-by: Lecopzer Chen <lecopzer.chen@mediatek.com>
> Acked-by: Andrey Konovalov <andreyknvl@google.com>
> Tested-by: Andrey Konovalov <andreyknvl@google.com>
> Tested-by: Ard Biesheuvel <ardb@kernel.org>

You could move these to individual patches rather than the cover letter,
assuming that they still stand after the changes you've made. Also note
that Andrey K no longer has the @google.com email address if you cc him
on future patches (replace it with @gmail.com).

Thanks.

-- 
Catalin

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

WARNING: multiple messages have this Message-ID (diff)
From: Catalin Marinas <catalin.marinas@arm.com>
To: Lecopzer Chen <lecopzer.chen@mediatek.com>
Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org,
	kasan-dev@googlegroups.com, linux-arm-kernel@lists.infradead.org,
	will@kernel.org, dan.j.williams@intel.com,
	aryabinin@virtuozzo.com, glider@google.com, dvyukov@google.com,
	akpm@linux-foundation.org, linux-mediatek@lists.infradead.org,
	yj.chiang@mediatek.com, ardb@kernel.org, andreyknvl@google.com,
	broonie@kernel.org, linux@roeck-us.net, rppt@kernel.org,
	tyhicks@linux.microsoft.com, robin.murphy@arm.com,
	vincenzo.frascino@arm.com, gustavoars@kernel.org,
	lecopzer@gmail.com
Subject: Re: [PATCH v3 0/5] arm64: kasan: support CONFIG_KASAN_VMALLOC
Date: Fri, 19 Mar 2021 17:41:08 +0000	[thread overview]
Message-ID: <20210319174108.GD6832@arm.com> (raw)
In-Reply-To: <20210206083552.24394-1-lecopzer.chen@mediatek.com>

Hi Lecopzer,

On Sat, Feb 06, 2021 at 04:35:47PM +0800, Lecopzer Chen wrote:
> Linux supports KAsan for VMALLOC since commit 3c5c3cfb9ef4da9
> ("kasan: support backing vmalloc space with real shadow memory")
> 
> Acroding to how x86 ported it [1], they early allocated p4d and pgd,
> but in arm64 I just simulate how KAsan supports MODULES_VADDR in arm64
> by not to populate the vmalloc area except for kimg address.

Do you plan an update to a newer kernel like 5.12-rc3?

> Signed-off-by: Lecopzer Chen <lecopzer.chen@mediatek.com>
> Acked-by: Andrey Konovalov <andreyknvl@google.com>
> Tested-by: Andrey Konovalov <andreyknvl@google.com>
> Tested-by: Ard Biesheuvel <ardb@kernel.org>

You could move these to individual patches rather than the cover letter,
assuming that they still stand after the changes you've made. Also note
that Andrey K no longer has the @google.com email address if you cc him
on future patches (replace it with @gmail.com).

Thanks.

-- 
Catalin


  parent reply	other threads:[~2021-03-19 17:41 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-06  8:35 [PATCH v3 0/5] arm64: kasan: support CONFIG_KASAN_VMALLOC Lecopzer Chen
2021-02-06  8:35 ` Lecopzer Chen
2021-02-06  8:35 ` Lecopzer Chen
2021-02-06  8:35 ` [PATCH v3 1/5] arm64: kasan: don't populate vmalloc area for CONFIG_KASAN_VMALLOC Lecopzer Chen
2021-02-06  8:35   ` Lecopzer Chen
2021-02-06  8:35   ` Lecopzer Chen
2021-03-19 17:37   ` Catalin Marinas
2021-03-19 17:37     ` Catalin Marinas
2021-03-19 17:37     ` Catalin Marinas
2021-03-20 13:01     ` Lecopzer Chen
2021-03-20 13:01       ` Lecopzer Chen
2021-03-20 13:01       ` Lecopzer Chen
2021-02-06  8:35 ` [PATCH v3 2/5] arm64: kasan: abstract _text and _end to KERNEL_START/END Lecopzer Chen
2021-02-06  8:35   ` Lecopzer Chen
2021-02-06  8:35   ` Lecopzer Chen
2021-02-06  8:35 ` [PATCH v3 3/5] arm64: Kconfig: support CONFIG_KASAN_VMALLOC Lecopzer Chen
2021-02-06  8:35   ` Lecopzer Chen
2021-02-06  8:35   ` Lecopzer Chen
2021-02-06  8:35 ` [PATCH v3 4/5] arm64: kaslr: support randomized module area with KASAN_VMALLOC Lecopzer Chen
2021-02-06  8:35   ` Lecopzer Chen
2021-02-06  8:35   ` Lecopzer Chen
2021-02-06  8:35 ` [PATCH v3 5/5] arm64: Kconfig: select KASAN_VMALLOC if KANSAN_GENERIC is enabled Lecopzer Chen
2021-02-06  8:35   ` Lecopzer Chen
2021-02-06  8:35   ` Lecopzer Chen
2021-03-19 17:41 ` Catalin Marinas [this message]
2021-03-19 17:41   ` [PATCH v3 0/5] arm64: kasan: support CONFIG_KASAN_VMALLOC Catalin Marinas
2021-03-19 17:41   ` Catalin Marinas
2021-03-20 10:58   ` Lecopzer Chen
2021-03-20 10:58     ` Lecopzer Chen
2021-03-20 10:58     ` Lecopzer Chen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210319174108.GD6832@arm.com \
    --to=catalin.marinas@arm.com \
    --cc=akpm@linux-foundation.org \
    --cc=andreyknvl@google.com \
    --cc=ardb@kernel.org \
    --cc=aryabinin@virtuozzo.com \
    --cc=broonie@kernel.org \
    --cc=dan.j.williams@intel.com \
    --cc=dvyukov@google.com \
    --cc=glider@google.com \
    --cc=gustavoars@kernel.org \
    --cc=kasan-dev@googlegroups.com \
    --cc=lecopzer.chen@mediatek.com \
    --cc=lecopzer@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=linux-mm@kvack.org \
    --cc=linux@roeck-us.net \
    --cc=robin.murphy@arm.com \
    --cc=rppt@kernel.org \
    --cc=tyhicks@linux.microsoft.com \
    --cc=vincenzo.frascino@arm.com \
    --cc=will@kernel.org \
    --cc=yj.chiang@mediatek.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.