[Buildroot] [PATCH v2] package/transmission: fix sysv init script (name vs. exec)

[Buildroot] [PATCH v2] package/transmission: fix sysv init script (name vs. exec)

[Peter Seiderer]

- fix sysv init script in case package start-stop-daemon is
  enabled

Fixes:

  - https://bugs.busybox.net/show_bug.cgi?id=13576

  $ /etc/init.d/S92transmission stop
  Stopping bittorrent client transmission-daemon...
  start-stop-daemon: warning: this system is not able to track process names
  longer than 15 characters, please use --exec instead of --name.

Reported-by: ingineru_de_sistem at yahoo.com
Signed-off-by: Peter Seiderer <ps.report@gmx.net>
---
Changes v1 -> v2:
  - add reported-by and reference to bug entry
---
 package/transmission/S92transmission | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/package/transmission/S92transmission b/package/transmission/S92transmission
index 29d7cd5863..85ff40ec16 100644
--- a/package/transmission/S92transmission
+++ b/package/transmission/S92transmission
@@ -93,7 +93,7 @@ stop()
         #   1 if daemon was already stopped
         #   2 if daemon could not be stopped
         #   other if a failure occurred
-        start-stop-daemon --stop --quiet --retry=TERM/10/KILL/5 --pidfile $PIDFILE --name $NAME
+        start-stop-daemon --stop --quiet --retry=TERM/10/KILL/5 --pidfile $PIDFILE --exec $DAEMON
         RETVAL="$?"
         [ "$RETVAL" = 2 ] && return 2
 
-- 
2.30.1

[Buildroot] [PATCH v2] package/transmission: fix sysv init script (name vs. exec)

[Yann E. MORIN]

Peter, All,

On 2021-03-10 23:41 +0100, Peter Seiderer spake thusly:
> - fix sysv init script in case package start-stop-daemon is
>   enabled
> 
> Fixes:
> 
>   - https://bugs.busybox.net/show_bug.cgi?id=13576
> 
>   $ /etc/init.d/S92transmission stop
>   Stopping bittorrent client transmission-daemon...
>   start-stop-daemon: warning: this system is not able to track process names
>   longer than 15 characters, please use --exec instead of --name.
> 
> Reported-by: ingineru_de_sistem at yahoo.com
> Signed-off-by: Peter Seiderer <ps.report@gmx.net>

Applied to master, after rewordign the commit log to also include the
referecnes to upstream changes. Thanks.

Regards,
Yann E. MORIN.

> ---
> Changes v1 -> v2:
>   - add reported-by and reference to bug entry
> ---
>  package/transmission/S92transmission | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/package/transmission/S92transmission b/package/transmission/S92transmission
> index 29d7cd5863..85ff40ec16 100644
> --- a/package/transmission/S92transmission
> +++ b/package/transmission/S92transmission
> @@ -93,7 +93,7 @@ stop()
>          #   1 if daemon was already stopped
>          #   2 if daemon could not be stopped
>          #   other if a failure occurred
> -        start-stop-daemon --stop --quiet --retry=TERM/10/KILL/5 --pidfile $PIDFILE --name $NAME
> +        start-stop-daemon --stop --quiet --retry=TERM/10/KILL/5 --pidfile $PIDFILE --exec $DAEMON
>          RETVAL="$?"
>          [ "$RETVAL" = 2 ] && return 2
>  
> -- 
> 2.30.1
> 
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

[Buildroot] [PATCH v2] package/transmission: fix sysv init script (name vs. exec)

[Peter Korsgaard]

>>>>> "Peter" == Peter Seiderer <ps.report@gmx.net> writes:

 > - fix sysv init script in case package start-stop-daemon is
 >   enabled

 > Fixes:

 >   - https://bugs.busybox.net/show_bug.cgi?id=13576

 >   $ /etc/init.d/S92transmission stop
 >   Stopping bittorrent client transmission-daemon...
 >   start-stop-daemon: warning: this system is not able to track process names
 >   longer than 15 characters, please use --exec instead of --name.

 > Reported-by: ingineru_de_sistem at yahoo.com
 > Signed-off-by: Peter Seiderer <ps.report@gmx.net>
 > ---
 > Changes v1 -> v2:
 >   - add reported-by and reference to bug entry

Committed to 2020.02.x, 2020.11.x and 2021.02.x, thanks.

grepping the source tree, it looks like we have a similar issue in
rng-tools:

git grep 'start-stop-daemon.*-K.*-n'
package/rng-tools/S21rngd:      if start-stop-daemon -K -q -s KILL -p "${PID_FILE}" -n "${NAME}"; then

Care to send a fix for that as well?

-- 
Bye, Peter Korsgaard

[Buildroot] [PATCH v2] package/transmission: fix sysv init script (name vs. exec)

[Peter Seiderer]

Hello Peter,

On Fri, 19 Mar 2021 23:04:56 +0100, Peter Korsgaard <peter@korsgaard.com> wrote:

> >>>>> "Peter" == Peter Seiderer <ps.report@gmx.net> writes:
>
>  > - fix sysv init script in case package start-stop-daemon is
>  >   enabled
>
>  > Fixes:
>
>  >   - https://bugs.busybox.net/show_bug.cgi?id=13576
>
>  >   $ /etc/init.d/S92transmission stop
>  >   Stopping bittorrent client transmission-daemon...
>  >   start-stop-daemon: warning: this system is not able to track process names
>  >   longer than 15 characters, please use --exec instead of --name.
>
>  > Reported-by: ingineru_de_sistem at yahoo.com
>  > Signed-off-by: Peter Seiderer <ps.report@gmx.net>
>  > ---
>  > Changes v1 -> v2:
>  >   - add reported-by and reference to bug entry
>
> Committed to 2020.02.x, 2020.11.x and 2021.02.x, thanks.
>
> grepping the source tree, it looks like we have a similar issue in
> rng-tools:
>
> git grep 'start-stop-daemon.*-K.*-n'
> package/rng-tools/S21rngd:      if start-stop-daemon -K -q -s KILL -p "${PID_FILE}" -n "${NAME}"; then

Did not catch it because I grep'ed only for the long version...

>
> Care to send a fix for that as well?
>

Rngd is not affected as the NAME ('rngd') is below the 15 characters limit...,
should I change to exec anyway?

Regards,
Peter