From: Nicolas Saenz Julienne <nsaenz@kernel.org>
To: linux-arm-kernel@lists.infradead.org, linux-mmc@vger.kernel.org,
devicetree@vger.kernel.org,
bcm-kernel-feedback-list@broadcom.com,
linux-rpi-kernel@lists.infradead.org,
Saenz Julienne <nsaenz@kernel.org>
Cc: f.fainelli@gmail.com, phil@raspberrypi.com,
tim.gover@raspberrypi.com, adrian.hunter@intel.com,
sbranden@broadcom.com, alcooperx@gmail.com,
nsaenzjulienne@suse.de, linux-kernel@vger.kernel.org,
ulf.hansson@linaro.org
Subject: [PATCH 0/4] BCM2711's sdhci-iproc CMD timeouts
Date: Mon, 22 Mar 2021 19:58:13 +0100 [thread overview]
Message-ID: <20210322185816.27582-1-nsaenz@kernel.org> (raw)
This series tries to address rather odd behavior from BCM2711's
integration of sdhci-iproc (Raspberry Pi 4's SoC). The controller will
timeout on SDHCI CMDs under the following conditions:
- No SD card plugged in (the card polling thread is running, CD irq disabled).
- BCM2711's VPU clock configured at 500MHz or more, lower clocks are OK.
There is no specific command that will time out, it seems random.
I found out that by bumping the controller's frequency to 150MHz the
issue disapears. So let's do that.
Regards,
Nicolas
---
Nicolas Saenz Julienne (4):
dt-bindings: mmc: iproc-sdhci: Convert to json-schema
dt-bindings: mmc: iproc-sdhci: Add clock-frequency support
mmc: sdhci-iproc: Set clock frequency as per DT
ARM: dts: Fix-up EMMC2 controller's frequency
.../bindings/mmc/brcm,iproc-sdhci.yaml | 64 +++++++++++++++++++
.../bindings/mmc/brcm,sdhci-iproc.txt | 37 -----------
arch/arm/boot/dts/bcm2711-rpi-4-b.dts | 6 ++
drivers/mmc/host/sdhci-iproc.c | 10 +++
4 files changed, 80 insertions(+), 37 deletions(-)
create mode 100644 Documentation/devicetree/bindings/mmc/brcm,iproc-sdhci.yaml
delete mode 100644 Documentation/devicetree/bindings/mmc/brcm,sdhci-iproc.txt
--
2.30.2
WARNING: multiple messages have this Message-ID (diff)
From: Nicolas Saenz Julienne <nsaenz@kernel.org>
To: linux-arm-kernel@lists.infradead.org, linux-mmc@vger.kernel.org,
devicetree@vger.kernel.org,
bcm-kernel-feedback-list@broadcom.com,
linux-rpi-kernel@lists.infradead.org,
Saenz Julienne <nsaenz@kernel.org>
Cc: f.fainelli@gmail.com, phil@raspberrypi.com,
tim.gover@raspberrypi.com, adrian.hunter@intel.com,
sbranden@broadcom.com, alcooperx@gmail.com,
nsaenzjulienne@suse.de, linux-kernel@vger.kernel.org,
ulf.hansson@linaro.org
Subject: [PATCH 0/4] BCM2711's sdhci-iproc CMD timeouts
Date: Mon, 22 Mar 2021 19:58:13 +0100 [thread overview]
Message-ID: <20210322185816.27582-1-nsaenz@kernel.org> (raw)
This series tries to address rather odd behavior from BCM2711's
integration of sdhci-iproc (Raspberry Pi 4's SoC). The controller will
timeout on SDHCI CMDs under the following conditions:
- No SD card plugged in (the card polling thread is running, CD irq disabled).
- BCM2711's VPU clock configured at 500MHz or more, lower clocks are OK.
There is no specific command that will time out, it seems random.
I found out that by bumping the controller's frequency to 150MHz the
issue disapears. So let's do that.
Regards,
Nicolas
---
Nicolas Saenz Julienne (4):
dt-bindings: mmc: iproc-sdhci: Convert to json-schema
dt-bindings: mmc: iproc-sdhci: Add clock-frequency support
mmc: sdhci-iproc: Set clock frequency as per DT
ARM: dts: Fix-up EMMC2 controller's frequency
.../bindings/mmc/brcm,iproc-sdhci.yaml | 64 +++++++++++++++++++
.../bindings/mmc/brcm,sdhci-iproc.txt | 37 -----------
arch/arm/boot/dts/bcm2711-rpi-4-b.dts | 6 ++
drivers/mmc/host/sdhci-iproc.c | 10 +++
4 files changed, 80 insertions(+), 37 deletions(-)
create mode 100644 Documentation/devicetree/bindings/mmc/brcm,iproc-sdhci.yaml
delete mode 100644 Documentation/devicetree/bindings/mmc/brcm,sdhci-iproc.txt
--
2.30.2
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next reply other threads:[~2021-03-22 18:59 UTC|newest]
Thread overview: 55+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-22 18:58 Nicolas Saenz Julienne [this message]
2021-03-22 18:58 ` [PATCH 0/4] BCM2711's sdhci-iproc CMD timeouts Nicolas Saenz Julienne
2021-03-22 18:58 ` [PATCH 1/4] dt-bindings: mmc: iproc-sdhci: Convert to json-schema Nicolas Saenz Julienne
2021-03-22 18:58 ` Nicolas Saenz Julienne
2021-03-22 19:11 ` Scott Branden
2021-03-22 19:11 ` Scott Branden
2021-03-22 19:16 ` Nicolas Saenz Julienne
2021-03-22 19:16 ` Nicolas Saenz Julienne
2021-03-23 21:08 ` Rob Herring
2021-03-23 21:08 ` Rob Herring
2021-03-23 21:24 ` Nicolas Saenz Julienne
2021-03-23 21:24 ` Nicolas Saenz Julienne
2021-03-24 16:27 ` Scott Branden
2021-03-24 16:27 ` Scott Branden
2021-03-24 16:35 ` Nicolas Saenz Julienne
2021-03-24 16:35 ` Nicolas Saenz Julienne
2021-03-24 16:43 ` Scott Branden
2021-03-24 16:43 ` Scott Branden
2021-03-24 16:43 ` Scott Branden
2021-03-23 20:16 ` Rob Herring
2021-03-23 20:16 ` Rob Herring
2021-03-22 18:58 ` [PATCH 2/4] dt-bindings: mmc: iproc-sdhci: Add clock-frequency support Nicolas Saenz Julienne
2021-03-22 18:58 ` Nicolas Saenz Julienne
2021-03-27 17:14 ` Rob Herring
2021-03-27 17:14 ` Rob Herring
2021-03-22 18:58 ` [PATCH 3/4] mmc: sdhci-iproc: Set clock frequency as per DT Nicolas Saenz Julienne
2021-03-22 18:58 ` Nicolas Saenz Julienne
2021-03-22 18:58 ` [PATCH 4/4] ARM: dts: Fix-up EMMC2 controller's frequency Nicolas Saenz Julienne
2021-03-22 18:58 ` Nicolas Saenz Julienne
2021-03-22 19:06 ` Scott Branden
2021-03-22 19:06 ` Scott Branden
2021-03-22 19:17 ` Nicolas Saenz Julienne
2021-03-22 19:17 ` Nicolas Saenz Julienne
2021-03-24 15:16 ` Stefan Wahren
2021-03-24 15:16 ` Stefan Wahren
2021-03-24 15:34 ` Nicolas Saenz Julienne
2021-03-24 15:34 ` Nicolas Saenz Julienne
2021-03-25 19:11 ` Stefan Wahren
2021-03-25 19:11 ` Stefan Wahren
2021-03-26 16:17 ` Nicolas Saenz Julienne
2021-03-26 16:17 ` Nicolas Saenz Julienne
2021-03-26 16:42 ` Stefan Wahren
2021-03-26 16:42 ` Stefan Wahren
2021-04-01 15:23 ` Alan Cooper
2021-04-01 15:23 ` Alan Cooper
2021-04-05 8:45 ` Nicolas Saenz Julienne
2021-04-05 8:45 ` Nicolas Saenz Julienne
2021-04-07 20:37 ` Alan Cooper
2021-04-07 20:37 ` Alan Cooper
2021-04-09 9:28 ` Nicolas Saenz Julienne
2021-04-09 9:28 ` Nicolas Saenz Julienne
2021-04-09 10:54 ` Nicolas Saenz Julienne
2021-04-09 10:54 ` Nicolas Saenz Julienne
2021-04-09 18:28 ` Stefan Wahren
2021-04-09 18:28 ` Stefan Wahren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210322185816.27582-1-nsaenz@kernel.org \
--to=nsaenz@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=alcooperx@gmail.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=devicetree@vger.kernel.org \
--cc=f.fainelli@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-rpi-kernel@lists.infradead.org \
--cc=nsaenzjulienne@suse.de \
--cc=phil@raspberrypi.com \
--cc=sbranden@broadcom.com \
--cc=tim.gover@raspberrypi.com \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.