* [PATCH v2] thermal/core: avoid memory leak
@ 2021-03-22 19:18 Muhammad Usama Anjum
0 siblings, 0 replies; only message in thread
From: Muhammad Usama Anjum @ 2021-03-22 19:18 UTC (permalink / raw)
To: Zhang Rui, Daniel Lezcano, Amit Kucheria
Cc: musamaanjum, linux-kernel, linux-pm, kernel-janitors, colin.king,
dan.carpenter
When memory allocation for cdev is successful but ida_simple_get fails,
branch to out_kfree_cdev label happens and cdev isn't freed. There are
also some other cases in which the memory can leak. Fix it by freeing cdev.
Signed-off-by: Muhammad Usama Anjum <musamaanjum@gmail.com>
---
Fix description
drivers/thermal/thermal_core.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/thermal/thermal_core.c b/drivers/thermal/thermal_core.c
index c8d4010940ef..3566fd291399 100644
--- a/drivers/thermal/thermal_core.c
+++ b/drivers/thermal/thermal_core.c
@@ -1017,6 +1017,7 @@ __thermal_cooling_device_register(struct device_node *np,
out_ida_remove:
ida_simple_remove(&thermal_cdev_ida, cdev->id);
out_kfree_cdev:
+ kfree(cdev);
return ERR_PTR(ret);
}
--
2.25.1
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2021-03-22 19:19 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-03-22 19:18 [PATCH v2] thermal/core: avoid memory leak Muhammad Usama Anjum
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.