All of lore.kernel.org
 help / color / mirror / Atom feed
From: Rob Herring <robh@kernel.org>
To: Michael Walle <michael@walle.cc>
Cc: Pratyush Yadav <p.yadav@ti.com>,
	Kuldeep Singh <kuldeep.singh@nxp.com>,
	linux-spi@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org, Mark Brown <broonie@kernel.org>,
	Vladimir Oltean <olteanv@gmail.com>,
	linux-mtd@lists.infradead.org
Subject: Re: [PATCH] dt-bindings: spi: Convert Freescale DSPI to json schema
Date: Wed, 24 Mar 2021 11:51:49 -0600	[thread overview]
Message-ID: <20210324175149.GA3320002@robh.at.kernel.org> (raw)
In-Reply-To: <97410b24785492f9e80999dd7a1ffdea@walle.cc>

On Tue, Mar 16, 2021 at 07:22:56PM +0100, Michael Walle wrote:
> Am 2021-03-16 19:06, schrieb Pratyush Yadav:
> > On 16/03/21 06:45PM, Michael Walle wrote:
> > > Am 2021-03-15 19:30, schrieb Pratyush Yadav:
> > > 
> > > ..
> > > > > +patternProperties:
> > > > > +  "@[0-9a-f]+":
> > > 
> > > Shouldn't this be "^.*@[0-9a-f]+$"?
> > 
> > The pattern has to match _anywhere_ in the string so both should match
> > the flash node. Your pattern is more "strict" or "precise". See the note
> > at [0].
> 
> I know, but specifying the whole line is widely used in the bindings.

It should be '@[0-9a-f]+$' which is equivalent to Michael's suggestion.

Rob

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/

WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robh@kernel.org>
To: Michael Walle <michael@walle.cc>
Cc: Pratyush Yadav <p.yadav@ti.com>,
	Kuldeep Singh <kuldeep.singh@nxp.com>,
	linux-spi@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org, Mark Brown <broonie@kernel.org>,
	Vladimir Oltean <olteanv@gmail.com>,
	linux-mtd@lists.infradead.org
Subject: Re: [PATCH] dt-bindings: spi: Convert Freescale DSPI to json schema
Date: Wed, 24 Mar 2021 11:51:49 -0600	[thread overview]
Message-ID: <20210324175149.GA3320002@robh.at.kernel.org> (raw)
In-Reply-To: <97410b24785492f9e80999dd7a1ffdea@walle.cc>

On Tue, Mar 16, 2021 at 07:22:56PM +0100, Michael Walle wrote:
> Am 2021-03-16 19:06, schrieb Pratyush Yadav:
> > On 16/03/21 06:45PM, Michael Walle wrote:
> > > Am 2021-03-15 19:30, schrieb Pratyush Yadav:
> > > 
> > > ..
> > > > > +patternProperties:
> > > > > +  "@[0-9a-f]+":
> > > 
> > > Shouldn't this be "^.*@[0-9a-f]+$"?
> > 
> > The pattern has to match _anywhere_ in the string so both should match
> > the flash node. Your pattern is more "strict" or "precise". See the note
> > at [0].
> 
> I know, but specifying the whole line is widely used in the bindings.

It should be '@[0-9a-f]+$' which is equivalent to Michael's suggestion.

Rob

  reply	other threads:[~2021-03-24 17:52 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-15 12:15 [PATCH] dt-bindings: spi: Convert Freescale DSPI to json schema Kuldeep Singh
2021-03-15 18:30 ` Pratyush Yadav
2021-03-15 18:30   ` Pratyush Yadav
2021-03-16  5:56   ` [EXT] " Kuldeep Singh
2021-03-16  5:56     ` Kuldeep Singh
2021-03-16 17:45   ` Michael Walle
2021-03-16 17:45     ` Michael Walle
2021-03-16 18:06     ` Pratyush Yadav
2021-03-16 18:06       ` Pratyush Yadav
2021-03-16 18:22       ` Michael Walle
2021-03-16 18:22         ` Michael Walle
2021-03-24 17:51         ` Rob Herring [this message]
2021-03-24 17:51           ` Rob Herring
2021-03-22 13:20   ` Pratyush Yadav
2021-03-22 13:20     ` Pratyush Yadav
2021-03-24 18:10   ` Rob Herring
2021-03-24 18:10     ` Rob Herring
2021-03-15 20:54 ` Vladimir Oltean
2021-03-16  6:08   ` [EXT] " Kuldeep Singh
2021-03-16 10:15     ` Vladimir Oltean
2021-03-24 18:14       ` Rob Herring
2021-03-24 18:53         ` Vladimir Oltean
2021-03-24 19:20           ` Rob Herring
2021-03-25  1:06             ` Vladimir Oltean
2021-03-24 18:18 ` Rob Herring

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210324175149.GA3320002@robh.at.kernel.org \
    --to=robh@kernel.org \
    --cc=broonie@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=kuldeep.singh@nxp.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=linux-spi@vger.kernel.org \
    --cc=michael@walle.cc \
    --cc=olteanv@gmail.com \
    --cc=p.yadav@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.