From: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>
To: Tyler Retzlaff <roretzla@linux.microsoft.com>
Cc: Thomas Monjalon <thomas@monjalon.net>,
dev@dpdk.org, david.marchand@redhat.com,
bruce.richardson@intel.com, stephen@networkplumber.org,
drc@linux.vnet.ibm.com
Subject: Re: [dpdk-dev] [PATCH] eal: standard c++ forbids defining the keyword asm as a macro
Date: Thu, 25 Mar 2021 01:41:47 +0300 [thread overview]
Message-ID: <20210325014147.2a2f5749@sovereign> (raw)
In-Reply-To: <20210324215548.GA2272@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net>
2021-03-24 14:55 (UTC-0700), Tyler Retzlaff:
> On Wed, Mar 24, 2021 at 06:52:40PM +0100, Thomas Monjalon wrote:
> > 24/03/2021 18:28, Tyler Retzlaff:
[...]
> > > would you prefer that i change the preprocessor protection to include only
> > > windows? since i'm certain that this will break for any c++ compiler on
> > > windows the moment any stl header is included.
> >
> > No, C++ is probably the right scope.
> >
> > I don't know yet. I would like to understand the global picture,
> > and have it properly documented in this commit log.
>
> yep, no problem. i suspect we are probably the only ones using c++ and
> dpdk (though others can speak up if they do too) which may be why this
> has gone unnoticed until now.
You're certainly not the only one:
* Seastar is a C++ userspace TCP/IP stack, ScyllaDB is based on it.
* Click modular router can use DPDK from C++ [1].
* DPDK-based product out company works on is in C++.
Can't speak for Seastar and Click, but we never hit this particular issue.
What is the minimal complete example to reproduce?
[1]:
https://github.com/kohler/click/blob/master/elements/userlevel/fromdpdkdevice.cc
next prev parent reply other threads:[~2021-03-24 22:41 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-24 4:26 [dpdk-dev] [PATCH] eal: standard c++ forbids defining the keyword asm as a macro Tyler Retzlaff
2021-03-24 8:30 ` Thomas Monjalon
2021-03-24 16:45 ` Tyler Retzlaff
2021-03-24 17:04 ` Thomas Monjalon
2021-03-24 17:28 ` Tyler Retzlaff
2021-03-24 17:52 ` Thomas Monjalon
2021-03-24 19:52 ` Stephen Hemminger
2021-03-24 21:58 ` Tyler Retzlaff
2021-03-24 21:55 ` Tyler Retzlaff
2021-03-24 22:41 ` Dmitry Kozlyuk [this message]
2021-03-25 0:09 ` Tyler Retzlaff
2021-03-25 8:00 ` Thomas Monjalon
2021-03-25 18:50 ` Tyler Retzlaff
2021-04-13 13:10 ` Thomas Monjalon
2021-04-13 13:35 ` Thomas Monjalon
2021-04-17 1:16 ` Tyler Retzlaff
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210325014147.2a2f5749@sovereign \
--to=dmitry.kozliuk@gmail.com \
--cc=bruce.richardson@intel.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=drc@linux.vnet.ibm.com \
--cc=roretzla@linux.microsoft.com \
--cc=stephen@networkplumber.org \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.