From: Thomas Monjalon <thomas@monjalon.net>
To: Tyler Retzlaff <roretzla@linux.microsoft.com>
Cc: dev@dpdk.org, david.marchand@redhat.com,
bruce.richardson@intel.com, stephen@networkplumber.org,
drc@linux.vnet.ibm.com
Subject: Re: [dpdk-dev] [PATCH] eal: standard c++ forbids defining the keyword asm as a macro
Date: Tue, 13 Apr 2021 15:35:53 +0200 [thread overview]
Message-ID: <3365684.9AJlD7vKmA@thomas> (raw)
In-Reply-To: <1616560011-31647-1-git-send-email-roretzla@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net>
24/03/2021 05:26, Tyler Retzlaff:
> --- a/lib/librte_eal/include/rte_common.h
> +++ b/lib/librte_eal/include/rte_common.h
> @@ -31,9 +31,11 @@ extern "C" {
> #define typeof __typeof__
> #endif
>
> +#ifndef __cplusplus
> #ifndef asm
> #define asm __asm__
> #endif
> +#endif
Applied with this explanation:
eal: do not redefine asm keyword in C++
C++ forbids redefining a keyword as a macro.
The keyword asm is conditionally-supported and implementation defined,
but it seems our best guess.
In C, if asm does not exist, it is defined as __asm__
which is a GNU extension.
One more question:
Can we have a similar issue with typeof?
I guess it works because typeof is not a keyword?
next prev parent reply other threads:[~2021-04-13 13:36 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-24 4:26 [dpdk-dev] [PATCH] eal: standard c++ forbids defining the keyword asm as a macro Tyler Retzlaff
2021-03-24 8:30 ` Thomas Monjalon
2021-03-24 16:45 ` Tyler Retzlaff
2021-03-24 17:04 ` Thomas Monjalon
2021-03-24 17:28 ` Tyler Retzlaff
2021-03-24 17:52 ` Thomas Monjalon
2021-03-24 19:52 ` Stephen Hemminger
2021-03-24 21:58 ` Tyler Retzlaff
2021-03-24 21:55 ` Tyler Retzlaff
2021-03-24 22:41 ` Dmitry Kozlyuk
2021-03-25 0:09 ` Tyler Retzlaff
2021-03-25 8:00 ` Thomas Monjalon
2021-03-25 18:50 ` Tyler Retzlaff
2021-04-13 13:10 ` Thomas Monjalon
2021-04-13 13:35 ` Thomas Monjalon [this message]
2021-04-17 1:16 ` Tyler Retzlaff
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3365684.9AJlD7vKmA@thomas \
--to=thomas@monjalon.net \
--cc=bruce.richardson@intel.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=drc@linux.vnet.ibm.com \
--cc=roretzla@linux.microsoft.com \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.