Re: [PATCH v2 1/8] ALSA: hda: Re-add dropped snd_poewr_change_state()

[kernel test robot <lkp@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 3471 bytes --]

Hi Takashi,

I love your patch! Yet something to improve:

[auto build test ERROR on v5.12-rc4]
[also build test ERROR on next-20210324]
[cannot apply to sound/for-next]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Takashi-Iwai/ALSA-hda-Re-add-dropped-snd_poewr_change_state/20210325-043958
base:    0d02ec6b3136c73c09e7859f0d0e4e2c4c07b49b
config: m68k-allmodconfig (attached as .config)
compiler: m68k-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/9d72f7bfcc53f9e360ceba244596818bb00f1f7d
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Takashi-Iwai/ALSA-hda-Re-add-dropped-snd_poewr_change_state/20210325-043958
        git checkout 9d72f7bfcc53f9e360ceba244596818bb00f1f7d
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=m68k 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

   In file included from sound/core/control.c:16:
   sound/core/control.c: In function 'snd_ctl_elem_read':
>> include/sound/core.h:176:43: error: expected expression before 'do'
     176 | #define snd_power_wait_and_ref(card, ref) do { (void)(card); } while (0)
         |                                           ^~
   sound/core/control.c:1060:8: note: in expansion of macro 'snd_power_wait_and_ref'
    1060 |  ret = snd_power_wait_and_ref(card, true);
         |        ^~~~~~~~~~~~~~~~~~~~~~
   sound/core/control.c: In function 'snd_ctl_elem_write':
>> include/sound/core.h:176:43: error: expected expression before 'do'
     176 | #define snd_power_wait_and_ref(card, ref) do { (void)(card); } while (0)
         |                                           ^~
   sound/core/control.c:1126:11: note: in expansion of macro 'snd_power_wait_and_ref'
    1126 |  result = snd_power_wait_and_ref(card, true);
         |           ^~~~~~~~~~~~~~~~~~~~~~
   sound/core/control.c: In function 'call_tlv_handler':
>> include/sound/core.h:176:43: error: expected expression before 'do'
     176 | #define snd_power_wait_and_ref(card, ref) do { (void)(card); } while (0)
         |                                           ^~
   sound/core/control.c:1629:8: note: in expansion of macro 'snd_power_wait_and_ref'
    1629 |  ret = snd_power_wait_and_ref(file->card, true);
         |        ^~~~~~~~~~~~~~~~~~~~~~


vim +/do +176 include/sound/core.h

   172	
   173	static inline int snd_power_wait(struct snd_card *card, unsigned int state) { return 0; }
   174	#define snd_power_get_state(card)	({ (void)(card); SNDRV_CTL_POWER_D0; })
   175	#define snd_power_change_state(card, state)	do { (void)(card); } while (0)
 > 176	#define snd_power_wait_and_ref(card, ref)	do { (void)(card); } while (0)
   177	#define snd_power_ref(card)		do { (void)(card); } while (0)
   178	#define snd_power_unref(card)		do { (void)(card); } while (0)
   179	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 59864 bytes --]