All of lore.kernel.org
 help / color / mirror / Atom feed
* [rgushchin:pageblocks.rfc 1/1] mm/page_alloc.c:561:6: warning: no previous prototype for 'init_pageblock_migratetype'
@ 2021-03-26  6:39 kernel test robot
  0 siblings, 0 replies; only message in thread
From: kernel test robot @ 2021-03-26  6:39 UTC (permalink / raw)
  To: kbuild-all

[-- Attachment #1: Type: text/plain, Size: 10872 bytes --]

tree:   https://github.com/rgushchin/linux.git pageblocks.rfc
head:   a8332c741ea7062e373883a72ce12daf8b951a8e
commit: a8332c741ea7062e373883a72ce12daf8b951a8e [1/1] mm: page_alloc: introduce pageblocks stats
config: m68k-allmodconfig (attached as .config)
compiler: m68k-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/rgushchin/linux/commit/a8332c741ea7062e373883a72ce12daf8b951a8e
        git remote add rgushchin https://github.com/rgushchin/linux.git
        git fetch --no-tags rgushchin pageblocks.rfc
        git checkout a8332c741ea7062e373883a72ce12daf8b951a8e
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=m68k 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

   In file included from include/asm-generic/bug.h:5,
                    from arch/m68k/include/asm/bug.h:32,
                    from include/linux/bug.h:5,
                    from include/linux/mmdebug.h:5,
                    from include/linux/mm.h:9,
                    from mm/page_alloc.c:19:
   include/linux/scatterlist.h: In function 'sg_set_buf':
   arch/m68k/include/asm/page_mm.h:174:49: warning: ordered comparison of pointer with null pointer [-Wextra]
     174 | #define virt_addr_valid(kaddr) ((void *)(kaddr) >= (void *)PAGE_OFFSET && (void *)(kaddr) < high_memory)
         |                                                 ^~
   include/linux/compiler.h:78:42: note: in definition of macro 'unlikely'
      78 | # define unlikely(x) __builtin_expect(!!(x), 0)
         |                                          ^
   include/linux/scatterlist.h:137:2: note: in expansion of macro 'BUG_ON'
     137 |  BUG_ON(!virt_addr_valid(buf));
         |  ^~~~~~
   include/linux/scatterlist.h:137:10: note: in expansion of macro 'virt_addr_valid'
     137 |  BUG_ON(!virt_addr_valid(buf));
         |          ^~~~~~~~~~~~~~~
   In file included from arch/m68k/include/asm/page.h:60,
                    from arch/m68k/include/asm/thread_info.h:6,
                    from include/linux/thread_info.h:58,
                    from include/asm-generic/preempt.h:5,
                    from ./arch/m68k/include/generated/asm/preempt.h:1,
                    from include/linux/preempt.h:78,
                    from include/linux/spinlock.h:51,
                    from include/linux/mmzone.h:8,
                    from include/linux/gfp.h:6,
                    from include/linux/mm.h:10,
                    from mm/page_alloc.c:19:
   mm/internal.h: In function 'mem_map_next':
   arch/m68k/include/asm/page_mm.h:174:49: warning: ordered comparison of pointer with null pointer [-Wextra]
     174 | #define virt_addr_valid(kaddr) ((void *)(kaddr) >= (void *)PAGE_OFFSET && (void *)(kaddr) < high_memory)
         |                                                 ^~
   arch/m68k/include/asm/page_mm.h:175:25: note: in expansion of macro 'virt_addr_valid'
     175 | #define pfn_valid(pfn)  virt_addr_valid(pfn_to_virt(pfn))
         |                         ^~~~~~~~~~~~~~~
   mm/internal.h:459:8: note: in expansion of macro 'pfn_valid'
     459 |   if (!pfn_valid(pfn))
         |        ^~~~~~~~~
   mm/page_alloc.c: At top level:
>> mm/page_alloc.c:561:6: warning: no previous prototype for 'init_pageblock_migratetype' [-Wmissing-prototypes]
     561 | void init_pageblock_migratetype(struct page *page, int migratetype)
         |      ^~~~~~~~~~~~~~~~~~~~~~~~~~
   In file included from arch/m68k/include/asm/page.h:60,
                    from arch/m68k/include/asm/thread_info.h:6,
                    from include/linux/thread_info.h:58,
                    from include/asm-generic/preempt.h:5,
                    from ./arch/m68k/include/generated/asm/preempt.h:1,
                    from include/linux/preempt.h:78,
                    from include/linux/spinlock.h:51,
                    from include/linux/mmzone.h:8,
                    from include/linux/gfp.h:6,
                    from include/linux/mm.h:10,
                    from mm/page_alloc.c:19:
   mm/page_alloc.c: In function 'reserve_bootmem_region':
   arch/m68k/include/asm/page_mm.h:174:49: warning: ordered comparison of pointer with null pointer [-Wextra]
     174 | #define virt_addr_valid(kaddr) ((void *)(kaddr) >= (void *)PAGE_OFFSET && (void *)(kaddr) < high_memory)
         |                                                 ^~
   arch/m68k/include/asm/page_mm.h:175:25: note: in expansion of macro 'virt_addr_valid'
     175 | #define pfn_valid(pfn)  virt_addr_valid(pfn_to_virt(pfn))
         |                         ^~~~~~~~~~~~~~~
   mm/page_alloc.c:1540:7: note: in expansion of macro 'pfn_valid'
    1540 |   if (pfn_valid(start_pfn)) {
         |       ^~~~~~~~~
   mm/page_alloc.c: In function '__pageblock_pfn_to_page':
   arch/m68k/include/asm/page_mm.h:174:49: warning: ordered comparison of pointer with null pointer [-Wextra]
     174 | #define virt_addr_valid(kaddr) ((void *)(kaddr) >= (void *)PAGE_OFFSET && (void *)(kaddr) < high_memory)
         |                                                 ^~
   arch/m68k/include/asm/page_mm.h:175:25: note: in expansion of macro 'virt_addr_valid'
     175 | #define pfn_valid(pfn)  virt_addr_valid(pfn_to_virt(pfn))
         |                         ^~~~~~~~~~~~~~~
   mm/page_alloc.c:1691:7: note: in expansion of macro 'pfn_valid'
    1691 |  if (!pfn_valid(start_pfn) || !pfn_valid(end_pfn))
         |       ^~~~~~~~~
   arch/m68k/include/asm/page_mm.h:174:49: warning: ordered comparison of pointer with null pointer [-Wextra]
     174 | #define virt_addr_valid(kaddr) ((void *)(kaddr) >= (void *)PAGE_OFFSET && (void *)(kaddr) < high_memory)
         |                                                 ^~
   arch/m68k/include/asm/page_mm.h:175:25: note: in expansion of macro 'virt_addr_valid'
     175 | #define pfn_valid(pfn)  virt_addr_valid(pfn_to_virt(pfn))
         |                         ^~~~~~~~~~~~~~~
   mm/page_alloc.c:1691:32: note: in expansion of macro 'pfn_valid'
    1691 |  if (!pfn_valid(start_pfn) || !pfn_valid(end_pfn))
         |                                ^~~~~~~~~
   arch/m68k/include/asm/page_mm.h:174:49: warning: ordered comparison of pointer with null pointer [-Wextra]
     174 | #define virt_addr_valid(kaddr) ((void *)(kaddr) >= (void *)PAGE_OFFSET && (void *)(kaddr) < high_memory)
         |                                                 ^~
   arch/m68k/include/asm/page_mm.h:175:25: note: in expansion of macro 'virt_addr_valid'
     175 | #define pfn_valid(pfn)  virt_addr_valid(pfn_to_virt(pfn))
         |                         ^~~~~~~~~~~~~~~
   include/linux/memory_hotplug.h:246:6: note: in expansion of macro 'pfn_valid'
     246 |  if (pfn_valid(pfn))   \
         |      ^~~~~~~~~
   mm/page_alloc.c:1694:15: note: in expansion of macro 'pfn_to_online_page'
    1694 |  start_page = pfn_to_online_page(start_pfn);
         |               ^~~~~~~~~~~~~~~~~~
   mm/page_alloc.c: At top level:
   mm/page_alloc.c:3628:15: warning: no previous prototype for 'should_fail_alloc_page' [-Wmissing-prototypes]
    3628 | noinline bool should_fail_alloc_page(gfp_t gfp_mask, unsigned int order)
         |               ^~~~~~~~~~~~~~~~~~~~~~
   In file included from include/asm-generic/bug.h:5,
                    from arch/m68k/include/asm/bug.h:32,
                    from include/linux/bug.h:5,
                    from include/linux/mmdebug.h:5,
                    from include/linux/mm.h:9,
                    from mm/page_alloc.c:19:
   mm/page_alloc.c: In function 'free_pages':
   arch/m68k/include/asm/page_mm.h:174:49: warning: ordered comparison of pointer with null pointer [-Wextra]
     174 | #define virt_addr_valid(kaddr) ((void *)(kaddr) >= (void *)PAGE_OFFSET && (void *)(kaddr) < high_memory)
         |                                                 ^~
   include/linux/compiler.h:78:42: note: in definition of macro 'unlikely'
      78 | # define unlikely(x) __builtin_expect(!!(x), 0)
         |                                          ^
   include/linux/mmdebug.h:18:25: note: in expansion of macro 'BUG_ON'
      18 | #define VM_BUG_ON(cond) BUG_ON(cond)
         |                         ^~~~~~
   mm/page_alloc.c:5121:3: note: in expansion of macro 'VM_BUG_ON'
    5121 |   VM_BUG_ON(!virt_addr_valid((void *)addr));
         |   ^~~~~~~~~
   mm/page_alloc.c:5121:14: note: in expansion of macro 'virt_addr_valid'
    5121 |   VM_BUG_ON(!virt_addr_valid((void *)addr));
         |              ^~~~~~~~~~~~~~~
   mm/page_alloc.c: At top level:
   mm/page_alloc.c:6289:23: warning: no previous prototype for 'memmap_init' [-Wmissing-prototypes]
    6289 | void __meminit __weak memmap_init(unsigned long size, int nid,
         |                       ^~~~~~~~~~~
   In file included from arch/m68k/include/asm/page.h:60,
                    from arch/m68k/include/asm/thread_info.h:6,
                    from include/linux/thread_info.h:58,
                    from include/asm-generic/preempt.h:5,
                    from ./arch/m68k/include/generated/asm/preempt.h:1,
                    from include/linux/preempt.h:78,
                    from include/linux/spinlock.h:51,
                    from include/linux/mmzone.h:8,
                    from include/linux/gfp.h:6,
                    from include/linux/mm.h:10,
                    from mm/page_alloc.c:19:
   mm/page_alloc.c: In function 'pfn_range_valid_contig':
   arch/m68k/include/asm/page_mm.h:174:49: warning: ordered comparison of pointer with null pointer [-Wextra]
     174 | #define virt_addr_valid(kaddr) ((void *)(kaddr) >= (void *)PAGE_OFFSET && (void *)(kaddr) < high_memory)
         |                                                 ^~
   arch/m68k/include/asm/page_mm.h:175:25: note: in expansion of macro 'virt_addr_valid'


vim +/init_pageblock_migratetype +561 mm/page_alloc.c

   560	
 > 561	void init_pageblock_migratetype(struct page *page, int migratetype)
   562	{
   563		if (unlikely(page_group_by_mobility_disabled &&
   564			     migratetype < MIGRATE_PCPTYPES))
   565			migratetype = MIGRATE_UNMOVABLE;
   566	
   567		set_pfnblock_flags_mask(page, (unsigned long)migratetype,
   568					page_to_pfn(page), MIGRATETYPE_MASK);
   569		pageblock_stats[migratetype]++;
   570	}
   571	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 59595 bytes --]

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2021-03-26  6:39 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-03-26  6:39 [rgushchin:pageblocks.rfc 1/1] mm/page_alloc.c:561:6: warning: no previous prototype for 'init_pageblock_migratetype' kernel test robot

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.