From: Catalin Marinas <catalin.marinas@arm.com>
To: Masahiro Yamada <masahiroy@kernel.org>
Cc: linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Nathan Chancellor <nathan@kernel.org>,
Will Deacon <will@kernel.org>
Subject: Re: [PATCH] arm64: move --fix-cortex-a53-843419 linker test to Kconfig
Date: Sun, 28 Mar 2021 12:12:15 +0100 [thread overview]
Message-ID: <20210328111213.GA17535@arm.com> (raw)
In-Reply-To: <CAK7LNATGo1NkcRF7qo1wF1w3jrOpTQPJf1XPryUz13L8OpaSxA@mail.gmail.com>
On Sun, Mar 28, 2021 at 03:59:29PM +0900, Masahiro Yamada wrote:
> On Fri, Mar 26, 2021 at 11:36 PM Catalin Marinas
> <catalin.marinas@arm.com> wrote:
> > On Wed, Mar 24, 2021 at 04:11:28PM +0900, Masahiro Yamada wrote:
> > > $(call ld-option, --fix-cortex-a53-843419) in arch/arm64/Makefile is
> > > evaluated every time even for Make targets that do not need the linker,
> > > such as "make ARCH=arm64 install".
> > >
> > > Recently, the Kbuild tree queued up a patch to avoid needless
> > > compiler/linker flag evaluation. I beleive it is a good improvement
> > > itself, but causing a false-positive warning for arm64 installation
> > > in linux-next. (Thanks to Nathan for the report)
> > >
> > > Kconfig can test the linker capability just once, and store it in the
> > > .config file. The build and installation steps that follow do not need
> > > to test the liniker over again.
> > >
> > > Reported-by: Nathan Chancellor <nathan@kernel.org>
> > > Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
> > > ---
> > >
> > > I was not sure what the preferred CONFIG option name is.
> > > Please suggest a one if you have a better idea.
> > >
> > >
> > > arch/arm64/Kconfig | 3 +++
> > > arch/arm64/Makefile | 2 +-
> > > 2 files changed, 4 insertions(+), 1 deletion(-)
> >
> > Would you like this patch to go in via the arm64 tree or you will queue
> > it via the kbuild tree?
>
> I applied this to linux-kbuild with Will's Ack.
Great, I'll cross it off my list. Thanks.
--
Catalin
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Catalin Marinas <catalin.marinas@arm.com>
To: Masahiro Yamada <masahiroy@kernel.org>
Cc: linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Nathan Chancellor <nathan@kernel.org>,
Will Deacon <will@kernel.org>
Subject: Re: [PATCH] arm64: move --fix-cortex-a53-843419 linker test to Kconfig
Date: Sun, 28 Mar 2021 12:12:15 +0100 [thread overview]
Message-ID: <20210328111213.GA17535@arm.com> (raw)
In-Reply-To: <CAK7LNATGo1NkcRF7qo1wF1w3jrOpTQPJf1XPryUz13L8OpaSxA@mail.gmail.com>
On Sun, Mar 28, 2021 at 03:59:29PM +0900, Masahiro Yamada wrote:
> On Fri, Mar 26, 2021 at 11:36 PM Catalin Marinas
> <catalin.marinas@arm.com> wrote:
> > On Wed, Mar 24, 2021 at 04:11:28PM +0900, Masahiro Yamada wrote:
> > > $(call ld-option, --fix-cortex-a53-843419) in arch/arm64/Makefile is
> > > evaluated every time even for Make targets that do not need the linker,
> > > such as "make ARCH=arm64 install".
> > >
> > > Recently, the Kbuild tree queued up a patch to avoid needless
> > > compiler/linker flag evaluation. I beleive it is a good improvement
> > > itself, but causing a false-positive warning for arm64 installation
> > > in linux-next. (Thanks to Nathan for the report)
> > >
> > > Kconfig can test the linker capability just once, and store it in the
> > > .config file. The build and installation steps that follow do not need
> > > to test the liniker over again.
> > >
> > > Reported-by: Nathan Chancellor <nathan@kernel.org>
> > > Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
> > > ---
> > >
> > > I was not sure what the preferred CONFIG option name is.
> > > Please suggest a one if you have a better idea.
> > >
> > >
> > > arch/arm64/Kconfig | 3 +++
> > > arch/arm64/Makefile | 2 +-
> > > 2 files changed, 4 insertions(+), 1 deletion(-)
> >
> > Would you like this patch to go in via the arm64 tree or you will queue
> > it via the kbuild tree?
>
> I applied this to linux-kbuild with Will's Ack.
Great, I'll cross it off my list. Thanks.
--
Catalin
next prev parent reply other threads:[~2021-03-29 18:08 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-24 7:11 [PATCH] arm64: move --fix-cortex-a53-843419 linker test to Kconfig Masahiro Yamada
2021-03-24 7:11 ` Masahiro Yamada
2021-03-24 16:46 ` Will Deacon
2021-03-24 16:46 ` Will Deacon
2021-03-24 17:41 ` Nathan Chancellor
2021-03-24 17:41 ` Nathan Chancellor
2021-03-26 14:36 ` Catalin Marinas
2021-03-26 14:36 ` Catalin Marinas
2021-03-28 6:59 ` Masahiro Yamada
2021-03-28 6:59 ` Masahiro Yamada
2021-03-28 11:12 ` Catalin Marinas [this message]
2021-03-28 11:12 ` Catalin Marinas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210328111213.GA17535@arm.com \
--to=catalin.marinas@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=masahiroy@kernel.org \
--cc=nathan@kernel.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.