From: David Teigland <teigland@redhat.com>
To: cluster-devel.redhat.com
Subject: [Cluster-devel] [PATCH -next] fs: dlm: fix missing unlock on error in accept_from_sock()
Date: Mon, 29 Mar 2021 13:30:15 -0500 [thread overview]
Message-ID: <20210329183015.GE3080@redhat.com> (raw)
In-Reply-To: <20210327083704.1092954-1-yangyingliang@huawei.com>
On Sat, Mar 27, 2021 at 04:37:04PM +0800, Yang Yingliang wrote:
> Add the missing unlock before return from accept_from_sock()
> in the error handling case.
Thanks, applied to the next branch.
Dave
> Fixes: 6cde210a9758 ("fs: dlm: add helper for init connection")
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
> ---
> fs/dlm/lowcomms.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/fs/dlm/lowcomms.c b/fs/dlm/lowcomms.c
> index 73cc1809050a..166e36fcf3e4 100644
> --- a/fs/dlm/lowcomms.c
> +++ b/fs/dlm/lowcomms.c
> @@ -931,6 +931,7 @@ static int accept_from_sock(struct listen_connection *con)
> result = dlm_con_init(othercon, nodeid);
> if (result < 0) {
> kfree(othercon);
> + mutex_unlock(&newcon->sock_mutex);
> goto accept_err;
> }
>
> --
> 2.25.1
WARNING: multiple messages have this Message-ID (diff)
From: David Teigland <teigland@redhat.com>
To: Yang Yingliang <yangyingliang@huawei.com>
Cc: linux-kernel@vger.kernel.org, cluster-devel@redhat.com
Subject: Re: [PATCH -next] fs: dlm: fix missing unlock on error in accept_from_sock()
Date: Mon, 29 Mar 2021 13:30:15 -0500 [thread overview]
Message-ID: <20210329183015.GE3080@redhat.com> (raw)
In-Reply-To: <20210327083704.1092954-1-yangyingliang@huawei.com>
On Sat, Mar 27, 2021 at 04:37:04PM +0800, Yang Yingliang wrote:
> Add the missing unlock before return from accept_from_sock()
> in the error handling case.
Thanks, applied to the next branch.
Dave
> Fixes: 6cde210a9758 ("fs: dlm: add helper for init connection")
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
> ---
> fs/dlm/lowcomms.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/fs/dlm/lowcomms.c b/fs/dlm/lowcomms.c
> index 73cc1809050a..166e36fcf3e4 100644
> --- a/fs/dlm/lowcomms.c
> +++ b/fs/dlm/lowcomms.c
> @@ -931,6 +931,7 @@ static int accept_from_sock(struct listen_connection *con)
> result = dlm_con_init(othercon, nodeid);
> if (result < 0) {
> kfree(othercon);
> + mutex_unlock(&newcon->sock_mutex);
> goto accept_err;
> }
>
> --
> 2.25.1
next prev parent reply other threads:[~2021-03-29 18:30 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-27 8:37 [Cluster-devel] [PATCH -next] fs: dlm: fix missing unlock on error in accept_from_sock() Yang Yingliang
2021-03-27 8:37 ` Yang Yingliang
2021-03-29 18:30 ` David Teigland [this message]
2021-03-29 18:30 ` David Teigland
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210329183015.GE3080@redhat.com \
--to=teigland@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.