All of lore.kernel.org
 help / color / mirror / Atom feed
From: kernel test robot <lkp@intel.com>
To: Aditya Srivastava <yashsri421@gmail.com>, corbet@lwn.net
Cc: kbuild-all@lists.01.org, yashsri421@gmail.com,
	lukas.bulwahn@gmail.com,
	linux-kernel-mentees@lists.linuxfoundation.org,
	linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] scripts: kernel-doc: add warning for comment not following kernel-doc syntax
Date: Mon, 29 Mar 2021 22:57:39 +0800	[thread overview]
Message-ID: <202103292258.KnIhfejx-lkp@intel.com> (raw)
In-Reply-To: <20210329092945.13152-1-yashsri421@gmail.com>

[-- Attachment #1: Type: text/plain, Size: 3364 bytes --]

Hi Aditya,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on lwn/docs-next]
[also build test WARNING on linus/master v5.12-rc5 next-20210329]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Aditya-Srivastava/scripts-kernel-doc-add-warning-for-comment-not-following-kernel-doc-syntax/20210329-173213
base:   git://git.lwn.net/linux-2.6 docs-next
config: csky-randconfig-r023-20210329 (attached as .config)
compiler: csky-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/274a7b0af9aa2846ed0a5b2096e07fe76e47fe29
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Aditya-Srivastava/scripts-kernel-doc-add-warning-for-comment-not-following-kernel-doc-syntax/20210329-173213
        git checkout 274a7b0af9aa2846ed0a5b2096e07fe76e47fe29
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=csky 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

   drivers/scsi/pm8001/pm8001_ctl.c:313: warning: expecting prototype for pm8001_ctl_sas_address_show(). Prototype was for pm8001_ctl_host_sas_address_show() instead
   drivers/scsi/pm8001/pm8001_ctl.c:530: warning: expecting prototype for pm8001_ctl_aap_log_show(). Prototype was for pm8001_ctl_iop_log_show() instead
>> drivers/scsi/pm8001/pm8001_ctl.c:559: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst
    ** pm8001_ctl_fatal_log_show - fatal error logging
   drivers/scsi/pm8001/pm8001_ctl.c:579: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst
    ** non_fatal_log_show - non fatal error logging
   drivers/scsi/pm8001/pm8001_ctl.c:624: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst
    ** pm8001_ctl_gsm_log_show - gsm dump collection


vim +559 drivers/scsi/pm8001/pm8001_ctl.c

dbf9bfe615717d jack wang             2009-10-14  557  
d078b5117f18dc Anand Kumar Santhanam 2013-09-04  558  /**
d078b5117f18dc Anand Kumar Santhanam 2013-09-04 @559   ** pm8001_ctl_fatal_log_show - fatal error logging
d078b5117f18dc Anand Kumar Santhanam 2013-09-04  560   ** @cdev:pointer to embedded class device
e1c3e0f8a2ae15 Lee Jones             2020-07-13  561   ** @attr: device attribute
d078b5117f18dc Anand Kumar Santhanam 2013-09-04  562   ** @buf: the buffer returned
d078b5117f18dc Anand Kumar Santhanam 2013-09-04  563   **
d078b5117f18dc Anand Kumar Santhanam 2013-09-04  564   ** A sysfs 'read-only' shost attribute.
d078b5117f18dc Anand Kumar Santhanam 2013-09-04  565   **/
d078b5117f18dc Anand Kumar Santhanam 2013-09-04  566  

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 26329 bytes --]

WARNING: multiple messages have this Message-ID (diff)
From: kernel test robot <lkp@intel.com>
To: Aditya Srivastava <yashsri421@gmail.com>, corbet@lwn.net
Cc: kbuild-all@lists.01.org, linux-doc@vger.kernel.org,
	yashsri421@gmail.com, linux-kernel@vger.kernel.org,
	linux-kernel-mentees@lists.linuxfoundation.org
Subject: Re: [PATCH] scripts: kernel-doc: add warning for comment not following kernel-doc syntax
Date: Mon, 29 Mar 2021 22:57:39 +0800	[thread overview]
Message-ID: <202103292258.KnIhfejx-lkp@intel.com> (raw)
In-Reply-To: <20210329092945.13152-1-yashsri421@gmail.com>

[-- Attachment #1: Type: text/plain, Size: 3364 bytes --]

Hi Aditya,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on lwn/docs-next]
[also build test WARNING on linus/master v5.12-rc5 next-20210329]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Aditya-Srivastava/scripts-kernel-doc-add-warning-for-comment-not-following-kernel-doc-syntax/20210329-173213
base:   git://git.lwn.net/linux-2.6 docs-next
config: csky-randconfig-r023-20210329 (attached as .config)
compiler: csky-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/274a7b0af9aa2846ed0a5b2096e07fe76e47fe29
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Aditya-Srivastava/scripts-kernel-doc-add-warning-for-comment-not-following-kernel-doc-syntax/20210329-173213
        git checkout 274a7b0af9aa2846ed0a5b2096e07fe76e47fe29
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=csky 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

   drivers/scsi/pm8001/pm8001_ctl.c:313: warning: expecting prototype for pm8001_ctl_sas_address_show(). Prototype was for pm8001_ctl_host_sas_address_show() instead
   drivers/scsi/pm8001/pm8001_ctl.c:530: warning: expecting prototype for pm8001_ctl_aap_log_show(). Prototype was for pm8001_ctl_iop_log_show() instead
>> drivers/scsi/pm8001/pm8001_ctl.c:559: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst
    ** pm8001_ctl_fatal_log_show - fatal error logging
   drivers/scsi/pm8001/pm8001_ctl.c:579: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst
    ** non_fatal_log_show - non fatal error logging
   drivers/scsi/pm8001/pm8001_ctl.c:624: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst
    ** pm8001_ctl_gsm_log_show - gsm dump collection


vim +559 drivers/scsi/pm8001/pm8001_ctl.c

dbf9bfe615717d jack wang             2009-10-14  557  
d078b5117f18dc Anand Kumar Santhanam 2013-09-04  558  /**
d078b5117f18dc Anand Kumar Santhanam 2013-09-04 @559   ** pm8001_ctl_fatal_log_show - fatal error logging
d078b5117f18dc Anand Kumar Santhanam 2013-09-04  560   ** @cdev:pointer to embedded class device
e1c3e0f8a2ae15 Lee Jones             2020-07-13  561   ** @attr: device attribute
d078b5117f18dc Anand Kumar Santhanam 2013-09-04  562   ** @buf: the buffer returned
d078b5117f18dc Anand Kumar Santhanam 2013-09-04  563   **
d078b5117f18dc Anand Kumar Santhanam 2013-09-04  564   ** A sysfs 'read-only' shost attribute.
d078b5117f18dc Anand Kumar Santhanam 2013-09-04  565   **/
d078b5117f18dc Anand Kumar Santhanam 2013-09-04  566  

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 26329 bytes --]

[-- Attachment #3: Type: text/plain, Size: 201 bytes --]

_______________________________________________
Linux-kernel-mentees mailing list
Linux-kernel-mentees@lists.linuxfoundation.org
https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees

WARNING: multiple messages have this Message-ID (diff)
From: kernel test robot <lkp@intel.com>
To: kbuild-all@lists.01.org
Subject: Re: [PATCH] scripts: kernel-doc: add warning for comment not following kernel-doc syntax
Date: Mon, 29 Mar 2021 22:57:39 +0800	[thread overview]
Message-ID: <202103292258.KnIhfejx-lkp@intel.com> (raw)
In-Reply-To: <20210329092945.13152-1-yashsri421@gmail.com>

[-- Attachment #1: Type: text/plain, Size: 3421 bytes --]

Hi Aditya,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on lwn/docs-next]
[also build test WARNING on linus/master v5.12-rc5 next-20210329]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Aditya-Srivastava/scripts-kernel-doc-add-warning-for-comment-not-following-kernel-doc-syntax/20210329-173213
base:   git://git.lwn.net/linux-2.6 docs-next
config: csky-randconfig-r023-20210329 (attached as .config)
compiler: csky-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/274a7b0af9aa2846ed0a5b2096e07fe76e47fe29
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Aditya-Srivastava/scripts-kernel-doc-add-warning-for-comment-not-following-kernel-doc-syntax/20210329-173213
        git checkout 274a7b0af9aa2846ed0a5b2096e07fe76e47fe29
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=csky 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

   drivers/scsi/pm8001/pm8001_ctl.c:313: warning: expecting prototype for pm8001_ctl_sas_address_show(). Prototype was for pm8001_ctl_host_sas_address_show() instead
   drivers/scsi/pm8001/pm8001_ctl.c:530: warning: expecting prototype for pm8001_ctl_aap_log_show(). Prototype was for pm8001_ctl_iop_log_show() instead
>> drivers/scsi/pm8001/pm8001_ctl.c:559: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst
    ** pm8001_ctl_fatal_log_show - fatal error logging
   drivers/scsi/pm8001/pm8001_ctl.c:579: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst
    ** non_fatal_log_show - non fatal error logging
   drivers/scsi/pm8001/pm8001_ctl.c:624: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst
    ** pm8001_ctl_gsm_log_show - gsm dump collection


vim +559 drivers/scsi/pm8001/pm8001_ctl.c

dbf9bfe615717d jack wang             2009-10-14  557  
d078b5117f18dc Anand Kumar Santhanam 2013-09-04  558  /**
d078b5117f18dc Anand Kumar Santhanam 2013-09-04 @559   ** pm8001_ctl_fatal_log_show - fatal error logging
d078b5117f18dc Anand Kumar Santhanam 2013-09-04  560   ** @cdev:pointer to embedded class device
e1c3e0f8a2ae15 Lee Jones             2020-07-13  561   ** @attr: device attribute
d078b5117f18dc Anand Kumar Santhanam 2013-09-04  562   ** @buf: the buffer returned
d078b5117f18dc Anand Kumar Santhanam 2013-09-04  563   **
d078b5117f18dc Anand Kumar Santhanam 2013-09-04  564   ** A sysfs 'read-only' shost attribute.
d078b5117f18dc Anand Kumar Santhanam 2013-09-04  565   **/
d078b5117f18dc Anand Kumar Santhanam 2013-09-04  566  

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 26329 bytes --]

  parent reply	other threads:[~2021-03-29 14:59 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-29  9:29 [PATCH] scripts: kernel-doc: add warning for comment not following kernel-doc syntax Aditya Srivastava
2021-03-29  9:29 ` Aditya Srivastava
2021-03-29 12:49 ` kernel test robot
2021-03-29 12:49   ` kernel test robot
2021-03-29 12:49   ` kernel test robot
2021-03-29 13:56 ` Jonathan Corbet
2021-03-29 13:56   ` Jonathan Corbet
2021-03-29 15:10   ` Aditya Srivastava
2021-03-29 15:10     ` Aditya Srivastava
2021-03-31 19:32     ` Jonathan Corbet
2021-03-31 19:32       ` Jonathan Corbet
2021-04-03 12:43       ` Aditya Srivastava
2021-04-03 12:43         ` Aditya Srivastava
2021-03-29 14:57 ` kernel test robot [this message]
2021-03-29 14:57   ` kernel test robot
2021-03-29 14:57   ` kernel test robot
2021-05-24 13:26 ` Lee Jones

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202103292258.KnIhfejx-lkp@intel.com \
    --to=lkp@intel.com \
    --cc=corbet@lwn.net \
    --cc=kbuild-all@lists.01.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel-mentees@lists.linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lukas.bulwahn@gmail.com \
    --cc=yashsri421@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.