From: Heiko Thiery <heiko.thiery@gmail.com>
To: op-tee@lists.trustedfirmware.org
Subject: Re: [PATCH] tee: optee: fix build error caused by recent optee tracepoints feature
Date: Tue, 30 Mar 2021 08:53:42 +0200 [thread overview]
Message-ID: <20210330065341.18074-1-heiko.thiery@gmail.com> (raw)
In-Reply-To: <20210325120601.71584253@xhacker.debian>
[-- Attachment #1: Type: text/plain, Size: 1374 bytes --]
> If build kernel without "O=dir", below error will be seen:
>
> In file included from drivers/tee/optee/optee_trace.h:67,
> from drivers/tee/optee/call.c:18:
> ./include/trace/define_trace.h:95:42: fatal error: ./optee_trace.h: No such file or directory
> 95 | #include TRACE_INCLUDE(TRACE_INCLUDE_FILE)
> | ^
> compilation terminated.
>
> Fix it by adding below line to Makefile:
> CFLAGS_call.o := -I$(src)
>
> Tested with and without "O=dir", both can build successfully.
>
> Reported-by: Guenter Roeck <linux@roeck-us.net>
> Suggested-by: Steven Rostedt <rostedt@goodmis.org>
> Signed-off-by: Jisheng Zhang <Jisheng.Zhang@synaptics.com>
Fixes: 0101947dbcc3 ("tee: optee: add invoke_fn tracepoints")
Tested-by: Heiko Thiery <heiko.thiery@gmail.com>
> ---
> drivers/tee/optee/Makefile | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/tee/optee/Makefile b/drivers/tee/optee/Makefile
> index 56263ae3b1d7..3aa33ea9e6a6 100644
> --- a/drivers/tee/optee/Makefile
> +++ b/drivers/tee/optee/Makefile
> @@ -6,3 +6,6 @@ optee-objs += rpc.o
> optee-objs += supp.o
> optee-objs += shm_pool.o
> optee-objs += device.o
> +
> +# for tracing framework to find optee_trace.h
> +CFLAGS_call.o := -I$(src)
> --
> 2.31.0
>
Thank you.
--
Heiko
WARNING: multiple messages have this Message-ID (diff)
From: Heiko Thiery <heiko.thiery@gmail.com>
To: jisheng.zhang@synaptics.com
Cc: jens.wiklander@linaro.org, linux-kernel@vger.kernel.org,
linux@roeck-us.net, op-tee@lists.trustedfirmware.org,
rostedt@goodmis.org, Heiko Thiery <heiko.thiery@gmail.com>
Subject: Re: [PATCH] tee: optee: fix build error caused by recent optee tracepoints feature
Date: Tue, 30 Mar 2021 08:53:42 +0200 [thread overview]
Message-ID: <20210330065341.18074-1-heiko.thiery@gmail.com> (raw)
In-Reply-To: <20210325120601.71584253@xhacker.debian>
> If build kernel without "O=dir", below error will be seen:
>
> In file included from drivers/tee/optee/optee_trace.h:67,
> from drivers/tee/optee/call.c:18:
> ./include/trace/define_trace.h:95:42: fatal error: ./optee_trace.h: No such file or directory
> 95 | #include TRACE_INCLUDE(TRACE_INCLUDE_FILE)
> | ^
> compilation terminated.
>
> Fix it by adding below line to Makefile:
> CFLAGS_call.o := -I$(src)
>
> Tested with and without "O=dir", both can build successfully.
>
> Reported-by: Guenter Roeck <linux@roeck-us.net>
> Suggested-by: Steven Rostedt <rostedt@goodmis.org>
> Signed-off-by: Jisheng Zhang <Jisheng.Zhang@synaptics.com>
Fixes: 0101947dbcc3 ("tee: optee: add invoke_fn tracepoints")
Tested-by: Heiko Thiery <heiko.thiery@gmail.com>
> ---
> drivers/tee/optee/Makefile | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/tee/optee/Makefile b/drivers/tee/optee/Makefile
> index 56263ae3b1d7..3aa33ea9e6a6 100644
> --- a/drivers/tee/optee/Makefile
> +++ b/drivers/tee/optee/Makefile
> @@ -6,3 +6,6 @@ optee-objs += rpc.o
> optee-objs += supp.o
> optee-objs += shm_pool.o
> optee-objs += device.o
> +
> +# for tracing framework to find optee_trace.h
> +CFLAGS_call.o := -I$(src)
> --
> 2.31.0
>
Thank you.
--
Heiko
next prev parent reply other threads:[~2021-03-30 6:53 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-25 4:06 [PATCH] tee: optee: fix build error caused by recent optee tracepoints feature Jisheng Zhang
2021-03-25 4:06 ` Jisheng Zhang
2021-03-30 6:53 ` Heiko Thiery [this message]
2021-03-30 6:53 ` Heiko Thiery
2021-03-30 8:26 ` Jens Wiklander
2021-03-30 8:26 ` Jens Wiklander
2021-04-06 10:38 ` Heiko Thiery
2021-04-06 10:38 ` Heiko Thiery
-- strict thread matches above, loose matches on Subject: below --
2021-03-25 4:57 Guenter Roeck
2021-03-25 4:57 ` Guenter Roeck
[not found] < <CAEyMn7a1Ec6WZ24i5kCP-4AmM0=s2qEoOTXFpS72a7n+0P7uaw@mail.gmail.com>
2021-04-06 12:30 ` Jens Wiklander
2021-04-06 12:30 ` Jens Wiklander
[not found] < <CAHUa44HDrHP6-z=FRkNJtkSe8cVJY-acPDK_r7QrO5QgPwo+iA@mail.gmail.com>
2021-04-06 14:20 ` Heiko Thiery
2021-04-06 14:20 ` Heiko Thiery
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210330065341.18074-1-heiko.thiery@gmail.com \
--to=heiko.thiery@gmail.com \
--cc=op-tee@lists.trustedfirmware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.