Re: [PATCH 1/2] drm/panel: simple: Add support for EDT ETMV570G2DHU panel

From: Rob Herring <robh@kernel.org>
To: Yunus Bas <y.bas@phytec.de>
Cc: dri-devel@lists.freedesktop.org, thierry.reding@gmail.com,
	sam@ravnborg.org, devicetree@vger.kernel.org, airlied@linux.ie,
	daniel@ffwll.ch
Subject: Re: [PATCH 1/2] drm/panel: simple: Add support for EDT ETMV570G2DHU panel
Date: Tue, 30 Mar 2021 17:47:13 -0500	[thread overview]
Message-ID: <20210330224713.GA852261@robh.at.kernel.org> (raw)
In-Reply-To: <20210330070907.11587-1-y.bas@phytec.de>

On Tue, Mar 30, 2021 at 09:09:06AM +0200, Yunus Bas wrote:
> From: Stefan Riedmueller <s.riedmueller@phytec.de>
> 
> This patch adds support for the EDT ETMV570G2DHU 5.7" (640x480) lcd panel
> to DRM simple panel driver.
> 
> Signed-off-by: Stefan Riedmueller <s.riedmueller@phytec.de>
> Signed-off-by: Yunus Bas <y.bas@phytec.de>
> ---
>  .../bindings/display/panel/panel-simple.yaml  |  3 ++

Bindings should be their own patch.

>  drivers/gpu/drm/panel/panel-simple.c          | 29 +++++++++++++++++++
>  2 files changed, 32 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/display/panel/panel-simple.yaml b/Documentation/devicetree/bindings/display/panel/panel-simple.yaml
> index 62b0d54d87b7..57be1fa39728 100644
> --- a/Documentation/devicetree/bindings/display/panel/panel-simple.yaml
> +++ b/Documentation/devicetree/bindings/display/panel/panel-simple.yaml
> @@ -114,6 +114,9 @@ properties:
>        - edt,etm043080dh6gp
>          # Emerging Display Technology Corp. 480x272 TFT Display
>        - edt,etm0430g0dh6
> +        # Emerging Display Technology Corp. 5.7" VGA TFT LCD panel with
> +        # capacitive touch
> +      - edt,etmv570g2dhu
>          # Emerging Display Technology Corp. WVGA TFT Display with capacitive touch
>          # Same as ETM0700G0DH6 but with inverted pixel clock.
>        - edt,etm070080bdh6
> diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c
> index 4e2dad314c79..283c17a75376 100644
> --- a/drivers/gpu/drm/panel/panel-simple.c
> +++ b/drivers/gpu/drm/panel/panel-simple.c
> @@ -1926,6 +1926,32 @@ static const struct panel_desc edt_et057090dhu = {
>  	.connector_type = DRM_MODE_CONNECTOR_DPI,
>  };
>  
> +static const struct drm_display_mode edt_etmv570g2dhu_mode = {
> +	.clock = 25175,
> +	.hdisplay = 640,
> +	.hsync_start = 640,
> +	.hsync_end = 640 + 16,
> +	.htotal = 640 + 16 + 30 + 114,
> +	.vdisplay = 480,
> +	.vsync_start = 480 + 10,
> +	.vsync_end = 480 + 10 + 3,
> +	.vtotal = 480 + 10 + 3 + 35,
> +	.flags = DRM_MODE_FLAG_PVSYNC | DRM_MODE_FLAG_PHSYNC,
> +};
> +
> +static const struct panel_desc edt_etmv570g2dhu = {
> +	.modes = &edt_etmv570g2dhu_mode,
> +	.num_modes = 1,
> +	.bpc = 6,
> +	.size = {
> +		.width = 115,
> +		.height = 86,
> +	},
> +	.bus_format = MEDIA_BUS_FMT_RGB888_1X24,
> +	.bus_flags = DRM_BUS_FLAG_DE_HIGH | DRM_BUS_FLAG_PIXDATA_DRIVE_NEGEDGE,
> +	.connector_type = DRM_MODE_CONNECTOR_DPI,
> +};
> +
>  static const struct drm_display_mode edt_etm0700g0dh6_mode = {
>  	.clock = 33260,
>  	.hdisplay = 800,
> @@ -4226,6 +4252,9 @@ static const struct of_device_id platform_of_match[] = {
>  	}, {
>  		.compatible = "edt,et057090dhu",
>  		.data = &edt_et057090dhu,
> +	}, {
> +		.compatible = "edt,etmv570g2dhu",
> +		.data = &edt_etmv570g2dhu,
>  	}, {
>  		.compatible = "edt,et070080dh6",
>  		.data = &edt_etm0700g0dh6,
> -- 
> 2.30.0
> 