Re: [PATCH v2 1/2] kunit: add a KUnit test for SLUB debugging functionality

[kernel test robot <lkp@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 4065 bytes --]

Hi,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on linus/master]
[also build test WARNING on v5.12-rc5]
[cannot apply to hnaz-linux-mm/master next-20210330]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/glittao-gmail-com/kunit-add-a-KUnit-test-for-SLUB-debugging-functionality/20210330-200635
base:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git 1e43c377a79f9189fea8f2711b399d4e8b4e609b
config: x86_64-randconfig-r022-20210330 (attached as .config)
compiler: clang version 13.0.0 (https://github.com/llvm/llvm-project 482283042f795ecc27838a3b2f76b5494991401c)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # install x86_64 cross compiling tool for clang build
        # apt-get install binutils-x86-64-linux-gnu
        # https://github.com/0day-ci/linux/commit/98f544695d3d3b4676d7ff7bd7c964c9d39172d2
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review glittao-gmail-com/kunit-add-a-KUnit-test-for-SLUB-debugging-functionality/20210330-200635
        git checkout 98f544695d3d3b4676d7ff7bd7c964c9d39172d2
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=x86_64 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

>> mm/slub.c:744:17: warning: use of logical '&&' with constant operand [-Wconstant-logical-operand]
           if (!(s->flags && SLAB_SILENT_ERRORS)) {
                          ^  ~~~~~~~~~~~~~~~~~~
   mm/slub.c:744:17: note: use '&' for a bitwise operation
           if (!(s->flags && SLAB_SILENT_ERRORS)) {
                          ^~
                          &
   mm/slub.c:744:17: note: remove constant to silence this warning
           if (!(s->flags && SLAB_SILENT_ERRORS)) {
                         ~^~~~~~~~~~~~~~~~~~~~~
   mm/slub.c:759:17: warning: use of logical '&&' with constant operand [-Wconstant-logical-operand]
           if (!(s->flags && SLAB_SILENT_ERRORS)) {
                          ^  ~~~~~~~~~~~~~~~~~~
   mm/slub.c:759:17: note: use '&' for a bitwise operation
           if (!(s->flags && SLAB_SILENT_ERRORS)) {
                          ^~
                          &
   mm/slub.c:759:17: note: remove constant to silence this warning
           if (!(s->flags && SLAB_SILENT_ERRORS)) {
                         ~^~~~~~~~~~~~~~~~~~~~~
   mm/slub.c:807:17: warning: use of logical '&&' with constant operand [-Wconstant-logical-operand]
           if (!(s->flags && SLAB_SILENT_ERRORS)) {
                          ^  ~~~~~~~~~~~~~~~~~~
   mm/slub.c:807:17: note: use '&' for a bitwise operation
           if (!(s->flags && SLAB_SILENT_ERRORS)) {
                          ^~
                          &
   mm/slub.c:807:17: note: remove constant to silence this warning
           if (!(s->flags && SLAB_SILENT_ERRORS)) {
                         ~^~~~~~~~~~~~~~~~~~~~~
   mm/slub.c:1536:21: warning: unused function 'kmalloc_large_node_hook' [-Wunused-function]
   static inline void *kmalloc_large_node_hook(void *ptr, size_t size, gfp_t flags)
                       ^
   4 warnings generated.


vim +744 mm/slub.c

   740	
   741	void object_err(struct kmem_cache *s, struct page *page,
   742				u8 *object, char *reason)
   743	{
 > 744		if (!(s->flags && SLAB_SILENT_ERRORS)) {
   745			slab_bug(s, "%s", reason);
   746			print_trailer(s, page, object);
   747		}
   748	}
   749	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 31773 bytes --]