From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Richard Guy Briggs <rgb@redhat.com>
Cc: Jones Desougi <jones.desougi+netfilter@gmail.com>,
Phil Sutter <phil@nwl.cc>, Florian Westphal <fw@strlen.de>,
LKML <linux-kernel@vger.kernel.org>,
Linux-Audit Mailing List <linux-audit@redhat.com>,
netfilter-devel@vger.kernel.org, twoerner@redhat.com,
Eric Paris <eparis@parisplace.org>,
tgraf@infradead.org, dan.carpenter@oracle.com
Subject: Re: [PATCH v5] audit: log nftables configuration change events once per table
Date: Wed, 31 Mar 2021 22:56:39 +0200 [thread overview]
Message-ID: <20210331205639.GA4972@salvia> (raw)
In-Reply-To: <20210331205310.GA3141668@madcap2.tricolour.ca>
On Wed, Mar 31, 2021 at 04:53:10PM -0400, Richard Guy Briggs wrote:
> On 2021-03-31 22:22, Pablo Neira Ayuso wrote:
> > On Fri, Mar 26, 2021 at 01:38:59PM -0400, Richard Guy Briggs wrote:
> > > Reduce logging of nftables events to a level similar to iptables.
> > > Restore the table field to list the table, adding the generation.
> > >
> > > Indicate the op as the most significant operation in the event.
> >
> > There's a UAF, Florian reported. I'm attaching an incremental fix.
> >
> > nf_tables_commit_audit_collect() refers to the trans object which
> > might have been already released.
>
> Got it. Thanks Pablo. I didn't see it when running nft-test.py Where
> was it reported?
CONFIG_KASAN.
> Here I tried to stay out of the way by putting that
> call at the end of the loop but that was obviously a mistake in
> hindsight. :-)
No problem, I'll squash this incremental fix into your audit patch.
--
Linux-audit mailing list
Linux-audit@redhat.com
https://listman.redhat.com/mailman/listinfo/linux-audit
WARNING: multiple messages have this Message-ID (diff)
From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Richard Guy Briggs <rgb@redhat.com>
Cc: Linux-Audit Mailing List <linux-audit@redhat.com>,
LKML <linux-kernel@vger.kernel.org>,
netfilter-devel@vger.kernel.org, Paul Moore <paul@paul-moore.com>,
Eric Paris <eparis@parisplace.org>,
Steve Grubb <sgrubb@redhat.com>, Florian Westphal <fw@strlen.de>,
Phil Sutter <phil@nwl.cc>,
twoerner@redhat.com, tgraf@infradead.org,
dan.carpenter@oracle.com,
Jones Desougi <jones.desougi+netfilter@gmail.com>
Subject: Re: [PATCH v5] audit: log nftables configuration change events once per table
Date: Wed, 31 Mar 2021 22:56:39 +0200 [thread overview]
Message-ID: <20210331205639.GA4972@salvia> (raw)
In-Reply-To: <20210331205310.GA3141668@madcap2.tricolour.ca>
On Wed, Mar 31, 2021 at 04:53:10PM -0400, Richard Guy Briggs wrote:
> On 2021-03-31 22:22, Pablo Neira Ayuso wrote:
> > On Fri, Mar 26, 2021 at 01:38:59PM -0400, Richard Guy Briggs wrote:
> > > Reduce logging of nftables events to a level similar to iptables.
> > > Restore the table field to list the table, adding the generation.
> > >
> > > Indicate the op as the most significant operation in the event.
> >
> > There's a UAF, Florian reported. I'm attaching an incremental fix.
> >
> > nf_tables_commit_audit_collect() refers to the trans object which
> > might have been already released.
>
> Got it. Thanks Pablo. I didn't see it when running nft-test.py Where
> was it reported?
CONFIG_KASAN.
> Here I tried to stay out of the way by putting that
> call at the end of the loop but that was obviously a mistake in
> hindsight. :-)
No problem, I'll squash this incremental fix into your audit patch.
next prev parent reply other threads:[~2021-03-31 21:00 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-26 17:38 [PATCH v5] audit: log nftables configuration change events once per table Richard Guy Briggs
2021-03-26 17:38 ` Richard Guy Briggs
2021-03-29 0:50 ` Paul Moore
2021-03-29 0:50 ` Paul Moore
2021-03-30 22:53 ` Pablo Neira Ayuso
2021-03-30 22:53 ` Pablo Neira Ayuso
2021-03-31 0:50 ` Paul Moore
2021-03-31 0:50 ` Paul Moore
2021-03-31 20:22 ` Pablo Neira Ayuso
2021-03-31 20:22 ` Pablo Neira Ayuso
2021-03-31 20:53 ` Richard Guy Briggs
2021-03-31 20:53 ` Richard Guy Briggs
2021-03-31 20:56 ` Pablo Neira Ayuso [this message]
2021-03-31 20:56 ` Pablo Neira Ayuso
2021-03-31 20:46 ` Pablo Neira Ayuso
2021-03-31 20:46 ` Pablo Neira Ayuso
2021-03-31 20:55 ` Richard Guy Briggs
2021-03-31 20:55 ` Richard Guy Briggs
2021-04-01 13:24 ` Phil Sutter
2021-04-01 13:24 ` Phil Sutter
2021-04-01 13:34 ` Richard Guy Briggs
2021-04-01 13:34 ` Richard Guy Briggs
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210331205639.GA4972@salvia \
--to=pablo@netfilter.org \
--cc=dan.carpenter@oracle.com \
--cc=eparis@parisplace.org \
--cc=fw@strlen.de \
--cc=jones.desougi+netfilter@gmail.com \
--cc=linux-audit@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=phil@nwl.cc \
--cc=rgb@redhat.com \
--cc=tgraf@infradead.org \
--cc=twoerner@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.