All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Teigland <teigland@sourceware.org>
To: lvm-devel@redhat.com
Subject: dev-next - tests: skip stray testing on real dev dir
Date: Wed, 31 Mar 2021 21:49:06 +0000 (GMT)	[thread overview]
Message-ID: <20210331214906.683EF3858C27@sourceware.org> (raw)

Gitweb:        https://sourceware.org/git/?p=lvm2.git;a=commitdiff;h=afd43a75f20fbecb047924468c84212f7aefcf0b
Commit:        afd43a75f20fbecb047924468c84212f7aefcf0b
Parent:        a126dde069ada9380ba2f7ab7e520ba4ce3e2a90
Author:        Zdenek Kabelac <zkabelac@redhat.com>
AuthorDate:    Wed Mar 24 11:57:46 2021 +0100
Committer:     Zdenek Kabelac <zkabelac@redhat.com>
CommitterDate: Wed Mar 24 12:23:07 2021 +0100

tests: skip stray testing on real dev dir

Do not modify /dev dir maintained by udev.
---
 test/shell/stray-device-node.sh | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/test/shell/stray-device-node.sh b/test/shell/stray-device-node.sh
index 7ed229388..003afb7e8 100644
--- a/test/shell/stray-device-node.sh
+++ b/test/shell/stray-device-node.sh
@@ -18,6 +18,9 @@ SKIP_WITH_LVMPOLLD=1
 aux prepare_devs 3
 get_devs
 
+# Avoid manipulation with real /dev dir
+test "$DM_DEV_DIR" = "/dev" && skip "Skipping stray test on real /dev dir"
+
 cp -r "$dev1" "$DM_DEV_DIR/stray"
 
 vgcreate $SHARED "$vg" "${DEVICES[@]}"
@@ -29,3 +32,5 @@ aux disable_dev "$dev1"
 pvscan
 vgreduce --removemissing --force $vg
 aux enable_dev "$dev1"
+
+rm -f "$DM_DEV_DIR/stray"



                 reply	other threads:[~2021-03-31 21:49 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210331214906.683EF3858C27@sourceware.org \
    --to=teigland@sourceware.org \
    --cc=lvm-devel@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.