All of lore.kernel.org
 help / color / mirror / Atom feed
* dev-next - tests: skip stray testing on real dev dir
@ 2021-03-31 21:49 David Teigland
  0 siblings, 0 replies; only message in thread
From: David Teigland @ 2021-03-31 21:49 UTC (permalink / raw)
  To: lvm-devel

Gitweb:        https://sourceware.org/git/?p=lvm2.git;a=commitdiff;h=afd43a75f20fbecb047924468c84212f7aefcf0b
Commit:        afd43a75f20fbecb047924468c84212f7aefcf0b
Parent:        a126dde069ada9380ba2f7ab7e520ba4ce3e2a90
Author:        Zdenek Kabelac <zkabelac@redhat.com>
AuthorDate:    Wed Mar 24 11:57:46 2021 +0100
Committer:     Zdenek Kabelac <zkabelac@redhat.com>
CommitterDate: Wed Mar 24 12:23:07 2021 +0100

tests: skip stray testing on real dev dir

Do not modify /dev dir maintained by udev.
---
 test/shell/stray-device-node.sh | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/test/shell/stray-device-node.sh b/test/shell/stray-device-node.sh
index 7ed229388..003afb7e8 100644
--- a/test/shell/stray-device-node.sh
+++ b/test/shell/stray-device-node.sh
@@ -18,6 +18,9 @@ SKIP_WITH_LVMPOLLD=1
 aux prepare_devs 3
 get_devs
 
+# Avoid manipulation with real /dev dir
+test "$DM_DEV_DIR" = "/dev" && skip "Skipping stray test on real /dev dir"
+
 cp -r "$dev1" "$DM_DEV_DIR/stray"
 
 vgcreate $SHARED "$vg" "${DEVICES[@]}"
@@ -29,3 +32,5 @@ aux disable_dev "$dev1"
 pvscan
 vgreduce --removemissing --force $vg
 aux enable_dev "$dev1"
+
+rm -f "$DM_DEV_DIR/stray"



^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2021-03-31 21:49 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-03-31 21:49 dev-next - tests: skip stray testing on real dev dir David Teigland

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.