From: Russell King - ARM Linux admin <linux@armlinux.org.uk>
To: Michael Sit Wei Hong <michael.wei.hong.sit@intel.com>
Cc: peppe.cavallaro@st.com, alexandre.torgue@st.com,
joabreu@synopsys.com, davem@davemloft.net, kuba@kernel.org,
mcoquelin.stm32@gmail.com, weifeng.voon@intel.com,
boon.leong.ong@intel.com, qiangqing.zhang@nxp.com,
vee.khee.wong@intel.com, fugang.duan@nxp.com,
kim.tatt.chuah@intel.com, netdev@vger.kernel.org,
linux-stm32@st-md-mailman.stormreply.com,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, andrew@lunn.ch,
hkallweit1@gmail.com
Subject: Re: [PATCH net-next 1/2] net: stmmac: enable 2.5Gbps link speed
Date: Thu, 1 Apr 2021 16:10:44 +0100 [thread overview]
Message-ID: <20210401151044.GZ1463@shell.armlinux.org.uk> (raw)
In-Reply-To: <20210401150152.22444-2-michael.wei.hong.sit@intel.com>
On Thu, Apr 01, 2021 at 11:01:51PM +0800, Michael Sit Wei Hong wrote:
> + /* 2.5G mode only support 2500baseT full duplex only */
> + if (priv->plat->has_gmac4 && priv->plat->speed_2500_en) {
> + phylink_set(mac_supported, 2500baseT_Full);
> + phylink_set(mask, 10baseT_Half);
> + phylink_set(mask, 10baseT_Full);
> + phylink_set(mask, 100baseT_Half);
> + phylink_set(mask, 100baseT_Full);
> + phylink_set(mask, 1000baseT_Half);
> + phylink_set(mask, 1000baseT_Full);
> + phylink_set(mask, 1000baseKX_Full);
Why? This seems at odds to the comment above?
What about 2500baseX_Full ?
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Russell King - ARM Linux admin <linux@armlinux.org.uk>
To: Michael Sit Wei Hong <michael.wei.hong.sit@intel.com>
Cc: peppe.cavallaro@st.com, alexandre.torgue@st.com,
joabreu@synopsys.com, davem@davemloft.net, kuba@kernel.org,
mcoquelin.stm32@gmail.com, weifeng.voon@intel.com,
boon.leong.ong@intel.com, qiangqing.zhang@nxp.com,
vee.khee.wong@intel.com, fugang.duan@nxp.com,
kim.tatt.chuah@intel.com, netdev@vger.kernel.org,
linux-stm32@st-md-mailman.stormreply.com,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, andrew@lunn.ch,
hkallweit1@gmail.com
Subject: Re: [PATCH net-next 1/2] net: stmmac: enable 2.5Gbps link speed
Date: Thu, 1 Apr 2021 16:10:44 +0100 [thread overview]
Message-ID: <20210401151044.GZ1463@shell.armlinux.org.uk> (raw)
In-Reply-To: <20210401150152.22444-2-michael.wei.hong.sit@intel.com>
On Thu, Apr 01, 2021 at 11:01:51PM +0800, Michael Sit Wei Hong wrote:
> + /* 2.5G mode only support 2500baseT full duplex only */
> + if (priv->plat->has_gmac4 && priv->plat->speed_2500_en) {
> + phylink_set(mac_supported, 2500baseT_Full);
> + phylink_set(mask, 10baseT_Half);
> + phylink_set(mask, 10baseT_Full);
> + phylink_set(mask, 100baseT_Half);
> + phylink_set(mask, 100baseT_Full);
> + phylink_set(mask, 1000baseT_Half);
> + phylink_set(mask, 1000baseT_Full);
> + phylink_set(mask, 1000baseKX_Full);
Why? This seems at odds to the comment above?
What about 2500baseX_Full ?
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!
next prev parent reply other threads:[~2021-04-01 15:15 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-01 15:01 [PATCH net-next 0/2] Enable 2.5Gbps speed for stmmac Michael Sit Wei Hong
2021-04-01 15:01 ` Michael Sit Wei Hong
2021-04-01 15:01 ` [PATCH net-next 1/2] net: stmmac: enable 2.5Gbps link speed Michael Sit Wei Hong
2021-04-01 15:01 ` Michael Sit Wei Hong
2021-04-01 15:10 ` Russell King - ARM Linux admin [this message]
2021-04-01 15:10 ` Russell King - ARM Linux admin
2021-04-02 7:45 ` Voon, Weifeng
2021-04-02 7:45 ` Voon, Weifeng
2021-04-02 12:34 ` Andrew Lunn
2021-04-02 12:34 ` Andrew Lunn
2021-04-05 9:07 ` Voon, Weifeng
2021-04-05 9:07 ` Voon, Weifeng
2021-04-05 12:43 ` Andrew Lunn
2021-04-05 12:43 ` Andrew Lunn
2021-04-01 15:01 ` [PATCH net-next 2/2] net: pcs: configure xpcs 2.5G speed mode Michael Sit Wei Hong
2021-04-01 15:01 ` Michael Sit Wei Hong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210401151044.GZ1463@shell.armlinux.org.uk \
--to=linux@armlinux.org.uk \
--cc=alexandre.torgue@st.com \
--cc=andrew@lunn.ch \
--cc=boon.leong.ong@intel.com \
--cc=davem@davemloft.net \
--cc=fugang.duan@nxp.com \
--cc=hkallweit1@gmail.com \
--cc=joabreu@synopsys.com \
--cc=kim.tatt.chuah@intel.com \
--cc=kuba@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=michael.wei.hong.sit@intel.com \
--cc=netdev@vger.kernel.org \
--cc=peppe.cavallaro@st.com \
--cc=qiangqing.zhang@nxp.com \
--cc=vee.khee.wong@intel.com \
--cc=weifeng.voon@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.