Re: [PATCH] mm/vmscan.c: drop_slab_node with task's memcg

[kernel test robot <lkp@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 2731 bytes --]

Hi Neil,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on v5.12-rc5]
[also build test ERROR on next-20210401]
[cannot apply to hnaz-linux-mm/master]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Neil-Sun/mm-vmscan-c-drop_slab_node-with-task-s-memcg/20210402-184123
base:    a5e13c6df0e41702d2b2c77c8ad41677ebb065b3
config: arm-randconfig-r035-20210401 (attached as .config)
compiler: arm-linux-gnueabi-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/73abc13485ec57de137f60535b5b2495c0bac570
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Neil-Sun/mm-vmscan-c-drop_slab_node-with-task-s-memcg/20210402-184123
        git checkout 73abc13485ec57de137f60535b5b2495c0bac570
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=arm 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All error/warnings (new ones prefixed by >>):

   mm/vmscan.c: In function 'drop_slab_node':
>> mm/vmscan.c:705:11: error: implicit declaration of function 'mem_cgroup_from_task'; did you mean 'mem_cgroup_from_obj'? [-Werror=implicit-function-declaration]
     705 |   memcg = mem_cgroup_from_task(current);
         |           ^~~~~~~~~~~~~~~~~~~~
         |           mem_cgroup_from_obj
>> mm/vmscan.c:705:9: warning: assignment to 'struct mem_cgroup *' from 'int' makes pointer from integer without a cast [-Wint-conversion]
     705 |   memcg = mem_cgroup_from_task(current);
         |         ^
   cc1: some warnings being treated as errors


vim +705 mm/vmscan.c

   693	
   694	void drop_slab_node(int nid)
   695	{
   696		unsigned long freed;
   697	
   698		do {
   699			struct mem_cgroup *memcg = NULL;
   700	
   701			if (fatal_signal_pending(current))
   702				return;
   703	
   704			freed = 0;
 > 705			memcg = mem_cgroup_from_task(current);
   706			do {
   707				freed += shrink_slab(GFP_KERNEL, nid, memcg, 0);
   708			} while ((memcg = mem_cgroup_iter(NULL, memcg, NULL)) != NULL);
   709		} while (freed > 10);
   710	}
   711	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 21042 bytes --]