From: Thomas Zimmermann <tzimmermann@suse.de>
To: alexander.deucher@amd.com, christian.koenig@amd.com,
airlied@linux.ie, daniel@ffwll.ch, bskeggs@redhat.com,
ray.huang@amd.com, linux-graphics-maintainer@vmware.com,
sroland@vmware.com, zackr@vmware.com, shashank.sharma@amd.com,
sam@ravnborg.org, emil.velikov@collabora.com,
Felix.Kuehling@amd.com, nirmoy.das@amd.com
Cc: nouveau@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
amd-gfx@lists.freedesktop.org,
Thomas Zimmermann <tzimmermann@suse.de>
Subject: [PATCH 1/8] drm/ttm: Don't override vm_ops callbacks, if set
Date: Tue, 6 Apr 2021 11:08:56 +0200 [thread overview]
Message-ID: <20210406090903.7019-2-tzimmermann@suse.de> (raw)
In-Reply-To: <20210406090903.7019-1-tzimmermann@suse.de>
Drivers may want to set their own callbacks for a VM area. Only set
TTM's callbacks if the vm_ops field is clear.
Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
---
drivers/gpu/drm/ttm/ttm_bo_vm.c | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/ttm/ttm_bo_vm.c b/drivers/gpu/drm/ttm/ttm_bo_vm.c
index b31b18058965..bf4a213bc66c 100644
--- a/drivers/gpu/drm/ttm/ttm_bo_vm.c
+++ b/drivers/gpu/drm/ttm/ttm_bo_vm.c
@@ -534,7 +534,12 @@ static struct ttm_buffer_object *ttm_bo_vm_lookup(struct ttm_device *bdev,
static void ttm_bo_mmap_vma_setup(struct ttm_buffer_object *bo, struct vm_area_struct *vma)
{
- vma->vm_ops = &ttm_bo_vm_ops;
+ /*
+ * Drivers may want to override the vm_ops field. Otherwise we
+ * use TTM's default callbacks.
+ */
+ if (!vma->vm_ops)
+ vma->vm_ops = &ttm_bo_vm_ops;
/*
* Note: We're transferring the bo reference to
--
2.30.2
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
WARNING: multiple messages have this Message-ID (diff)
From: Thomas Zimmermann <tzimmermann@suse.de>
To: alexander.deucher@amd.com, christian.koenig@amd.com,
airlied@linux.ie, daniel@ffwll.ch, bskeggs@redhat.com,
ray.huang@amd.com, linux-graphics-maintainer@vmware.com,
sroland@vmware.com, zackr@vmware.com, shashank.sharma@amd.com,
sam@ravnborg.org, emil.velikov@collabora.com,
Felix.Kuehling@amd.com, nirmoy.das@amd.com
Cc: nouveau@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
amd-gfx@lists.freedesktop.org
Subject: [Nouveau] [PATCH 1/8] drm/ttm: Don't override vm_ops callbacks, if set
Date: Tue, 6 Apr 2021 11:08:56 +0200 [thread overview]
Message-ID: <20210406090903.7019-2-tzimmermann@suse.de> (raw)
In-Reply-To: <20210406090903.7019-1-tzimmermann@suse.de>
Drivers may want to set their own callbacks for a VM area. Only set
TTM's callbacks if the vm_ops field is clear.
Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
---
drivers/gpu/drm/ttm/ttm_bo_vm.c | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/ttm/ttm_bo_vm.c b/drivers/gpu/drm/ttm/ttm_bo_vm.c
index b31b18058965..bf4a213bc66c 100644
--- a/drivers/gpu/drm/ttm/ttm_bo_vm.c
+++ b/drivers/gpu/drm/ttm/ttm_bo_vm.c
@@ -534,7 +534,12 @@ static struct ttm_buffer_object *ttm_bo_vm_lookup(struct ttm_device *bdev,
static void ttm_bo_mmap_vma_setup(struct ttm_buffer_object *bo, struct vm_area_struct *vma)
{
- vma->vm_ops = &ttm_bo_vm_ops;
+ /*
+ * Drivers may want to override the vm_ops field. Otherwise we
+ * use TTM's default callbacks.
+ */
+ if (!vma->vm_ops)
+ vma->vm_ops = &ttm_bo_vm_ops;
/*
* Note: We're transferring the bo reference to
--
2.30.2
_______________________________________________
Nouveau mailing list
Nouveau@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/nouveau
WARNING: multiple messages have this Message-ID (diff)
From: Thomas Zimmermann <tzimmermann@suse.de>
To: alexander.deucher@amd.com, christian.koenig@amd.com,
airlied@linux.ie, daniel@ffwll.ch, bskeggs@redhat.com,
ray.huang@amd.com, linux-graphics-maintainer@vmware.com,
sroland@vmware.com, zackr@vmware.com, shashank.sharma@amd.com,
sam@ravnborg.org, emil.velikov@collabora.com,
Felix.Kuehling@amd.com, nirmoy.das@amd.com
Cc: nouveau@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
amd-gfx@lists.freedesktop.org,
Thomas Zimmermann <tzimmermann@suse.de>
Subject: [PATCH 1/8] drm/ttm: Don't override vm_ops callbacks, if set
Date: Tue, 6 Apr 2021 11:08:56 +0200 [thread overview]
Message-ID: <20210406090903.7019-2-tzimmermann@suse.de> (raw)
In-Reply-To: <20210406090903.7019-1-tzimmermann@suse.de>
Drivers may want to set their own callbacks for a VM area. Only set
TTM's callbacks if the vm_ops field is clear.
Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
---
drivers/gpu/drm/ttm/ttm_bo_vm.c | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/ttm/ttm_bo_vm.c b/drivers/gpu/drm/ttm/ttm_bo_vm.c
index b31b18058965..bf4a213bc66c 100644
--- a/drivers/gpu/drm/ttm/ttm_bo_vm.c
+++ b/drivers/gpu/drm/ttm/ttm_bo_vm.c
@@ -534,7 +534,12 @@ static struct ttm_buffer_object *ttm_bo_vm_lookup(struct ttm_device *bdev,
static void ttm_bo_mmap_vma_setup(struct ttm_buffer_object *bo, struct vm_area_struct *vma)
{
- vma->vm_ops = &ttm_bo_vm_ops;
+ /*
+ * Drivers may want to override the vm_ops field. Otherwise we
+ * use TTM's default callbacks.
+ */
+ if (!vma->vm_ops)
+ vma->vm_ops = &ttm_bo_vm_ops;
/*
* Note: We're transferring the bo reference to
--
2.30.2
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2021-04-06 9:09 UTC|newest]
Thread overview: 102+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-06 9:08 [PATCH 0/8] drm: Clean up mmap for TTM-based GEM drivers Thomas Zimmermann
2021-04-06 9:08 ` Thomas Zimmermann
2021-04-06 9:08 ` [Nouveau] " Thomas Zimmermann
2021-04-06 9:08 ` Thomas Zimmermann [this message]
2021-04-06 9:08 ` [PATCH 1/8] drm/ttm: Don't override vm_ops callbacks, if set Thomas Zimmermann
2021-04-06 9:08 ` [Nouveau] " Thomas Zimmermann
2021-04-06 9:08 ` [PATCH 2/8] drm/amdgpu: Remove unused function amdgpu_bo_fbdev_mmap() Thomas Zimmermann
2021-04-06 9:08 ` Thomas Zimmermann
2021-04-06 9:08 ` [Nouveau] " Thomas Zimmermann
2021-04-06 9:43 ` Christian König
2021-04-06 9:43 ` Christian König
2021-04-06 9:43 ` [Nouveau] " Christian König
2021-04-06 10:21 ` Thomas Zimmermann
2021-04-06 10:21 ` Thomas Zimmermann
2021-04-06 10:21 ` [Nouveau] " Thomas Zimmermann
2021-04-06 9:08 ` [PATCH 3/8] drm/amdgpu: Implement mmap as GEM object function Thomas Zimmermann
2021-04-06 9:08 ` Thomas Zimmermann
2021-04-06 9:08 ` [Nouveau] " Thomas Zimmermann
2021-04-06 9:35 ` Christian König
2021-04-06 9:35 ` Christian König
2021-04-06 9:35 ` [Nouveau] " Christian König
2021-04-06 10:38 ` Thomas Zimmermann
2021-04-06 10:38 ` Thomas Zimmermann
2021-04-06 10:38 ` [Nouveau] " Thomas Zimmermann
2021-04-06 10:56 ` Christian König
2021-04-06 10:56 ` Christian König
2021-04-06 10:56 ` [Nouveau] " Christian König
2021-04-06 11:55 ` Thomas Zimmermann
2021-04-06 11:55 ` Thomas Zimmermann
2021-04-06 11:55 ` [Nouveau] " Thomas Zimmermann
2021-04-06 12:42 ` Christian König
2021-04-06 12:42 ` Christian König
2021-04-06 12:42 ` [Nouveau] " Christian König
2021-04-06 12:52 ` Thomas Zimmermann
2021-04-06 12:52 ` Thomas Zimmermann
2021-04-06 12:52 ` [Nouveau] " Thomas Zimmermann
2021-04-06 13:04 ` Christian König
2021-04-06 13:04 ` Christian König
2021-04-06 13:04 ` [Nouveau] " Christian König
2021-04-06 15:22 ` Felix Kuehling
2021-04-06 15:22 ` Felix Kuehling
2021-04-06 15:22 ` [Nouveau] " Felix Kuehling
2021-04-06 15:27 ` Felix Kuehling
2021-04-06 15:27 ` Felix Kuehling
2021-04-06 15:27 ` [Nouveau] " Felix Kuehling
2021-04-07 11:25 ` Christian König
2021-04-07 11:25 ` Christian König
2021-04-07 11:25 ` [Nouveau] " Christian König
2021-04-07 19:34 ` Felix Kuehling
2021-04-07 19:34 ` Felix Kuehling
2021-04-07 19:34 ` [Nouveau] " Felix Kuehling
2021-04-07 19:49 ` Felix Kuehling
2021-04-07 19:49 ` Felix Kuehling
2021-04-07 19:49 ` [Nouveau] " Felix Kuehling
2021-04-08 4:45 ` Thomas Zimmermann
2021-04-08 4:45 ` Thomas Zimmermann
2021-04-08 4:45 ` [Nouveau] " Thomas Zimmermann
2021-04-14 7:44 ` Thomas Zimmermann
2021-04-14 7:44 ` Thomas Zimmermann
2021-04-14 7:44 ` [Nouveau] " Thomas Zimmermann
2021-04-14 8:37 ` Felix Kuehling
2021-04-14 8:37 ` Felix Kuehling
2021-04-14 8:37 ` [Nouveau] " Felix Kuehling
2021-04-06 9:08 ` [PATCH 4/8] drm/radeon: " Thomas Zimmermann
2021-04-06 9:08 ` Thomas Zimmermann
2021-04-06 9:08 ` [Nouveau] " Thomas Zimmermann
2021-04-06 9:38 ` Christian König
2021-04-06 9:38 ` Christian König
2021-04-06 9:38 ` [Nouveau] " Christian König
2021-04-06 14:18 ` Alex Deucher
2021-04-06 14:18 ` Alex Deucher
2021-04-06 14:18 ` [Nouveau] " Alex Deucher
2021-04-06 9:09 ` [PATCH 5/8] drm/nouveau: " Thomas Zimmermann
2021-04-06 9:09 ` Thomas Zimmermann
2021-04-06 9:09 ` [Nouveau] " Thomas Zimmermann
2021-04-06 9:09 ` [PATCH 6/8] drm/vmwgfx: Inline ttm_bo_mmap() into vmwgfx driver Thomas Zimmermann
2021-04-06 9:09 ` Thomas Zimmermann
2021-04-06 9:09 ` [Nouveau] " Thomas Zimmermann
2021-04-07 16:52 ` Zack Rusin
2021-04-07 16:52 ` Zack Rusin
2021-04-07 16:52 ` [Nouveau] " Zack Rusin
2021-04-06 9:09 ` [PATCH 7/8] drm/vmwgfx: Inline vmw_verify_access() Thomas Zimmermann
2021-04-06 9:09 ` Thomas Zimmermann
2021-04-06 9:09 ` [Nouveau] " Thomas Zimmermann
2021-04-07 16:52 ` Zack Rusin
2021-04-07 16:52 ` Zack Rusin
2021-04-07 16:52 ` [Nouveau] " Zack Rusin
2021-04-06 9:09 ` [PATCH 8/8] drm/ttm: Remove ttm_bo_mmap() and friends Thomas Zimmermann
2021-04-06 9:09 ` Thomas Zimmermann
2021-04-06 9:09 ` [Nouveau] " Thomas Zimmermann
2021-04-06 9:40 ` Christian König
2021-04-06 9:40 ` Christian König
2021-04-06 9:40 ` [Nouveau] " Christian König
2021-04-08 11:19 ` [PATCH 0/8] drm: Clean up mmap for TTM-based GEM drivers Daniel Vetter
2021-04-08 11:19 ` Daniel Vetter
2021-04-08 11:19 ` [Nouveau] " Daniel Vetter
2021-04-08 11:38 ` Thomas Zimmermann
2021-04-08 11:38 ` Thomas Zimmermann
2021-04-08 11:38 ` [Nouveau] " Thomas Zimmermann
2021-04-08 11:42 ` Daniel Vetter
2021-04-08 11:42 ` Daniel Vetter
2021-04-08 11:42 ` [Nouveau] " Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210406090903.7019-2-tzimmermann@suse.de \
--to=tzimmermann@suse.de \
--cc=Felix.Kuehling@amd.com \
--cc=airlied@linux.ie \
--cc=alexander.deucher@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=bskeggs@redhat.com \
--cc=christian.koenig@amd.com \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=emil.velikov@collabora.com \
--cc=linux-graphics-maintainer@vmware.com \
--cc=nirmoy.das@amd.com \
--cc=nouveau@lists.freedesktop.org \
--cc=ray.huang@amd.com \
--cc=sam@ravnborg.org \
--cc=shashank.sharma@amd.com \
--cc=sroland@vmware.com \
--cc=zackr@vmware.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.