All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kees Cook <keescook@chromium.org>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: Michael Ellerman <mpe@ellerman.id.au>,
	Joerg Roedel <jroedel@suse.de>, Wei Liu <wei.liu@kernel.org>,
	Michael Kelley <mikelley@microsoft.com>,
	Mike Rapoport <rppt@kernel.org>,
	Corey Minyard <cminyard@mvista.com>,
	Bjorn Andersson <bjorn.andersson@linaro.org>,
	Mathieu Poirier <mathieu.poirier@linaro.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	Tetsuo Handa <penguin-kernel@i-love.sakura.ne.jp>,
	Vlastimil Babka <vbabka@suse.cz>,
	"Paul E. McKenney" <paulmck@kernel.org>,
	"Steven Rostedt (VMware)" <rostedt@goodmis.org>,
	linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org,
	linux-hyperv@vger.kernel.org,
	openipmi-developer@lists.sourceforge.net,
	linux-remoteproc@vger.kernel.org, linux-arch@vger.kernel.org,
	kexec@lists.infradead.org, rcu@vger.kernel.org,
	linux-fsdevel@vger.kernel.org,
	Benjamin Herrenschmidt <benh@kernel.crashing.org>,
	Paul Mackerras <paulus@samba.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
	x86@kernel.org, "H. Peter Anvin" <hpa@zytor.com>,
	"K. Y. Srinivasan" <kys@microsoft.com>,
	Haiyang Zhang <haiyangz@microsoft.com>,
	Stephen Hemminger <sthemmin@microsoft.com>,
	Corey Minyard <minyard@acm.org>, Ohad Ben-Cohen <ohad@wizery.com>,
	Arnd Bergmann <arnd@arndb.de>,
	Eric Biederman <ebiederm@xmission.com>,
	Josh Triplett <josh@joshtriplett.org>,
	Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
	Lai Jiangshan <jiangshanlai@gmail.com>,
	Joel Fernandes <joel@joelfernandes.org>,
	Luis Chamberlain <mcgrof@kernel.org>,
	Iurii Zaikin <yzaikin@google.com>
Subject: Re: [PATCH v1 1/1] kernel.h: Split out panic and oops helpers
Date: Tue, 6 Apr 2021 11:44:00 -0700	[thread overview]
Message-ID: <202104061143.E11D2D0@keescook> (raw)
In-Reply-To: <20210406133158.73700-1-andriy.shevchenko@linux.intel.com>

On Tue, Apr 06, 2021 at 04:31:58PM +0300, Andy Shevchenko wrote:
> kernel.h is being used as a dump for all kinds of stuff for a long time.
> Here is the attempt to start cleaning it up by splitting out panic and
> oops helpers.
> 
> At the same time convert users in header and lib folder to use new header.
> Though for time being include new header back to kernel.h to avoid twisted
> indirected includes for existing users.
> 
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>

I like it! Do you have a multi-arch CI to do allmodconfig builds to
double-check this?

Acked-by: Kees Cook <keescook@chromium.org>

-Kees

-- 
Kees Cook

_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec

WARNING: multiple messages have this Message-ID (diff)
From: Kees Cook <keescook@chromium.org>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: Michael Ellerman <mpe@ellerman.id.au>,
	Joerg Roedel <jroedel@suse.de>, Wei Liu <wei.liu@kernel.org>,
	Michael Kelley <mikelley@microsoft.com>,
	Mike Rapoport <rppt@kernel.org>,
	Corey Minyard <cminyard@mvista.com>,
	Bjorn Andersson <bjorn.andersson@linaro.org>,
	Mathieu Poirier <mathieu.poirier@linaro.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	Tetsuo Handa <penguin-kernel@i-love.sakura.ne.jp>,
	Vlastimil Babka <vbabka@suse.cz>,
	"Paul E. McKenney" <paulmck@kernel.org>,
	"Steven Rostedt (VMware)" <rostedt@goodmis.org>,
	linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org,
	linux-hyperv@vger.kernel.org,
	openipmi-developer@lists.sourceforge.net,
	linux-remoteproc@vger.kernel.org, linux-arch@vger.kernel.org,
	kexec@lists.infradead.org, rcu@vger.kernel.org,
	linux-fsdevel@vger.kernel.org,
	Benjamin Herrenschmidt <benh@kernel.crashing.org>,
	Paul Mackerras <paulus@samba.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
	x86@kernel.org, "H. Peter Anvin" <hpa@zytor.com>,
	"K. Y. Srinivasan" <kys@microsoft.com>,
	Haiyang Zhang <haiyangz@microsoft.com>,
	Stephen Hemminger <sthemmin@microsoft.com>,
	Corey Minyard <minyard@acm.org>, Ohad Ben-Cohen <ohad@wizery.com>,
	Arnd Bergmann <arnd@arndb.de>,
	Eric Biederman <ebiederm@xmission.com>,
	Josh Triplett <josh@joshtriplett.org>,
	Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
	Lai Jiangshan <jiangshanlai@gmail.com>,
	Joel Fernandes <joel@joelfernandes.org>,
	Luis Chamberlain <mcgrof@kernel.org>,
	Iurii Zaikin <yzaikin@google.com>
Subject: Re: [PATCH v1 1/1] kernel.h: Split out panic and oops helpers
Date: Tue, 6 Apr 2021 11:44:00 -0700	[thread overview]
Message-ID: <202104061143.E11D2D0@keescook> (raw)
In-Reply-To: <20210406133158.73700-1-andriy.shevchenko@linux.intel.com>

On Tue, Apr 06, 2021 at 04:31:58PM +0300, Andy Shevchenko wrote:
> kernel.h is being used as a dump for all kinds of stuff for a long time.
> Here is the attempt to start cleaning it up by splitting out panic and
> oops helpers.
> 
> At the same time convert users in header and lib folder to use new header.
> Though for time being include new header back to kernel.h to avoid twisted
> indirected includes for existing users.
> 
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>

I like it! Do you have a multi-arch CI to do allmodconfig builds to
double-check this?

Acked-by: Kees Cook <keescook@chromium.org>

-Kees

-- 
Kees Cook

WARNING: multiple messages have this Message-ID (diff)
From: Kees Cook <keescook@chromium.org>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: Corey Minyard <cminyard@mvista.com>,
	linux-hyperv@vger.kernel.org,
	Tetsuo Handa <penguin-kernel@i-love.sakura.ne.jp>,
	linux-remoteproc@vger.kernel.org,
	Michael Kelley <mikelley@microsoft.com>,
	Paul Mackerras <paulus@samba.org>,
	"H. Peter Anvin" <hpa@zytor.com>,
	Joel Fernandes <joel@joelfernandes.org>,
	"K. Y. Srinivasan" <kys@microsoft.com>,
	Thomas Gleixner <tglx@linutronix.de>,
	linux-arch@vger.kernel.org, Wei Liu <wei.liu@kernel.org>,
	Stephen Hemminger <sthemmin@microsoft.com>,
	Corey Minyard <minyard@acm.org>,
	x86@kernel.org, Ingo Molnar <mingo@redhat.com>,
	Iurii Zaikin <yzaikin@google.com>,
	Ohad Ben-Cohen <ohad@wizery.com>, Joerg Roedel <jroedel@suse.de>,
	"Paul E. McKenney" <paulmck@kernel.org>,
	Lai Jiangshan <jiangshanlai@gmail.com>,
	Haiyang Zhang <haiyangz@microsoft.com>,
	Josh Triplett <josh@joshtriplett.org>,
	"Steven Rostedt \(VMware\)" <rostedt@goodmis.org>,
	rcu@vger.kernel.org, Borislav Petkov <bp@alien8.de>,
	openipmi-developer@lists.sourceforge.net,
	Bjorn Andersson <bjorn.andersson@linaro.org>,
	Vlastimil Babka <vbabka@suse.cz>,
	Mathieu Poirier <mathieu.poirier@linaro.org>,
	kexec@lists.infradead.org, linux-kernel@vger.kernel.org,
	Luis Chamberlain <mcgrof@kernel.org>,
	Arnd Bergmann <arnd@arndb.de>,
	Eric Biederman <ebiederm@xmission.com>,
	linux-fsdevel@vger.kernel.org,
	Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	linuxppc-dev@lists.ozlabs.org, Mike Rapoport <rppt@kernel.org>
Subject: Re: [PATCH v1 1/1] kernel.h: Split out panic and oops helpers
Date: Tue, 6 Apr 2021 11:44:00 -0700	[thread overview]
Message-ID: <202104061143.E11D2D0@keescook> (raw)
In-Reply-To: <20210406133158.73700-1-andriy.shevchenko@linux.intel.com>

On Tue, Apr 06, 2021 at 04:31:58PM +0300, Andy Shevchenko wrote:
> kernel.h is being used as a dump for all kinds of stuff for a long time.
> Here is the attempt to start cleaning it up by splitting out panic and
> oops helpers.
> 
> At the same time convert users in header and lib folder to use new header.
> Though for time being include new header back to kernel.h to avoid twisted
> indirected includes for existing users.
> 
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>

I like it! Do you have a multi-arch CI to do allmodconfig builds to
double-check this?

Acked-by: Kees Cook <keescook@chromium.org>

-Kees

-- 
Kees Cook

  parent reply	other threads:[~2021-04-06 18:44 UTC|newest]

Thread overview: 54+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-06 13:31 [PATCH v1 1/1] kernel.h: Split out panic and oops helpers Andy Shevchenko
2021-04-06 13:31 ` Andy Shevchenko
2021-04-06 13:31 ` Andy Shevchenko
2021-04-06 14:29 ` Bjorn Andersson
2021-04-06 14:29   ` Bjorn Andersson
2021-04-06 14:29   ` Bjorn Andersson
2021-04-06 14:39 ` Mike Rapoport
2021-04-06 14:39   ` Mike Rapoport
2021-04-06 14:39   ` Mike Rapoport
2021-04-06 14:39 ` Corey Minyard
2021-04-06 14:39   ` Corey Minyard
2021-04-06 14:39   ` Corey Minyard
2021-04-06 14:43 ` Christian Brauner
2021-04-06 14:43   ` Christian Brauner
2021-04-06 14:43   ` Christian Brauner
2021-04-06 15:09 ` Arnd Bergmann
2021-04-06 15:09   ` Arnd Bergmann
2021-04-06 15:09   ` Arnd Bergmann
2021-04-06 16:51 ` Luis Chamberlain
2021-04-06 16:51   ` Luis Chamberlain
2021-04-06 16:51   ` Luis Chamberlain
2021-04-07  7:33   ` Andy Shevchenko
2021-04-07  7:33     ` Andy Shevchenko
2021-04-07  7:33     ` Andy Shevchenko
2021-04-07 14:30     ` Luis Chamberlain
2021-04-07 14:30       ` Luis Chamberlain
2021-04-07 14:30       ` Luis Chamberlain
2021-04-07 14:59       ` Andy Shevchenko
2021-04-07 14:59         ` Andy Shevchenko
2021-04-07 14:59         ` Andy Shevchenko
2021-04-07 15:29         ` Luis Chamberlain
2021-04-07 15:29           ` Luis Chamberlain
2021-04-07 15:29           ` Luis Chamberlain
2021-04-06 18:44 ` Kees Cook [this message]
2021-04-06 18:44   ` Kees Cook
2021-04-06 18:44   ` Kees Cook
2021-04-07  8:46   ` Andy Shevchenko
2021-04-07  8:46     ` Andy Shevchenko
2021-04-07  8:46     ` Andy Shevchenko
2021-04-09  6:23     ` Andrew Morton
2021-04-09  6:23       ` Andrew Morton
2021-04-09  6:23       ` Andrew Morton
2021-04-09  8:22       ` Andy Shevchenko
2021-04-09  8:22         ` Andy Shevchenko
2021-04-09  8:22         ` Andy Shevchenko
2021-04-06 23:41 ` Wei Liu
2021-04-06 23:41   ` Wei Liu
2021-04-06 23:41   ` Wei Liu
2021-04-08 12:45 ` Rasmus Villemoes
2021-04-08 12:45   ` Rasmus Villemoes
2021-04-08 12:45   ` Rasmus Villemoes
2021-04-08 13:29   ` Andy Shevchenko
2021-04-08 13:29     ` Andy Shevchenko
2021-04-08 13:29     ` Andy Shevchenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202104061143.E11D2D0@keescook \
    --to=keescook@chromium.org \
    --cc=akpm@linux-foundation.org \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=arnd@arndb.de \
    --cc=benh@kernel.crashing.org \
    --cc=bjorn.andersson@linaro.org \
    --cc=bp@alien8.de \
    --cc=cminyard@mvista.com \
    --cc=ebiederm@xmission.com \
    --cc=haiyangz@microsoft.com \
    --cc=hpa@zytor.com \
    --cc=jiangshanlai@gmail.com \
    --cc=joel@joelfernandes.org \
    --cc=josh@joshtriplett.org \
    --cc=jroedel@suse.de \
    --cc=kexec@lists.infradead.org \
    --cc=kys@microsoft.com \
    --cc=linux-arch@vger.kernel.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-hyperv@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-remoteproc@vger.kernel.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=mathieu.desnoyers@efficios.com \
    --cc=mathieu.poirier@linaro.org \
    --cc=mcgrof@kernel.org \
    --cc=mikelley@microsoft.com \
    --cc=mingo@redhat.com \
    --cc=minyard@acm.org \
    --cc=mpe@ellerman.id.au \
    --cc=ohad@wizery.com \
    --cc=openipmi-developer@lists.sourceforge.net \
    --cc=paulmck@kernel.org \
    --cc=paulus@samba.org \
    --cc=penguin-kernel@i-love.sakura.ne.jp \
    --cc=rcu@vger.kernel.org \
    --cc=rostedt@goodmis.org \
    --cc=rppt@kernel.org \
    --cc=sthemmin@microsoft.com \
    --cc=tglx@linutronix.de \
    --cc=vbabka@suse.cz \
    --cc=wei.liu@kernel.org \
    --cc=x86@kernel.org \
    --cc=yzaikin@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.