Re: [PATCH robh next] dt-bindings: bus: add Broadcom CRU

[Rob Herring <robh@kernel.org>]

On Tue, Mar 09, 2021 at 03:22:41PM +0100, Rafał Miłecki wrote:
> From: Rafał Miłecki <rafal@milecki.pl>
> 
> CRU is a block used in Northstar devices. It can be seen in the
> bcm5301x.dtsi and this binding documents its proper usage.
> 
> Signed-off-by: Rafał Miłecki <rafal@milecki.pl>
> ---
>  .../devicetree/bindings/bus/brcm,cru.yaml     | 41 +++++++++++++++++++
>  1 file changed, 41 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/bus/brcm,cru.yaml
> 
> diff --git a/Documentation/devicetree/bindings/bus/brcm,cru.yaml b/Documentation/devicetree/bindings/bus/brcm,cru.yaml
> new file mode 100644
> index 000000000000..c3b1ca53a443
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/bus/brcm,cru.yaml
> @@ -0,0 +1,41 @@
> +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/bus/brcm,cru.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Broadcom CRU
> +
> +maintainers:
> +  - Rafał Miłecki <rafal@milecki.pl>
> +
> +description: |
> +  Broadcom CRU ("Clock and Reset Unit" or "Central Resource Unit") is a hardware
> +  block grouping smaller blocks. It contains e.g. clocks, pinctrl, USB PHY and

Are these really separate blocks? I really need to see a complete 
binding for the block.

> +  thermal.
> +
> +allOf:
> +  - $ref: /schemas/simple-bus.yaml#

I don't think this should be a 'simple-bus'. Maybe 'simple-mfd' instead.

> +
> +properties:
> +  compatible:
> +    contains:
> +      const: brcm,cru

This should be SoC specific.

> +
> +  reg:
> +    description: CRU registers
> +
> +unevaluatedProperties: false
> +
> +required:
> +  - reg
> +
> +examples:
> +  - |
> +    cru-bus@1800c100 {
> +      compatible = "brcm,cru", "simple-bus";
> +      reg = <0x1800c100 0x1d0>;
> +      ranges;
> +      #address-cells = <1>;
> +      #size-cells = <1>;
> +    };
> -- 
> 2.26.2
> 

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel