[hch-block:nvme-generic 13/13] drivers/nvme/host/core.c:4531:5-11: inconsistent IS_ERR and PTR_ERR on line 4532.

[hch-block:nvme-generic 13/13] drivers/nvme/host/core.c:4531:5-11: inconsistent IS_ERR and PTR_ERR on line 4532.

[kernel test robot]

[-- Attachment #1: Type: text/plain, Size: 954 bytes --]

CC: kbuild-all(a)lists.01.org
TO: Minwoo Im <minwoo.im.dev@gmail.com>
CC: Christoph Hellwig <hch@lst.de>
CC: "Javier González" <javier.gonz@samsung.com>

tree:   git://git.infradead.org/users/hch/block.git nvme-generic
head:   51d5434458b4f2182f4d108c9016ac9402529ee7
commit: 51d5434458b4f2182f4d108c9016ac9402529ee7 [13/13] nvme: introduce generic per-namespace chardev
config: riscv-randconfig-c024-20210407 (attached as .config)
compiler: riscv64-linux-gcc (GCC) 9.3.0

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Julia Lawall <julia.lawall@lip6.fr>


cocci warnings: (new ones prefixed by >>)
>> drivers/nvme/host/core.c:4531:5-11: inconsistent IS_ERR and PTR_ERR on line 4532.

Please review and possibly fold the followup patch.

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 28233 bytes --]

[PATCH] nvme: fix odd_ptr_err.cocci warnings

[kernel test robot]

[-- Attachment #1: Type: text/plain, Size: 1234 bytes --]

From: kernel test robot <lkp@intel.com>

drivers/nvme/host/core.c:4531:5-11: inconsistent IS_ERR and PTR_ERR on line 4532.

 PTR_ERR should access the value just tested by IS_ERR

Semantic patch information:
 There can be false positives in the patch case, where it is the call to
 IS_ERR that is wrong.

Generated by: scripts/coccinelle/tests/odd_ptr_err.cocci

Fixes: 51d5434458b4 ("nvme: introduce generic per-namespace chardev")
CC: Minwoo Im <minwoo.im.dev@gmail.com>
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: kernel test robot <lkp@intel.com>
---

tree:   git://git.infradead.org/users/hch/block.git nvme-generic
head:   51d5434458b4f2182f4d108c9016ac9402529ee7
commit: 51d5434458b4f2182f4d108c9016ac9402529ee7 [13/13] nvme: introduce generic per-namespace chardev

 core.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- a/drivers/nvme/host/core.c
+++ b/drivers/nvme/host/core.c
@@ -4529,7 +4529,7 @@ static int __init nvme_core_init(void)
 
 	nvme_ns_chr_class = class_create(THIS_MODULE, "nvme-generic");
 	if (IS_ERR(nvme_ns_chr_class)) {
-		result = PTR_ERR(nvme_subsys_class);
+		result = PTR_ERR(nvme_ns_chr_class);
 		goto unregister_generic_ns;
 	}