All of lore.kernel.org
 help / color / mirror / Atom feed
From: Manivannan Sadhasivam <mani@kernel.org>
To: Laibin Qiu <qiulaibin@huawei.com>
Cc: ulf.hansson@linaro.org, afaerber@suse.de, yuehaibing@huawei.com,
	linux-mmc@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-actions@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH -next] mmc: owl-mmc: Remove unnecessary error log
Date: Fri, 9 Apr 2021 10:46:13 +0530	[thread overview]
Message-ID: <20210409051613.GA4376@work> (raw)
In-Reply-To: <20210409023349.3325907-1-qiulaibin@huawei.com>

On Fri, Apr 09, 2021 at 10:33:49AM +0800, Laibin Qiu wrote:
> devm_ioremap_resource() has recorded error log, so it's
> unnecessary to record log again.
> 
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Laibin Qiu <qiulaibin@huawei.com>

Reviewed-by: Manivannan Sadhasivam <mani@kernel.org>

Thanks,
Mani

> ---
>  drivers/mmc/host/owl-mmc.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/mmc/host/owl-mmc.c b/drivers/mmc/host/owl-mmc.c
> index 5490962dc8e5..3dc143b03939 100644
> --- a/drivers/mmc/host/owl-mmc.c
> +++ b/drivers/mmc/host/owl-mmc.c
> @@ -581,7 +581,6 @@ static int owl_mmc_probe(struct platform_device *pdev)
>  	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
>  	owl_host->base = devm_ioremap_resource(&pdev->dev, res);
>  	if (IS_ERR(owl_host->base)) {
> -		dev_err(&pdev->dev, "Failed to remap registers\n");
>  		ret = PTR_ERR(owl_host->base);
>  		goto err_free_host;
>  	}
> -- 
> 2.25.1
> 

WARNING: multiple messages have this Message-ID (diff)
From: Manivannan Sadhasivam <mani@kernel.org>
To: Laibin Qiu <qiulaibin@huawei.com>
Cc: ulf.hansson@linaro.org, afaerber@suse.de, yuehaibing@huawei.com,
	linux-mmc@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-actions@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH -next] mmc: owl-mmc: Remove unnecessary error log
Date: Fri, 9 Apr 2021 10:46:13 +0530	[thread overview]
Message-ID: <20210409051613.GA4376@work> (raw)
In-Reply-To: <20210409023349.3325907-1-qiulaibin@huawei.com>

On Fri, Apr 09, 2021 at 10:33:49AM +0800, Laibin Qiu wrote:
> devm_ioremap_resource() has recorded error log, so it's
> unnecessary to record log again.
> 
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Laibin Qiu <qiulaibin@huawei.com>

Reviewed-by: Manivannan Sadhasivam <mani@kernel.org>

Thanks,
Mani

> ---
>  drivers/mmc/host/owl-mmc.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/mmc/host/owl-mmc.c b/drivers/mmc/host/owl-mmc.c
> index 5490962dc8e5..3dc143b03939 100644
> --- a/drivers/mmc/host/owl-mmc.c
> +++ b/drivers/mmc/host/owl-mmc.c
> @@ -581,7 +581,6 @@ static int owl_mmc_probe(struct platform_device *pdev)
>  	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
>  	owl_host->base = devm_ioremap_resource(&pdev->dev, res);
>  	if (IS_ERR(owl_host->base)) {
> -		dev_err(&pdev->dev, "Failed to remap registers\n");
>  		ret = PTR_ERR(owl_host->base);
>  		goto err_free_host;
>  	}
> -- 
> 2.25.1
> 

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2021-04-09  5:16 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-09  2:33 [PATCH -next] mmc: owl-mmc: Remove unnecessary error log Laibin Qiu
2021-04-09  2:33 ` Laibin Qiu
2021-04-09  5:16 ` Manivannan Sadhasivam [this message]
2021-04-09  5:16   ` Manivannan Sadhasivam
2021-04-12  7:52 ` Ulf Hansson
2021-04-12  7:52   ` Ulf Hansson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210409051613.GA4376@work \
    --to=mani@kernel.org \
    --cc=afaerber@suse.de \
    --cc=linux-actions@lists.infradead.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mmc@vger.kernel.org \
    --cc=qiulaibin@huawei.com \
    --cc=ulf.hansson@linaro.org \
    --cc=yuehaibing@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.