From: Segher Boessenkool <segher@kernel.crashing.org>
To: Christophe Leroy <christophe.leroy@csgroup.eu>
Cc: pmladek@suse.com, peterz@infradead.org,
linux-kernel@vger.kernel.org, paulus@samba.org,
kan.liang@linux.intel.com, mikey@neuling.org,
maddy@linux.ibm.com, haren@linux.ibm.com, aik@ozlabs.ru,
kjain@linux.ibm.com, ravi.bangoria@linux.ibm.com,
john.ogness@linutronix.de, alistair@popple.id.au,
npiggin@gmail.com, jniethe5@gmail.com,
atrajeev@linux.vnet.ibm.com, Xiongwei Song <sxwjean@me.com>,
Xiongwei Song <sxwjean@gmail.com>,
oleg@redhat.com, aneesh.kumar@linux.ibm.com,
akpm@linux-foundation.org, linuxppc-dev@lists.ozlabs.org,
rppt@kernel.org
Subject: Re: [PATCH v3] powerpc/traps: Enhance readability for trap types
Date: Fri, 9 Apr 2021 12:45:06 -0500 [thread overview]
Message-ID: <20210409174506.GH26583@gate.crashing.org> (raw)
In-Reply-To: <70ece993-12bd-335c-d246-914564eb51dd@csgroup.eu>
On Fri, Apr 09, 2021 at 06:14:19PM +0200, Christophe Leroy wrote:
> >+#define INTERRUPT_SYSTEM_RESET 0x100
>
> INT_SRESET
SRESET exists on many PowerPC, it means "soft reset". Not the same
thing at all.
I think "INT" is not a great prefix fwiw, there are many things you can
abbr to "INT".
> >+#define INTERRUPT_DATA_SEGMENT 0x380
>
> INT_DSEG
exceptions-64s.S calls this "DSLB" (I remember "DSSI" though -- but neither
is a very official name). It probably is a good idea to look at that
existing code, not make up even more new names :-)
> >+#define INTERRUPT_DOORBELL 0xa00
>
> INT_DBELL
That saves three characters and makes it very not understandable.
Segher
WARNING: multiple messages have this Message-ID (diff)
From: Segher Boessenkool <segher@kernel.crashing.org>
To: Christophe Leroy <christophe.leroy@csgroup.eu>
Cc: Xiongwei Song <sxwjean@me.com>,
mpe@ellerman.id.au, benh@kernel.crashing.org, paulus@samba.org,
oleg@redhat.com, npiggin@gmail.com, aneesh.kumar@linux.ibm.com,
ravi.bangoria@linux.ibm.com, mikey@neuling.org,
haren@linux.ibm.com, akpm@linux-foundation.org, rppt@kernel.org,
jniethe5@gmail.com, atrajeev@linux.vnet.ibm.com,
maddy@linux.ibm.com, peterz@infradead.org, kjain@linux.ibm.com,
kan.liang@linux.intel.com, aik@ozlabs.ru, alistair@popple.id.au,
pmladek@suse.com, john.ogness@linutronix.de,
Xiongwei Song <sxwjean@gmail.com>,
linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] powerpc/traps: Enhance readability for trap types
Date: Fri, 9 Apr 2021 12:45:06 -0500 [thread overview]
Message-ID: <20210409174506.GH26583@gate.crashing.org> (raw)
In-Reply-To: <70ece993-12bd-335c-d246-914564eb51dd@csgroup.eu>
On Fri, Apr 09, 2021 at 06:14:19PM +0200, Christophe Leroy wrote:
> >+#define INTERRUPT_SYSTEM_RESET 0x100
>
> INT_SRESET
SRESET exists on many PowerPC, it means "soft reset". Not the same
thing at all.
I think "INT" is not a great prefix fwiw, there are many things you can
abbr to "INT".
> >+#define INTERRUPT_DATA_SEGMENT 0x380
>
> INT_DSEG
exceptions-64s.S calls this "DSLB" (I remember "DSSI" though -- but neither
is a very official name). It probably is a good idea to look at that
existing code, not make up even more new names :-)
> >+#define INTERRUPT_DOORBELL 0xa00
>
> INT_DBELL
That saves three characters and makes it very not understandable.
Segher
next prev parent reply other threads:[~2021-04-09 17:52 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-08 14:07 [PATCH v3] powerpc/traps: Enhance readability for trap types Xiongwei Song
2021-04-08 14:07 ` Xiongwei Song
2021-04-08 16:54 ` kernel test robot
2021-04-09 16:14 ` Christophe Leroy
2021-04-09 16:14 ` Christophe Leroy
2021-04-09 17:45 ` Segher Boessenkool [this message]
2021-04-09 17:45 ` Segher Boessenkool
2021-04-10 0:04 ` Michael Ellerman
2021-04-10 0:04 ` Michael Ellerman
2021-04-10 8:33 ` Xiongwei Song
2021-04-10 8:33 ` Xiongwei Song
2021-04-10 9:42 ` Christophe Leroy
2021-04-10 9:42 ` Christophe Leroy
2021-04-10 16:46 ` Segher Boessenkool
2021-04-10 16:46 ` Segher Boessenkool
2021-04-10 8:31 ` Xiongwei Song
2021-04-10 8:31 ` Xiongwei Song
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210409174506.GH26583@gate.crashing.org \
--to=segher@kernel.crashing.org \
--cc=aik@ozlabs.ru \
--cc=akpm@linux-foundation.org \
--cc=alistair@popple.id.au \
--cc=aneesh.kumar@linux.ibm.com \
--cc=atrajeev@linux.vnet.ibm.com \
--cc=christophe.leroy@csgroup.eu \
--cc=haren@linux.ibm.com \
--cc=jniethe5@gmail.com \
--cc=john.ogness@linutronix.de \
--cc=kan.liang@linux.intel.com \
--cc=kjain@linux.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=maddy@linux.ibm.com \
--cc=mikey@neuling.org \
--cc=npiggin@gmail.com \
--cc=oleg@redhat.com \
--cc=paulus@samba.org \
--cc=peterz@infradead.org \
--cc=pmladek@suse.com \
--cc=ravi.bangoria@linux.ibm.com \
--cc=rppt@kernel.org \
--cc=sxwjean@gmail.com \
--cc=sxwjean@me.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.